[Client] Settings: extract SettingsView from DlgSettings

Move the search bar, tab bar, stacked pages and search results out of
DlgSettings into a reusable SettingsView widget. The dialog becomes a
thin frame (title, OK button, close validation) delegating to the view.
No visual or behavior change; tr() contexts preserved as DlgSettings.

cockatrice/src/interface/widgets/dialogs/dlg_settings.h

@@ -1,105 +1,59 @@
 /**
  * @file dlg_settings.h
- * @brief Main settings dialog for the Cockatrice client
+ * @brief Main settings dialog for the Cockatrice client (thin frame around SettingsView)
  * @ingroup Dialogs
  */
 #ifndef DLG_SETTINGS_H
 #define DLG_SETTINGS_H
 
+#include "settings_view.h"
+
 #include <QDialog>
-#include <QList>
 #include <QLoggingCategory>
-#include <QString>
-#include <QStringList>
 #include <qtmetamacros.h>
 
 class QPushButton;
-class QModelIndex;
-class QWidget;
+class AbstractSettingsPage;
 
 inline Q_LOGGING_CATEGORY(DlgSettingsLog, "dlg_settings");
 
-class QStackedWidget;
-class QToolButton;
-class QListView;
-class QLineEdit;
-class AbstractSettingsPage;
-class SettingsSearchModel;
-class SettingsSearchDelegate;
-
 /**
- * @brief Main application settings dialog with tabbed navigation and search
+ * @brief Main application settings dialog hosting the shared SettingsView
  *
- * Provides a modern settings interface organized into tabbed pages. Users can
- * either navigate by clicking tabs or search for specific settings using the
- * built-in search bar. Search results are filtered and ranked by relevance.
+ * Thin QDialog frame around SettingsView: only the window title, the OK button
+ * and the close validation live here. All pages, navigation and search are
+ * owned by SettingsView so other hosts (e.g. a settings tab) can reuse them.
  */
 class DlgSettings : public QDialog
 {
     Q_OBJECT
 public:
-    /**
-     * @brief Page order in the tab bar, matching the order pages are added in setupUi()
-     *
-     * Use these values instead of raw indices so reordering pages never silently
-     * breaks external callers like tab_room.cpp.
-     */
-    enum SettingsPage
-    {
-        GeneralPage = 0,
-        AppearancePage,
-        UserInterfacePage,
-        DeckEditorPage,
-        StoragePage,
-        MessagesPage,
-        SoundPage,
-        ShortcutsPage,
-        NumPages
-    };
+    using SettingsPage = SettingsView::SettingsPage;
+    static constexpr SettingsPage GeneralPage = SettingsView::GeneralPage;
+    static constexpr SettingsPage AppearancePage = SettingsView::AppearancePage;
+    static constexpr SettingsPage UserInterfacePage = SettingsView::UserInterfacePage;
+    static constexpr SettingsPage DeckEditorPage = SettingsView::DeckEditorPage;
+    static constexpr SettingsPage StoragePage = SettingsView::StoragePage;
+    static constexpr SettingsPage MessagesPage = SettingsView::MessagesPage;
+    static constexpr SettingsPage SoundPage = SettingsView::SoundPage;
+    static constexpr SettingsPage ShortcutsPage = SettingsView::ShortcutsPage;
+    static constexpr SettingsPage NumPages = SettingsView::NumPages;
 
     explicit DlgSettings(QWidget *parent = nullptr);
     void setTab(int index);
     AbstractSettingsPage *page(SettingsPage which) const;
 
 private slots:
-    void onTabClicked(int index);
-    void onSearchTextChanged(const QString &text);
-    void onSearchResultClicked(const QModelIndex &index);
     void updateLanguage();
 
 private:
-    // UI elements
-    QLineEdit *searchEdit;           ///< Search bar for filtering settings
-    QWidget *tabBarWidget;           ///< Container widget for the tab buttons
-    QList<QToolButton *> tabButtons; ///< Navigation tab buttons
-    QStackedWidget *pagesWidget;     ///< Stacked widget containing settings pages
-    QListView *searchResultsView;    ///< Search results list view
-    QWidget *pagesContainer;         ///< Container stacking pages and search results
-    QPushButton *okButton;           ///< Button to close the dialog
-
-    // Data
-    QList<AbstractSettingsPage *> pages;    ///< All settings page instances
-    SettingsSearchModel *searchModel;       ///< Model for search results
-    SettingsSearchDelegate *searchDelegate; ///< Delegate for search result rendering
-    int currentTabIndex;                    ///< Currently active tab index
-    bool searchActive;                      ///< Whether search mode is active
-
-    void setupUi();
-    void setupTabBar();
-    void buildSearchIndex();
-    void switchToTabMode();
-    void switchToSearchMode();
-    void navigateToSearchResult(const QModelIndex &index);
-    void setActiveTab(int index);
-    static void flashWidget(QWidget *widget);
-    static QStringList translatedPageNames();
+    SettingsView *settingsView; ///< Shared settings content
+    QPushButton *okButton;      ///< Button to close the dialog
 
     void retranslateUi();
-    void retranslateTabNames();
 
 protected:
     void closeEvent(QCloseEvent *event) override;
-    bool eventFilter(QObject *watched, QEvent *event) override;
 };
 
 #endif // DLG_SETTINGS_H