jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-07-06 05:23:56 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

refactor: Create forManagedComponents method

Browse source
This commit is contained in:
Mmonge123 2026-05-25 13:35:45 +01:00
parent b7b7a385ea
commit c8b6d7bf83
2 changed files with 11 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
cockatrice/src/game/player/menu/player_menu.cpp
View file

@ -144,9 +144,7 @@ void PlayerMenu::setShortcutsActive()
} }
if (!player->getGame()->getGameMetaInfo()->started()) { if (!player->getGame()->getGameMetaInfo()->started()) {
for (auto *component : managedComponents) { forManagedComponents([](auto *component) { component->setShortcutsInactive(); });
component->setShortcutsInactive();
}
QMapIterator<int, AbstractCounter *> counterIterator(player->getCounters()); QMapIterator<int, AbstractCounter *> counterIterator(player->getCounters());
while (counterIterator.hasNext()) { while (counterIterator.hasNext()) {
@ -159,9 +157,7 @@ void PlayerMenu::setShortcutsActive()
return; return;
} }
for (auto *component : managedComponents) { forManagedComponents([](auto *component) { component->setShortcutsActive(); });
component->setShortcutsActive();
}
// Counters implement AbstractPlayerComponent but are iterated via Player::counters // Counters implement AbstractPlayerComponent but are iterated via Player::counters
// (the authoritative source) rather than managedComponents to avoid a redundant // (the authoritative source) rather than managedComponents to avoid a redundant
@ -176,9 +172,7 @@ void PlayerMenu::setShortcutsInactive()
{ {
shortcutsActive = false; shortcutsActive = false;
for (auto *component : managedComponents) { forManagedComponents([](auto *component) { component->setShortcutsInactive(); });
component->setShortcutsInactive();
}
QMapIterator<int, AbstractCounter *> counterIterator(player->getCounters()); QMapIterator<int, AbstractCounter *> counterIterator(player->getCounters());
while (counterIterator.hasNext()) { while (counterIterator.hasNext()) {

8
cockatrice/src/game/player/menu/player_menu.h
View file

@ -111,6 +111,14 @@ private:
managedComponents.append(component); managedComponents.append(component);
return component; return component;
} }
/// Runs a normal for loop over all managedComponents, applying the provided function.
template <typename Func> void forManagedComponents(Func func)
{
for (auto *component : managedComponents) {
func(component);
}
}
}; };
#endif // COCKATRICE_PLAYER_MENU_H #endif // COCKATRICE_PLAYER_MENU_H