Prevent server crash if DB is down and game is attempted to be created (#5600)

This commit is contained in:
Zach H 2025-02-09 17:11:00 -05:00 committed by GitHub
parent 80bd783d54
commit cb060f43b5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 13 deletions

View file

@ -709,7 +709,9 @@ bool Servatrice_DatabaseInterface::userSessionExists(const QString &userName)
"select 1 from {prefix}_sessions where user_name = :user_name and id_server = :id_server and end_time is null");
query->bindValue(":id_server", server->getServerID());
query->bindValue(":user_name", userName);
execSqlQuery(query);
if (!execSqlQuery(query)) {
return false;
};
return query->next();
}
@ -745,15 +747,9 @@ void Servatrice_DatabaseInterface::endSession(qint64 sessionId)
if (!checkSql())
return;
QSqlQuery *query = prepareQuery("lock tables {prefix}_sessions write");
execSqlQuery(query);
query = prepareQuery("update {prefix}_sessions set end_time=NOW() where id = :id_session");
auto *query = prepareQuery("update {prefix}_sessions set end_time=NOW() where id = :id_session");
query->bindValue(":id_session", sessionId);
execSqlQuery(query);
query = prepareQuery("unlock tables");
execSqlQuery(query);
}
QMap<QString, ServerInfo_User> Servatrice_DatabaseInterface::getBuddyList(const QString &name)
@ -811,7 +807,10 @@ int Servatrice_DatabaseInterface::getNextGameId()
return -1;
QSqlQuery *query = prepareQuery("insert into {prefix}_games (time_started) values (now())");
execSqlQuery(query);
if (!execSqlQuery(query)) {
return -1;
}
return query->lastInsertId().toInt();
}
@ -822,7 +821,10 @@ int Servatrice_DatabaseInterface::getNextReplayId()
return -1;
QSqlQuery *query = prepareQuery("insert into {prefix}_replays (id_game) values (NULL)");
execSqlQuery(query);
if (!execSqlQuery(query)) {
return -1;
}
return query->lastInsertId().toInt();
}