jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-06-30 10:33:54 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

[DeckListModel] Clean up recursive updates (#6457)

Browse source
This commit is contained in:
RickyRister 2025-12-29 22:13:34 -08:00 • committed by GitHub
parent ce4a3bf118
commit cb2cf31cec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 28 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

33
libcockatrice_models/libcockatrice/models/deck_list/deck_list_model.cpp
View file

@ -178,22 +178,6 @@ QVariant DeckListModel::data(const QModelIndex &index, int role) const
} }
} }
void DeckListModel::emitBackgroundUpdates(const QModelIndex &parent)
{
int rows = rowCount(parent);
if (rows == 0)
return;
QModelIndex topLeft = index(0, 0, parent);
QModelIndex bottomRight = index(rows - 1, columnCount() - 1, parent);
emit dataChanged(topLeft, bottomRight, {Qt::BackgroundRole});
for (int r = 0; r < rows; ++r) {
QModelIndex child = index(r, 0, parent);
emitBackgroundUpdates(child);
}
}
QVariant DeckListModel::headerData(const int section, const Qt::Orientation orientation, const int role) const QVariant DeckListModel::headerData(const int section, const Qt::Orientation orientation, const int role) const
{ {
if ((role != Qt::DisplayRole) || (orientation != Qt::Horizontal)) { if ((role != Qt::DisplayRole) || (orientation != Qt::Horizontal)) {
@ -252,6 +236,22 @@ Qt::ItemFlags DeckListModel::flags(const QModelIndex &index) const
return result; return result;
} }
void DeckListModel::emitBackgroundUpdates(const QModelIndex &parent)
{
int rows = rowCount(parent);
if (rows == 0)
return;
QModelIndex topLeft = index(0, 0, parent);
QModelIndex bottomRight = index(rows - 1, columnCount() - 1, parent);
emit dataChanged(topLeft, bottomRight, {Qt::BackgroundRole});
for (int r = 0; r < rows; ++r) {
QModelIndex child = index(r, 0, parent);
emitBackgroundUpdates(child);
}
}
void DeckListModel::emitRecursiveUpdates(const QModelIndex &index) void DeckListModel::emitRecursiveUpdates(const QModelIndex &index)
{ {
if (!index.isValid()) { if (!index.isValid()) {
@ -294,7 +294,6 @@ bool DeckListModel::setData(const QModelIndex &index, const QVariant &value, con
deckList->refreshDeckHash(); deckList->refreshDeckHash();
emit deckHashChanged(); emit deckHashChanged();
emit dataChanged(index, index);
return true; return true;
} }

18
libcockatrice_models/libcockatrice/models/deck_list/deck_list_model.h
View file

@ -269,12 +269,6 @@ public:
bool setData(const QModelIndex &index, const QVariant &value, int role) override; bool setData(const QModelIndex &index, const QVariant &value, int role) override;
bool removeRows(int row, int count, const QModelIndex &parent) override; bool removeRows(int row, int count, const QModelIndex &parent) override;
/**
* Recursively emits the dataChanged signal for all child nodes.
* @param parent The parent node
*/
void emitBackgroundUpdates(const QModelIndex &parent);
/** /**
* @brief Finds a card by name, zone, and optional identifiers. * @brief Finds a card by name, zone, and optional identifiers.
* @param cardName The card's name. * @param cardName The card's name.
@ -389,7 +383,19 @@ private:
const QString &providerId = "", const QString &providerId = "",
const QString &cardNumber = "") const; const QString &cardNumber = "") const;
/**
* @brief Recursively emits the dataChanged signal with role as Qt::BackgroundRole for all indices that are children
* of the given node. This is used to update the background color when changing formats.
* @param parent The parent node
*/
void emitBackgroundUpdates(const QModelIndex &parent);
/**
* @brief Recursively emits the dataChanged signal for the given node and all parent nodes.
* @param index The parent node
*/
void emitRecursiveUpdates(const QModelIndex &index); void emitRecursiveUpdates(const QModelIndex &index);
void sortHelper(InnerDecklistNode *node, Qt::SortOrder order); void sortHelper(InnerDecklistNode *node, Qt::SortOrder order);
template <typename T> T getNode(const QModelIndex &index) const template <typename T> T getNode(const QModelIndex &index) const