Fix spoiler settings state after reopen and while disabled

Reopen Settings while an application-owned update is running: the new page
now observes that updater, so the button reads Updating... and re-enables
on completion instead of offering a second update that cancels the first.
Observation does not take ownership: only updaters the page creates are
retired with deleteLater, because the launch check is stack-allocated.

When spoilers are off, the hint now describes what Reload Card Database
actually does, stays readable, and wraps instead of clipping.

cockatrice/src/client/network/update/card_spoiler/spoiler_background_updater.cpp

@@ -289,6 +289,11 @@ void SpoilerBackgroundUpdater::finish(const QString &error, bool updated)
     }
 }
 
+SpoilerBackgroundUpdater *SpoilerBackgroundUpdater::current()
+{
+    return currentUpdater;
+}
+
 SpoilerBackgroundUpdater *SpoilerBackgroundUpdater::deleteSpoilerFile()
 {
     // Deletion and the following reload share the operation lifetime. Callers can

cockatrice/src/client/network/update/card_spoiler/spoiler_background_updater.h

@@ -32,6 +32,9 @@ public:
     // Queues removal and reload; the application owns the returned updater and
     // deletes it on completion. Callers can connect its failure/completion signals.
     static SpoilerBackgroundUpdater *deleteSpoilerFile();
+    // The operation currently running, if any. The updater outlives the page that
+    // started it, so a reopened page uses this to observe the in-flight update.
+    static SpoilerBackgroundUpdater *current();
 
 private slots:
     void begin();

cockatrice/src/interface/widgets/settings_page/deck_editor_settings_page.cpp

@@ -121,12 +121,19 @@ DeckEditorSettingsPage::DeckEditorSettingsPage()
     lpSpoilerGrid->addWidget(&lastUpdatedLabel, 2, 0);
     lpSpoilerGrid->addWidget(updateNowButton, 2, 1);
     lpSpoilerGrid->addWidget(&infoOnSpoilersLabel, 3, 0, 1, 3, Qt::AlignTop);
+    infoOnSpoilersLabel.setWordWrap(true);
 
     // On a change to the checkbox, hide/un-hide the other fields
     connect(&mcDownloadSpoilersCheckBox, &QCheckBox::toggled, &SettingsCache::instance().downloads(),
             &DownloadSettings::setDownloadSpoilerStatus);
     connect(&mcDownloadSpoilersCheckBox, &QCheckBox::toggled, this, &DeckEditorSettingsPage::setSpoilersEnabled);
 
+    // The updater is application-owned and outlives this page, so a Settings page
+    // reopened mid-update must observe the operation that is still running.
+    if (auto *runningUpdater = SpoilerBackgroundUpdater::current()) {
+        observeSpoilerUpdater(runningUpdater);
+    }
+
     mpGeneralGroupBox = new QGroupBox;
     mpGeneralGroupBox->setLayout(lpGeneralGrid);
 
@@ -334,9 +341,16 @@ void DeckEditorSettingsPage::updateSpoilers()
     }
     // Application ownership lets either operation finish after settings closes.
     // When disabled, the same button retries file removal and the local reload.
-    auto *sbu = SettingsCache::instance().downloads().getDownloadSpoilersStatus()
+    SpoilerBackgroundUpdater *sbu;
-                    ? new SpoilerBackgroundUpdater(QCoreApplication::instance(), true)
+    if (SettingsCache::instance().downloads().getDownloadSpoilersStatus()) {
-                    : SpoilerBackgroundUpdater::deleteSpoilerFile();
+        sbu = new SpoilerBackgroundUpdater(QCoreApplication::instance(), true);
+        // Only an updater this page creates is retired by deleteLater: observation
+        // may attach to the stack-allocated launch updater, which must not be deleted.
+        connect(sbu, &SpoilerBackgroundUpdater::spoilerCheckerDone, sbu, &QObject::deleteLater);
+    } else {
+        // deleteSpoilerFile() wires its own deleteLater.
+        sbu = SpoilerBackgroundUpdater::deleteSpoilerFile();
+    }
     observeSpoilerUpdater(sbu);
 }
 
@@ -350,7 +364,6 @@ void DeckEditorSettingsPage::observeSpoilerUpdater(SpoilerBackgroundUpdater *sbu
             unlockSettings();
         }
     });
-    connect(sbu, &SpoilerBackgroundUpdater::spoilerCheckerDone, sbu, &QObject::deleteLater, Qt::UniqueConnection);
     connect(sbu, &SpoilerBackgroundUpdater::spoilerUpdateFailed, this, [this, sbu](const QString &message) {
         if (spoilerUpdater != sbu) {
             return;
@@ -370,6 +383,13 @@ void DeckEditorSettingsPage::unlockSettings()
                                  ? tr("Update Spoilers")
                                  : tr("Reload Card Database"));
     lastUpdatedLabel.setText(tr("Last Change") + ": " + getLastUpdateTime());
+    infoOnSpoilersLabel.setText(
+        SettingsCache::instance().downloads().getDownloadSpoilersStatus()
+            ? tr("Spoilers download automatically on launch") + "\n" +
+                  tr("Press the button to manually update without relaunching") + "\n\n" +
+                  tr("Updates continue if you close settings")
+            : tr("Spoilers are off. Reload Card Database removes any downloaded spoiler file and reloads your "
+                 "card data."));
 }
 
 QString DeckEditorSettingsPage::getLastUpdateTime()
@@ -407,7 +427,9 @@ void DeckEditorSettingsPage::setSpoilersEnabled(bool anInput)
     mpSpoilerSavePathLineEdit->setEnabled(anInput);
     mpSpoilerPathButton->setEnabled(anInput);
     lastUpdatedLabel.setEnabled(anInput);
-    infoOnSpoilersLabel.setEnabled(anInput);
+    // The hint explains the button in both states, especially the disabled-state
+    // Reload Card Database action, so keep it readable while spoilers are off.
+    infoOnSpoilersLabel.setEnabled(true);
 
     // Only react to the user disabling the setting. The constructor calls this to
     // initialize the controls, and a leftover spoiler file is recovered through the
@@ -425,9 +447,6 @@ void DeckEditorSettingsPage::retranslateUi()
     mcDownloadSpoilersCheckBox.setText(tr("Download Spoilers Automatically"));
     mcSpoilerSaveLabel.setText(tr("Spoiler Location:"));
     lastUpdatedLabel.setText(tr("Last Change") + ": " + getLastUpdateTime());
-    infoOnSpoilersLabel.setText(tr("Spoilers download automatically on launch") + "\n" +
-                                tr("Press the button to manually update without relaunching") + "\n\n" +
-                                tr("Updates continue if you close settings"));
     picDownloadCheckBox.setText(tr("Download card pictures on the fly"));
     urlLinkLabel.setText(QString("<a href='%1'>%2</a>").arg(WIKI_CUSTOM_PIC_URL).arg(tr("How to add a custom URL")));
     resetDownloadURLs.setText(tr("Reset Download URLs"));