From cc9847c33b0b5f93ae6fe8c9b653c073cc4d7298 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Mon, 5 Oct 2026 07:31:09 +0200 Subject: [PATCH] [Client] Move the turn order dialog strings into retranslateUi Follows the DlgInviteToGame convention so the dialog can be retranslated instead of freezing its strings at construction time. --- .../widgets/dialogs/dlg_turn_order.cpp | 17 +++++++++++++---- .../interface/widgets/dialogs/dlg_turn_order.h | 2 ++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/cockatrice/src/interface/widgets/dialogs/dlg_turn_order.cpp b/cockatrice/src/interface/widgets/dialogs/dlg_turn_order.cpp index af0a264d7..01b7db076 100644 --- a/cockatrice/src/interface/widgets/dialogs/dlg_turn_order.cpp +++ b/cockatrice/src/interface/widgets/dialogs/dlg_turn_order.cpp @@ -16,11 +16,11 @@ DlgTurnOrder::DlgTurnOrder(const QStringList &_playerNames, QWidget *parent) listWidget->setCurrentRow(0); connect(listWidget, &QListWidget::currentRowChanged, this, &DlgTurnOrder::selectionChanged); - moveUpButton = new QPushButton(tr("Move up"), this); + moveUpButton = new QPushButton(this); connect(moveUpButton, &QPushButton::clicked, this, &DlgTurnOrder::actMoveUp); - moveDownButton = new QPushButton(tr("Move down"), this); + moveDownButton = new QPushButton(this); connect(moveDownButton, &QPushButton::clicked, this, &DlgTurnOrder::actMoveDown); - randomizeButton = new QPushButton(tr("Randomize"), this); + randomizeButton = new QPushButton(this); connect(randomizeButton, &QPushButton::clicked, this, &DlgTurnOrder::actRandomize); auto *buttonColumn = new QVBoxLayout; @@ -43,10 +43,19 @@ DlgTurnOrder::DlgTurnOrder(const QStringList &_playerNames, QWidget *parent) setLayout(mainLayout); updateButtons(); - setWindowTitle(tr("Set turn order")); + + retranslateUi(); setMinimumWidth(300); } +void DlgTurnOrder::retranslateUi() +{ + setWindowTitle(tr("Set turn order")); + moveUpButton->setText(tr("Move up")); + moveDownButton->setText(tr("Move down")); + randomizeButton->setText(tr("Randomize")); +} + QStringList DlgTurnOrder::order() const { QStringList playerNames; diff --git a/cockatrice/src/interface/widgets/dialogs/dlg_turn_order.h b/cockatrice/src/interface/widgets/dialogs/dlg_turn_order.h index 1dc66316c..8b47bd5fe 100644 --- a/cockatrice/src/interface/widgets/dialogs/dlg_turn_order.h +++ b/cockatrice/src/interface/widgets/dialogs/dlg_turn_order.h @@ -36,6 +36,8 @@ private slots: public: explicit DlgTurnOrder(const QStringList &_playerNames, QWidget *parent = nullptr); + void retranslateUi(); + [[nodiscard]] bool randomize() const { return randomizeRequested;