jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-11-05 01:23:24 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

[Servatrice] Log room channel messages in audit log (#7479)

Browse source 
* [Servatrice] Log room channel messages and bump schema to 38

* Fixup: show room_channel audit rows and keep migration nullable

The log history query returns room_channel rows, but the log tab
dropped them. Render them in the room table with an extra Channel
column. Also drop the NOT NULL on target_type from the 37->38
migration so migrated schemas match the nullable servatrice.sql
definition (and strict-mode ALTERs cannot fail on legacy NULL rows).
Update the channel tests to the flag-based privilege model: the admin
fixture now carries IsModerator alongside IsAdmin, as the database
layer assigns.

---------

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
BruebachL 2026-10-16 22:46:39 +02:00 • committed by GitHub
parent c99113ab0e
commit ce51e7147d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 603 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

6
libcockatrice_network/libcockatrice/network/server/remote/server_database_interface.h
View file

@ -151,7 +151,8 @@ public:
MessageTargetRoom,
MessageTargetGame,
MessageTargetChat,
MessageTargetIslRoom
MessageTargetIslRoom,
MessageTargetRoomChannel
};
virtual void logMessage(const int /* senderId */,
const QString & /* senderName */,
@ -159,7 +160,8 @@ public:
const QString & /* logMessage */,
LogMessage_TargetType /* targetType */,
const int /* targetId */,
const QString & /* targetName */)
const QString & /* targetName */,
const QString & /* channel */ = QString())
{
}
virtual bool checkUserIsBanned(Server_ProtocolHandler * /* session */,

4
libcockatrice_network/libcockatrice/network/server/remote/server_protocolhandler.cpp
View file

@ -1003,6 +1003,10 @@ Response::ResponseCode Server_ProtocolHandler::cmdRoomChannelSay(const Command_R
room->say(QString::fromStdString(userInfo->name()), msg, channelId);
databaseInterface->logMessage(
userInfo->id(), QString::fromStdString(userInfo->name()), QString::fromStdString(userInfo->address()), msg,
Server_DatabaseInterface::MessageTargetRoomChannel, room->getId(), room->getName(), channelId);
return Response::RespOk;
}