From d03b04a21159ae66cac577a594dca3b3bcf60011 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Sun, 9 Aug 2026 03:36:09 +0200 Subject: [PATCH] Append VDS tutorial steps via reference instead of copy --- cockatrice/src/game_graphics/deckview/deck_view_container.cpp | 2 +- .../visual_deck_storage/visual_deck_storage_widget.cpp | 4 +--- .../widgets/visual_deck_storage/visual_deck_storage_widget.h | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/cockatrice/src/game_graphics/deckview/deck_view_container.cpp b/cockatrice/src/game_graphics/deckview/deck_view_container.cpp index d0722f73c..36ee53af7 100644 --- a/cockatrice/src/game_graphics/deckview/deck_view_container.cpp +++ b/cockatrice/src/game_graphics/deckview/deck_view_container.cpp @@ -135,7 +135,7 @@ TutorialSequence DeckViewContainer::generateTutorialSequence() {this, tr("There are multiple ways to select a deck:\n\n- From a local file" "\n- From the contents of your clipboard\nFrom an external online service")}); - deckViewContainerSequence = visualDeckStorageWidget->generateTutorialSequence(deckViewContainerSequence); + visualDeckStorageWidget->generateTutorialSequence(deckViewContainerSequence); return deckViewContainerSequence; } diff --git a/cockatrice/src/interface/widgets/visual_deck_storage/visual_deck_storage_widget.cpp b/cockatrice/src/interface/widgets/visual_deck_storage/visual_deck_storage_widget.cpp index eba743dac..c33d4fe13 100644 --- a/cockatrice/src/interface/widgets/visual_deck_storage/visual_deck_storage_widget.cpp +++ b/cockatrice/src/interface/widgets/visual_deck_storage/visual_deck_storage_widget.cpp @@ -158,7 +158,7 @@ VisualDeckStorageWidget::VisualDeckStorageWidget(QWidget *parent) : QWidget(pare } } -TutorialSequence VisualDeckStorageWidget::generateTutorialSequence(TutorialSequence vdsSequence) +void VisualDeckStorageWidget::generateTutorialSequence(TutorialSequence &vdsSequence) { vdsSequence.addStep( {this, tr("This is the visual deck storage. It displays all the files and folders located in " @@ -178,8 +178,6 @@ TutorialSequence VisualDeckStorageWidget::generateTutorialSequence(TutorialSeque vdsSequence.addStep({scrollArea, tr("This is where all your local decks will be displayed. You can customize their " "display status using the cogwheel in the top right.\nYou can select a deck by " "double-clicking it.\n\nRight-click a deck for more options.")}); - - return vdsSequence; } void VisualDeckStorageWidget::refreshIfPossible() diff --git a/cockatrice/src/interface/widgets/visual_deck_storage/visual_deck_storage_widget.h b/cockatrice/src/interface/widgets/visual_deck_storage/visual_deck_storage_widget.h index cb790becd..d837323a1 100644 --- a/cockatrice/src/interface/widgets/visual_deck_storage/visual_deck_storage_widget.h +++ b/cockatrice/src/interface/widgets/visual_deck_storage/visual_deck_storage_widget.h @@ -44,7 +44,7 @@ public: void setShareSelectedFiles(const QStringList &paths); void clearShareSelection(); void setShareAvailable(bool available); - TutorialSequence generateTutorialSequence(TutorialSequence vdsSequence); + void generateTutorialSequence(TutorialSequence &vdsSequence); VisualDeckStorageTagFilterWidget *tagFilterWidget; bool deckPreviewSelectionAnimationEnabled;