From d276cd7cce2133bdf1dfb20c29eef202a0b78fad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Thu, 10 Jul 2025 13:26:39 +0200 Subject: [PATCH] Warnings. Took 5 minutes --- .../client/network/parsers/interface_json_deck_parser.h | 2 +- cockatrice/src/dialogs/dlg_load_deck_from_website.cpp | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/cockatrice/src/client/network/parsers/interface_json_deck_parser.h b/cockatrice/src/client/network/parsers/interface_json_deck_parser.h index 73bc20ab1..bb8303cea 100644 --- a/cockatrice/src/client/network/parsers/interface_json_deck_parser.h +++ b/cockatrice/src/client/network/parsers/interface_json_deck_parser.h @@ -67,7 +67,7 @@ public: QString collectorNumber = cardData.value("cn").toString(); QString providerId = cardData.value("scryfall_id").toString(); - list->setBannerCard(QPair(commanderName, providerId)); + list->setBannerCard(QPair(commanderName, providerId)); list->addCard(commanderName, DECK_ZONE_MAIN, -1, setName, collectorNumber, providerId); } } diff --git a/cockatrice/src/dialogs/dlg_load_deck_from_website.cpp b/cockatrice/src/dialogs/dlg_load_deck_from_website.cpp index 66d9ffb57..c4fbc0bf7 100644 --- a/cockatrice/src/dialogs/dlg_load_deck_from_website.cpp +++ b/cockatrice/src/dialogs/dlg_load_deck_from_website.cpp @@ -6,6 +6,7 @@ #include #include #include +#include #include DlgLoadDeckFromWebsite::DlgLoadDeckFromWebsite(QWidget *parent) : QDialog(parent) @@ -58,6 +59,7 @@ void DlgLoadDeckFromWebsite::accept() auto jsonParser = createParserForProvider(info.provider); if (!jsonParser && info.provider != DeckProvider::Deckstats && info.provider != DeckProvider::TappedOut) { qWarning() << "No parser found for provider"; + QMessageBox::warning(this, tr("Load Deck from Website"), tr("No parser available for this deck provider.")); QDialog::reject(); return; } @@ -71,6 +73,7 @@ void DlgLoadDeckFromWebsite::accept() if (reply->error() != QNetworkReply::NoError) { qWarning() << "Network error:" << reply->errorString(); + QMessageBox::warning(this, tr("Load Deck from Website"), tr("Network error: %1").arg(reply->errorString())); reply->deleteLater(); QDialog::reject(); return; @@ -84,6 +87,7 @@ void DlgLoadDeckFromWebsite::accept() QString deckText = QString::fromUtf8(responseData); if (deckText.isEmpty()) { qWarning() << "Response is empty"; + QMessageBox::warning(this, tr("Load Deck from Website"), tr("Received empty deck data.")); QDialog::reject(); return; } @@ -104,6 +108,8 @@ void DlgLoadDeckFromWebsite::accept() QJsonDocument doc = QJsonDocument::fromJson(responseData, &parseError); if (parseError.error != QJsonParseError::NoError) { qWarning() << "JSON parse error:" << parseError.errorString(); + QMessageBox::warning(this, tr("Load Deck from Website"), + tr("Failed to parse deck data: %1").arg(parseError.errorString())); QDialog::reject(); return; } @@ -113,6 +119,8 @@ void DlgLoadDeckFromWebsite::accept() } else { qInfo() << "URL not recognized"; + QMessageBox::warning(this, tr("Load Deck from Website"), + tr("The provided URL is not recognized as a valid deck URL.")); QDialog::reject(); } }