From d30d2752961fcbf3c3d1c7123f33bad5efe7fac4 Mon Sep 17 00:00:00 2001
From: BruebachL <44814898+BruebachL@users.noreply.github.com>
Date: Sat, 31 Oct 2026 18:44:07 +0100
Subject: [PATCH] [Refactor] Move AnnotationDialog and action data types into
 game/ (#7411)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Folds in the closed #7410 (Move AnnotationDialog from game/ logic to
game_graphics/) now that layers 1-2 are closed and this stack bottoms on
master directly:

- Add game_graphics/dialogs/dlg_annotation.{h,cpp} and move the
  QInputDialog subclass there; game/ no longer declares any widget type.
- Add game/player/token_info.h and game/player/move_top_cards_until_options.h.
- Move CardMenuActionType to game/player/card_menu_action_type.h.
- Graphics dialog headers include the new game/ headers instead of
  defining the structs themselves.

No behavior change.

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
---
 cockatrice/CMakeLists.txt                     |  1 +
 .../player/card_menu_action_type.h            |  2 +-
 .../player/move_top_cards_until_options.h     | 19 +++++++++++++++
 cockatrice/src/game/player/player_actions.cpp | 14 -----------
 cockatrice/src/game/player/player_actions.h   |  6 ++---
 cockatrice/src/game/player/player_logic.h     | 12 ----------
 cockatrice/src/game/player/token_info.h       | 23 +++++++++++++++++++
 .../game_graphics/dialogs/dlg_annotation.cpp  | 13 +++++++++++
 .../game_graphics/dialogs/dlg_annotation.h    | 22 ++++++++++++++++++
 .../game_graphics/dialogs/dlg_create_token.h  | 13 ++---------
 .../dialogs/dlg_move_top_cards_until.h        |  9 ++------
 .../game_graphics/player/menu/card_menu.cpp   |  2 +-
 .../game_graphics/player/menu/move_menu.cpp   |  2 +-
 .../game_graphics/player/player_dialogs.cpp   |  1 +
 14 files changed, 89 insertions(+), 50 deletions(-)
 rename cockatrice/src/{game_graphics => game}/player/card_menu_action_type.h (95%)
 create mode 100644 cockatrice/src/game/player/move_top_cards_until_options.h
 create mode 100644 cockatrice/src/game/player/token_info.h
 create mode 100644 cockatrice/src/game_graphics/dialogs/dlg_annotation.cpp
 create mode 100644 cockatrice/src/game_graphics/dialogs/dlg_annotation.h

diff --git a/cockatrice/CMakeLists.txt b/cockatrice/CMakeLists.txt
index 4bd1bde56..8a40e3dc8 100644
--- a/cockatrice/CMakeLists.txt
+++ b/cockatrice/CMakeLists.txt
@@ -89,6 +89,7 @@ set(cockatrice_SOURCES
     src/game_graphics/deckview/deck_view.cpp
     src/game_graphics/deckview/deck_view_container.cpp
     src/game_graphics/deckview/tabbed_deck_view_container.cpp
+    src/game_graphics/dialogs/dlg_annotation.cpp
     src/game_graphics/dialogs/dlg_create_token.cpp
     src/game_graphics/dialogs/dlg_move_top_cards_until.cpp
     src/game_graphics/dialogs/dlg_roll_dice.cpp
diff --git a/cockatrice/src/game_graphics/player/card_menu_action_type.h b/cockatrice/src/game/player/card_menu_action_type.h
similarity index 95%
rename from cockatrice/src/game_graphics/player/card_menu_action_type.h
rename to cockatrice/src/game/player/card_menu_action_type.h
index 4cae22716..e5c4cd84e 100644
--- a/cockatrice/src/game_graphics/player/card_menu_action_type.h
+++ b/cockatrice/src/game/player/card_menu_action_type.h
@@ -1,6 +1,6 @@
 /**
  * @file card_menu_action_type.h
- * @ingroup GameMenusPlayers
+ * @ingroup GameLogicPlayers
  */
 //! \todo Document this file.
 
diff --git a/cockatrice/src/game/player/move_top_cards_until_options.h b/cockatrice/src/game/player/move_top_cards_until_options.h
new file mode 100644
index 000000000..da8028b0f
--- /dev/null
+++ b/cockatrice/src/game/player/move_top_cards_until_options.h
@@ -0,0 +1,19 @@
+/**
+ * @file move_top_cards_until_options.h
+ * @ingroup GameLogicPlayers
+ */
+//! \todo Document this file.
+
+#ifndef COCKATRICE_MOVE_TOP_CARDS_UNTIL_OPTIONS_H
+#define COCKATRICE_MOVE_TOP_CARDS_UNTIL_OPTIONS_H
+
+#include <QStringList>
+
+struct MoveTopCardsUntilOptions
+{
+    QStringList exprs = {};
+    int numberOfHits = 1;
+    bool autoPlay = false;
+};
+
+#endif // COCKATRICE_MOVE_TOP_CARDS_UNTIL_OPTIONS_H
diff --git a/cockatrice/src/game/player/player_actions.cpp b/cockatrice/src/game/player/player_actions.cpp
index 35682ede8..2be646572 100644
--- a/cockatrice/src/game/player/player_actions.cpp
+++ b/cockatrice/src/game/player/player_actions.cpp
@@ -3,8 +3,6 @@
 #include "../../client/settings/cache_settings.h"
 #include "../../game_graphics/board/card_item.h"
 #include "../../game_graphics/dialogs/dlg_create_token.h"
-#include "../../game_graphics/dialogs/dlg_move_top_cards_until.h"
-#include "../../game_graphics/player/card_menu_action_type.h"
 #include "../../game_graphics/zones/table_zone.h"
 #include "../../interface/deck_loader/loaded_deck.h"
 #include "../abstract_game.h"
@@ -31,8 +29,6 @@
 #include <QChar>
 #include <QColor>
 #include <QFlags>
-#include <QInputDialog>
-#include <QKeyEvent>
 #include <QList>
 #include <QMap>
 #include <QMapIterator>
@@ -1495,16 +1491,6 @@ void PlayerActions::actReduceLifeByPower(QList<CardItem *> selectedCards)
     sendGameCommand(prepareGameCommand(cmd));
 }
 
-void AnnotationDialog::keyPressEvent(QKeyEvent *event)
-{
-    if (event->key() == Qt::Key_Return && event->modifiers() & Qt::ControlModifier) {
-        event->accept();
-        accept();
-        return;
-    }
-    QInputDialog::keyPressEvent(event);
-}
-
 void PlayerActions::actRequestSetAnnotationDialog(QList<CardItem *> selectedCards)
 {
     QString oldAnnotation;
diff --git a/cockatrice/src/game/player/player_actions.h b/cockatrice/src/game/player/player_actions.h
index 8fff81635..e0825465c 100644
--- a/cockatrice/src/game/player/player_actions.h
+++ b/cockatrice/src/game/player/player_actions.h
@@ -9,11 +9,11 @@
 #define COCKATRICE_PLAYER_ACTIONS_H
 
 #include "../../game_graphics/board/card_item.h" // IWYU pragma: keep - moc instantiates the metatype for QList<CardItem *>, which Qt 6.4 needs complete
-#include "../../game_graphics/dialogs/dlg_create_token.h"
-#include "../../game_graphics/dialogs/dlg_move_top_cards_until.h"
-#include "../../game_graphics/player/card_menu_action_type.h"
 #include "../board/card_list.h"
+#include "card_menu_action_type.h"
 #include "libcockatrice/card/card_info.h"
+#include "move_top_cards_until_options.h"
+#include "token_info.h"
 
 #include <QObject>
 #include <QString>
diff --git a/cockatrice/src/game/player/player_logic.h b/cockatrice/src/game/player/player_logic.h
index 59da7cc32..aa94dbb53 100644
--- a/cockatrice/src/game/player/player_logic.h
+++ b/cockatrice/src/game/player/player_logic.h
@@ -17,7 +17,6 @@
 #include "libcockatrice/utility/playmat_params.h"
 
 #include <QColor>
-#include <QInputDialog>
 #include <QList>
 #include <QLoggingCategory>
 #include <QMap>
@@ -258,15 +257,4 @@ private:
     bool hasRemotePlaymat = false;
 };
 
-class AnnotationDialog : public QInputDialog
-{
-    Q_OBJECT
-    void keyPressEvent(QKeyEvent *e) override;
-
-public:
-    explicit AnnotationDialog(QWidget *parent = nullptr) : QInputDialog(parent)
-    {
-    }
-};
-
 #endif
diff --git a/cockatrice/src/game/player/token_info.h b/cockatrice/src/game/player/token_info.h
new file mode 100644
index 000000000..99869f33e
--- /dev/null
+++ b/cockatrice/src/game/player/token_info.h
@@ -0,0 +1,23 @@
+/**
+ * @file token_info.h
+ * @ingroup GameLogicPlayers
+ */
+//! \todo Document this file.
+
+#ifndef COCKATRICE_TOKEN_INFO_H
+#define COCKATRICE_TOKEN_INFO_H
+
+#include <QString>
+
+struct TokenInfo
+{
+    QString name;
+    QString color;
+    QString pt;
+    QString annotation;
+    bool destroy = true;
+    bool faceDown = false;
+    QString providerId;
+};
+
+#endif // COCKATRICE_TOKEN_INFO_H
diff --git a/cockatrice/src/game_graphics/dialogs/dlg_annotation.cpp b/cockatrice/src/game_graphics/dialogs/dlg_annotation.cpp
new file mode 100644
index 000000000..c812f9c74
--- /dev/null
+++ b/cockatrice/src/game_graphics/dialogs/dlg_annotation.cpp
@@ -0,0 +1,13 @@
+#include "dlg_annotation.h"
+
+#include <QKeyEvent>
+
+void AnnotationDialog::keyPressEvent(QKeyEvent *event)
+{
+    if (event->key() == Qt::Key_Return && event->modifiers() & Qt::ControlModifier) {
+        event->accept();
+        accept();
+        return;
+    }
+    QInputDialog::keyPressEvent(event);
+}
diff --git a/cockatrice/src/game_graphics/dialogs/dlg_annotation.h b/cockatrice/src/game_graphics/dialogs/dlg_annotation.h
new file mode 100644
index 000000000..686377d3c
--- /dev/null
+++ b/cockatrice/src/game_graphics/dialogs/dlg_annotation.h
@@ -0,0 +1,22 @@
+/**
+ * @file dlg_annotation.h
+ * @ingroup GameDialogs
+ */
+
+#ifndef COCKATRICE_DLG_ANNOTATION_H
+#define COCKATRICE_DLG_ANNOTATION_H
+
+#include <QInputDialog>
+
+class AnnotationDialog : public QInputDialog
+{
+    Q_OBJECT
+    void keyPressEvent(QKeyEvent *e) override;
+
+public:
+    explicit AnnotationDialog(QWidget *parent = nullptr) : QInputDialog(parent)
+    {
+    }
+};
+
+#endif // COCKATRICE_DLG_ANNOTATION_H
diff --git a/cockatrice/src/game_graphics/dialogs/dlg_create_token.h b/cockatrice/src/game_graphics/dialogs/dlg_create_token.h
index a03a1046b..c63c5d7b2 100644
--- a/cockatrice/src/game_graphics/dialogs/dlg_create_token.h
+++ b/cockatrice/src/game_graphics/dialogs/dlg_create_token.h
@@ -7,6 +7,8 @@
 #ifndef DLG_CREATETOKEN_H
 #define DLG_CREATETOKEN_H
 
+#include "../../game/player/token_info.h"
+
 #include <QDialog>
 #include <QList>
 #include <QString>
@@ -25,17 +27,6 @@ class CardInfoPictureWidget;
 class QModelIndex;
 class QWidget;
 
-struct TokenInfo
-{
-    QString name;
-    QString color;
-    QString pt;
-    QString annotation;
-    bool destroy = true;
-    bool faceDown = false;
-    QString providerId;
-};
-
 class DlgCreateToken : public QDialog
 {
     Q_OBJECT
diff --git a/cockatrice/src/game_graphics/dialogs/dlg_move_top_cards_until.h b/cockatrice/src/game_graphics/dialogs/dlg_move_top_cards_until.h
index b9080bcc1..3b0fe19ec 100644
--- a/cockatrice/src/game_graphics/dialogs/dlg_move_top_cards_until.h
+++ b/cockatrice/src/game_graphics/dialogs/dlg_move_top_cards_until.h
@@ -7,6 +7,8 @@
 #ifndef DLG_MOVE_TOP_CARDS_UNTIL_H
 #define DLG_MOVE_TOP_CARDS_UNTIL_H
 
+#include "../../game/player/move_top_cards_until_options.h"
+
 #include <QDialog>
 #include <QList>
 #include <QString>
@@ -21,13 +23,6 @@ class QLabel;
 class QSpinBox;
 class QWidget;
 
-struct MoveTopCardsUntilOptions
-{
-    QStringList exprs = {};
-    int numberOfHits = 1;
-    bool autoPlay = false;
-};
-
 class DlgMoveTopCardsUntil : public QDialog
 {
     Q_OBJECT
diff --git a/cockatrice/src/game_graphics/player/menu/card_menu.cpp b/cockatrice/src/game_graphics/player/menu/card_menu.cpp
index 137ec2ed1..eda71a2be 100644
--- a/cockatrice/src/game_graphics/player/menu/card_menu.cpp
+++ b/cockatrice/src/game_graphics/player/menu/card_menu.cpp
@@ -4,6 +4,7 @@
 #include "../../../client/settings/card_counter_settings.h"
 #include "../../../client/settings/shortcuts_settings.h"
 #include "../../../game/abstract_game.h"
+#include "../../../game/player/card_menu_action_type.h"
 #include "../../../game/player/player_info.h"
 #include "../../../game/player/player_manager.h"
 #include "../../../game/zones/card_zone_logic.h"
@@ -12,7 +13,6 @@
 #include "../../game/player/player_logic.h"
 #include "../../game/zones/view_zone_logic.h"
 #include "../../game_scene.h"
-#include "../card_menu_action_type.h"
 #include "../player_graphics_item.h"
 #include "libcockatrice/card/card_info.h"
 #include "libcockatrice/card/database/card_database_querier.h"
diff --git a/cockatrice/src/game_graphics/player/menu/move_menu.cpp b/cockatrice/src/game_graphics/player/menu/move_menu.cpp
index 2991100ec..80d748e19 100644
--- a/cockatrice/src/game_graphics/player/menu/move_menu.cpp
+++ b/cockatrice/src/game_graphics/player/menu/move_menu.cpp
@@ -2,10 +2,10 @@
 
 #include "../../../client/settings/cache_settings.h"
 #include "../../../client/settings/shortcuts_settings.h"
+#include "../../../game/player/card_menu_action_type.h"
 #include "../../game/player/player_actions.h"
 #include "../../game/player/player_logic.h"
 #include "../../game_scene.h"
-#include "../card_menu_action_type.h"
 #include "../player_graphics_item.h"
 
 #include <QAction>
diff --git a/cockatrice/src/game_graphics/player/player_dialogs.cpp b/cockatrice/src/game_graphics/player/player_dialogs.cpp
index 74f5de601..674b31ffa 100644
--- a/cockatrice/src/game_graphics/player/player_dialogs.cpp
+++ b/cockatrice/src/game_graphics/player/player_dialogs.cpp
@@ -7,6 +7,7 @@
 #include "../../interface/widgets/utility/get_text_with_max.h"
 #include "../board/abstract_counter.h"
 #include "../board/card_item.h"
+#include "../dialogs/dlg_annotation.h"
 #include "../dialogs/dlg_create_token.h"
 #include "../dialogs/dlg_move_top_cards_until.h"
 #include "../dialogs/dlg_roll_dice.h"