jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-07-19 00:42:14 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

pass params by const ref

Browse source
This commit is contained in:
RickyRister 2025-01-01 18:14:00 -08:00
parent 677a5a1a1c
commit e6ebb79b08
2 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
cockatrice/src/settings/settings_manager.cpp
View file

@ -5,7 +5,10 @@ SettingsManager::SettingsManager(const QString &settingPath, QObject *parent)
{ {
} }
void SettingsManager::setValue(QVariant value, QString name, QString group, QString subGroup) void SettingsManager::setValue(const QVariant &value,
const QString &name,
const QString &group,
const QString &subGroup)
{ {
if (!group.isEmpty()) { if (!group.isEmpty()) {
settings.beginGroup(group); settings.beginGroup(group);
@ -26,7 +29,7 @@ void SettingsManager::setValue(QVariant value, QString name, QString group, QStr
} }
} }
void SettingsManager::deleteValue(QString name, QString group, QString subGroup) void SettingsManager::deleteValue(const QString &name, const QString &group, const QString &subGroup)
{ {
if (!group.isEmpty()) { if (!group.isEmpty()) {
settings.beginGroup(group); settings.beginGroup(group);
@ -47,7 +50,7 @@ void SettingsManager::deleteValue(QString name, QString group, QString subGroup)
} }
} }
QVariant SettingsManager::getValue(QString name, QString group, QString subGroup) QVariant SettingsManager::getValue(const QString &name, const QString &group, const QString &subGroup)
{ {
if (!group.isEmpty()) { if (!group.isEmpty()) {
settings.beginGroup(group); settings.beginGroup(group);

6
cockatrice/src/settings/settings_manager.h
View file

@ -11,7 +11,7 @@ class SettingsManager : public QObject
Q_OBJECT Q_OBJECT
public: public:
explicit SettingsManager(const QString &settingPath, QObject *parent = nullptr); explicit SettingsManager(const QString &settingPath, QObject *parent = nullptr);
QVariant getValue(QString name, QString group = "", QString subGroup = ""); QVariant getValue(const QString &name, const QString &group = "", const QString &subGroup = "");
void sync(); void sync();
signals: signals:
@ -20,8 +20,8 @@ public slots:
protected: protected:
QSettings settings; QSettings settings;
void setValue(QVariant value, QString name, QString group = "", QString subGroup = ""); void setValue(const QVariant &value, const QString &name, const QString &group = "", const QString &subGroup = "");
void deleteValue(QString name, QString group = "", QString subGroup = ""); void deleteValue(const QString &name, const QString &group = "", const QString &subGroup = "");
}; };
#endif // SETTINGSMANAGER_H #endif // SETTINGSMANAGER_H