From e7a77ac745a5b2ade554aac6e2942000499a8490 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Fri, 2 Oct 2026 02:40:32 +0200 Subject: [PATCH] [CI] Dump the NSIS compile log when packaging fails CPack reports a failed makensis run as "Problem running NSIS command" plus a path to NSISOutput.log, and that log exists only on the runner, so the actual compile error never reaches the workflow output. An installer script that does not compile is therefore undiagnosable from CI alone, which is exactly how a three-argument FindFirst cost two build cycles here. --- .github/workflows/desktop-build.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/desktop-build.yml b/.github/workflows/desktop-build.yml index bd528f245..206bc930e 100644 --- a/.github/workflows/desktop-build.yml +++ b/.github/workflows/desktop-build.yml @@ -458,6 +458,14 @@ jobs: VCPKG_FEATURE_FLAGS: dependencygraph run: .ci/compile.sh --server --test --vcpkg + # CPack reports a failed makensis run as "Problem running NSIS command" + # plus a path to NSISOutput.log, and that log lives only on the runner, so + # the actual compile error is otherwise nowhere in the workflow output. + # Dump it, or a broken installer script is undiagnosable from CI alone. + - name: "Dump NSIS compile log" + if: failure() && matrix.os == 'Windows' + run: find . -name NSISOutput.log -exec cat {} \; + # Delete used cache to emulate a ccache update. See https://github.com/actions/cache/issues/342 - name: "[macOS] Delete remote compiler cache (ccache)" if: matrix.os == 'macOS' && matrix.use_ccache == 1 && github.ref == 'refs/heads/master' && steps.restore_ccache.outputs.cache-hit