[Server] Parse the rightmost address from forwarded header lists (#7586)
Some checks are pending
CodeQL / Analyze (cpp) (push) Waiting to run
CodeQL / Analyze (actions) (push) Waiting to run
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 44 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 12 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 cover (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 26 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Desktop / Prune caches (push) Waiting to run
Build Docker / Servatrice (arm) (push) Waiting to run
Build Docker / Servatrice (x86) (push) Waiting to run
Build Docker / Publish multi-platform Servatrice image (push) Blocked by required conditions

X-Forwarded-For carries a comma-separated list, and constructing a
QHostAddress from the raw header value returns a null address for it, so a
configured X-Forwarded-For or a multi-hop header never resolved and websocket
clients stayed on the proxy's address.

- Add parseForwardedAddress, returning the rightmost usable entry of a
  forwarded header list
- Use it for the websocket handshake instead of parsing the raw value
- Exempt loopback from per-address auth rate limits so a same-host proxy with a
  customized trusted_sources list cannot lock every user out
- Add forwarded_address_test

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
Zach H 2026-10-18 16:53:55 -04:00 • committed by GitHub
parent 46cdbac830
commit ea6af0048c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 100 additions and 7 deletions

View file

@ -0,0 +1,18 @@
#ifndef FORWARDED_ADDRESS_H
#define FORWARDED_ADDRESS_H
#include <QByteArray>
#include <QHostAddress>
/**
* @brief Parses the real client address out of a forwarded header value (X-Real-IP, X-Forwarded-For).
*
* A comma-separated list resolves to its rightmost usable entry. That entry was appended by the
* proxy closest to the server and is the only one a direct client cannot choose, since the earlier
* entries are passed through verbatim from whatever the client sent.
*
* @return the parsed address, or a null QHostAddress when the value holds none.
*/
QHostAddress parseForwardedAddress(const QByteArray &headerValue);
#endif