Minor cleanup

This commit is contained in:
ZeldaZach 2025-02-11 20:52:35 -05:00
parent 900cbed6bb
commit ea723620ae
No known key found for this signature in database
5 changed files with 16 additions and 17 deletions

View file

@ -9,11 +9,12 @@
#include <QHBoxLayout>
#include <QMouseEvent>
#include <QPainter>
#include <utility>
DeckPreviewTagAdditionWidget::DeckPreviewTagAdditionWidget(QWidget *_parent,
DeckPreviewDeckTagsDisplayWidget *_tagsDisplayWidget,
const QString &_tagName)
: QWidget(_parent), tagsDisplayWidget(_tagsDisplayWidget), tagName_(_tagName)
QString _tagName)
: QWidget(_parent), tagsDisplayWidget(_tagsDisplayWidget), tagName_(std::move(_tagName))
{
// Create layout
auto *layout = new QHBoxLayout(this);
@ -32,7 +33,7 @@ QSize DeckPreviewTagAdditionWidget::sizeHint() const
int width = textWidth + 50; // Add extra padding
int height = fm.height() + 10; // Height based on font size + padding
return QSize(width, height);
return {width, height};
}
static QStringList getAllFiles(const QString &filePath, bool recursive)
@ -59,7 +60,7 @@ void DeckPreviewTagAdditionWidget::mousePressEvent(QMouseEvent *event)
QWidget::mousePressEvent(event);
if (qobject_cast<DeckPreviewWidget *>(tagsDisplayWidget->parentWidget())) {
DeckPreviewWidget *deckPreviewWidget = qobject_cast<DeckPreviewWidget *>(tagsDisplayWidget->parentWidget());
auto *deckPreviewWidget = qobject_cast<DeckPreviewWidget *>(tagsDisplayWidget->parentWidget());
QStringList knownTags = deckPreviewWidget->visualDeckStorageWidget->tagFilterWidget->getAllKnownTags();
QStringList activeTags = tagsDisplayWidget->deckList->getTags();
@ -118,11 +119,11 @@ void DeckPreviewTagAdditionWidget::mousePressEvent(QMouseEvent *event)
currentParent = currentParent->parentWidget();
}
if (qobject_cast<TabDeckEditor *>(currentParent)) {
TabDeckEditor *deckEditor = qobject_cast<TabDeckEditor *>(currentParent);
auto *deckEditor = qobject_cast<TabDeckEditor *>(currentParent);
QStringList knownTags;
QStringList allFiles = getAllFiles(SettingsCache::instance().getDeckPath(), true);
DeckLoader *loader = new DeckLoader();
for (QString file : allFiles) {
auto *loader = new DeckLoader();
for (const QString& file : allFiles) {
loader->loadFromFile(file, DeckLoader::getFormatFromName(file), false);
QStringList tags = loader->getTags();
knownTags.append(tags);

View file

@ -14,8 +14,8 @@ class DeckPreviewTagAdditionWidget : public QWidget
public:
explicit DeckPreviewTagAdditionWidget(QWidget *_parent,
DeckPreviewDeckTagsDisplayWidget *_tagsDisplayWidget,
const QString &_tagName);
QSize sizeHint() const override;
QString _tagName);
[[nodiscard]] QSize sizeHint() const override;
signals:
void tagClicked(); // Emitted when the tag is clicked
@ -28,8 +28,6 @@ protected:
private:
DeckPreviewDeckTagsDisplayWidget *tagsDisplayWidget;
QString tagName_;
QLabel *tagLabel_;
QPushButton *closeButton_;
};
#endif // DECK_PREVIEW_TAG_ADDITION_WIDGET_H

View file

@ -195,10 +195,10 @@ void DeckPreviewWidget::updateBannerCardComboBox()
// Prepare the new items with deduplication
QSet<QPair<QString, QString>> bannerCardSet;
InnerDecklistNode *listRoot = deckLoader->getRoot();
for (int i = 0; i < listRoot->size(); i++) {
InnerDecklistNode *currentZone = dynamic_cast<InnerDecklistNode *>(listRoot->at(i));
for (int j = 0; j < currentZone->size(); j++) {
DecklistCardNode *currentCard = dynamic_cast<DecklistCardNode *>(currentZone->at(j));
for (auto i : *listRoot) {
auto *currentZone = dynamic_cast<InnerDecklistNode *>(i);
for (auto j : *currentZone) {
auto *currentCard = dynamic_cast<DecklistCardNode *>(j);
if (!currentCard)
continue;

View file

@ -13,7 +13,7 @@
#include <QDirIterator>
#include <QMouseEvent>
#include <QVBoxLayout>
#include <qfilesystemwatcher.h>
#include <QFileSystemWatcher>
VisualDeckStorageWidget::VisualDeckStorageWidget(QWidget *parent) : QWidget(parent), folderWidget(nullptr)
{

View file

@ -14,7 +14,7 @@
#include <QCheckBox>
#include <QFileSystemModel>
#include <qfilesystemwatcher.h>
#include <QFileSystemWatcher>
class VisualDeckStorageSearchWidget;
class VisualDeckStorageSortWidget;