mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-21 17:15:09 -07:00
[Server/Client/Protocol] Reporting users + moderation queue functionality (#7091)
Some checks are pending
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 44 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 12 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Docker Image / amd64 & arm64 (push) Waiting to run
Some checks are pending
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 44 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 12 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Docker Image / amd64 & arm64 (push) Waiting to run
* [Server/Client/Protocol] Reporting users + moderation queue functionality Took 6 minutes Took 3 minutes Took 8 seconds Took 11 minutes Took 12 minutes Took 7 minutes Took 15 seconds Took 2 minutes Took 1 minute Took 30 seconds Took 16 seconds * CI Fix Took 6 minutes * CI Fix Took 6 minutes * [Protocol] Add moderation investigation commands Adds the protocol layer for the moderation investigation suite: - Command_GetUserSessions/GetUserAlts/GetModeratorLastLogins/ResetUserPassword/RemoveUserAvatar (1013-1017) - Response extensions 1215-1219 with ServerInfo messages for sessions, alts, and staff logins - last_login on Response_ReportUserInfo and warning_il on Response_WarnList Took 2 minutes * [Utility] Add warning categories parser with infraction levels Parses the server's 'officialwarnings' setting (comma-separated, optional '|IL' suffix) into WarningCategory structs so the client can display the infraction level of each warning category. Includes GTest coverage. * [Server] Add moderation investigation tools Implements the server side of the moderation suite: - getUserSessions/getUserAlts/getModeratorLastLogins/removeUserAvatar DB methods - Handlers for all five new commands with audit records (PASSWORD_RESET, REMOVE_USER_AVATAR); password resets return a generated temporary password - cmdGetWarnList now reports per-category infraction levels from the officialwarnings setting; cmdReportUserInfo reports last_login - Update servatrice.ini.example with the warning taxonomy - Password/avatar mutations report RespNameNotFound when the user does not exist * [Client] Add moderation tab with investigate, password reset, and avatar removal - New Moderation tab: search a user to show account info, alternate accounts, login sessions, and staff last logins; actions to reset the user's password (shows the generated temporary password) and remove the user's avatar - 'Investigate user' entry in the user context menu opens the tab pre-loaded for that user - Warning dialog shows the infraction level of each warning category - Tab wired into TabSupervisor with a moderator-gated menu action, shortcut, and tabs.ini persistence (default closed) * [Server/Client/Protocol] Address PR #7091 review: security, bug, and perf fixes Security: - Promote RESET_USER_PASSWORD to admin-only dispatch (was moderator-accessible) - Reject password reset on users with equal/higher privilege than caller - Notify affected user via Event_NotifyUser::CUSTOM when password is reset - Add server-side category whitelist for reports - Drop reporter name fallback in comment/details authorization (ID-only) - Force password change: new DB column + login enforcement + client disconnect Bugs: - XSS via QTextEdit::append() → insertPlainText() in report tab and utils - allNotified initialized to true even with empty recipients list - Warning combo box: use currentData() instead of baked-in display text - Report resolution now records who resolved (resolved_by column + audit) Performance: - IP-correlation subquery: add 6-month window + LIMIT 200 - getUserSessions: clamp limit to 500 Non-blocking: - Palette-aware colors in report_utils.cpp (dark/light mode) - Report list pagination: offset/limit fields + total_count in response - SessionCommand enum gap comment for reserved values 1201-1203 Schema: 36→37 (force_password_change), 37→38 (resolved_by) Took 12 minutes Took 16 seconds * Fix macOs pedantry Took 5 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
This commit is contained in:
parent
9eafd90a91
commit
ed4eb1cb31
83 changed files with 4768 additions and 43 deletions
191
cockatrice/src/interface/widgets/dialogs/dlg_report_user.cpp
Normal file
191
cockatrice/src/interface/widgets/dialogs/dlg_report_user.cpp
Normal file
|
|
@ -0,0 +1,191 @@
|
|||
#include "dlg_report_user.h"
|
||||
|
||||
#include "abstract_client.h"
|
||||
|
||||
#include <QComboBox>
|
||||
#include <QDialogButtonBox>
|
||||
#include <QFontDatabase>
|
||||
#include <QGridLayout>
|
||||
#include <QGroupBox>
|
||||
#include <QLabel>
|
||||
#include <QLineEdit>
|
||||
#include <QMessageBox>
|
||||
#include <QPushButton>
|
||||
#include <QTextEdit>
|
||||
#include <QVBoxLayout>
|
||||
#include <libcockatrice/protocol/pb/command_report.pb.h>
|
||||
#include <libcockatrice/protocol/pending_command.h>
|
||||
|
||||
DlgReportUser::DlgReportUser(AbstractClient *_client,
|
||||
const QString &_reportedUser,
|
||||
int _gameId,
|
||||
const QString &_autoChatLog,
|
||||
QWidget *parent)
|
||||
: QDialog(parent), client(_client), reportedUser(_reportedUser), gameId(_gameId)
|
||||
{
|
||||
setWindowTitle(tr("Report User"));
|
||||
setMinimumWidth(500);
|
||||
|
||||
auto *infoLabel =
|
||||
new QLabel(tr("Reports are reviewed by moderators. False reports may result in account penalties."));
|
||||
infoLabel->setWordWrap(true);
|
||||
infoLabel->setStyleSheet("color: palette(placeholderText); padding: 5px;");
|
||||
|
||||
auto *reportGroup = new QGroupBox(tr("Report Details"));
|
||||
auto *reportGrid = new QGridLayout(reportGroup);
|
||||
|
||||
reportGrid->addWidget(new QLabel(tr("Reported User:")), 0, 0);
|
||||
reportedUserLabel = new QLabel(reportedUser);
|
||||
reportedUserLabel->setStyleSheet("font-weight: bold;");
|
||||
reportGrid->addWidget(reportedUserLabel, 0, 1);
|
||||
|
||||
reportGrid->addWidget(new QLabel(tr("Game ID:")), 1, 0);
|
||||
if (gameId >= 0) {
|
||||
gameIdLabel = new QLabel(QString::number(gameId));
|
||||
gameIdLabel->setStyleSheet("font-weight: bold;");
|
||||
reportGrid->addWidget(gameIdLabel, 1, 1);
|
||||
} else {
|
||||
gameIdEdit = new QLineEdit;
|
||||
gameIdEdit->setPlaceholderText(tr("(Optional) Enter game ID if available"));
|
||||
gameIdEdit->setToolTip(tr("If the report is related to a specific game, enter its ID."));
|
||||
reportGrid->addWidget(gameIdEdit, 1, 1);
|
||||
gameIdLabel = nullptr;
|
||||
}
|
||||
|
||||
auto *categoryGroup = new QGroupBox(tr("Category"));
|
||||
auto *categoryGrid = new QGridLayout(categoryGroup);
|
||||
|
||||
categoryBox = new QComboBox;
|
||||
categoryBox->addItem(tr("Cheating / Unsporting behavior"), "cheating");
|
||||
categoryBox->setItemData(categoryBox->count() - 1,
|
||||
tr("Using external tools, card marked manipulation, or exploiting game bugs"),
|
||||
Qt::ToolTipRole);
|
||||
categoryBox->addItem(tr("Harassment / Abuse"), "harassment");
|
||||
categoryBox->setItemData(categoryBox->count() - 1, tr("Threatening, bullying, or persistent unwanted contact"),
|
||||
Qt::ToolTipRole);
|
||||
categoryBox->addItem(tr("Hate speech"), "hate_speech");
|
||||
categoryBox->setItemData(categoryBox->count() - 1,
|
||||
tr("Discriminatory language targeting race, gender, religion, etc."), Qt::ToolTipRole);
|
||||
categoryBox->addItem(tr("Spam"), "spam");
|
||||
categoryBox->setItemData(categoryBox->count() - 1, tr("Repeated unwanted messages or advertisements"),
|
||||
Qt::ToolTipRole);
|
||||
categoryBox->addItem(tr("Other"), "other");
|
||||
categoryBox->setItemData(categoryBox->count() - 1, tr("Any behavior not covered by the above categories"),
|
||||
Qt::ToolTipRole);
|
||||
|
||||
categoryGrid->addWidget(new QLabel(tr("Category:")), 0, 0);
|
||||
categoryGrid->addWidget(categoryBox, 0, 1);
|
||||
|
||||
auto *descGroup = new QGroupBox(tr("Description"));
|
||||
auto *descLayout = new QVBoxLayout(descGroup);
|
||||
|
||||
descriptionEdit = new QTextEdit;
|
||||
descriptionEdit->setPlaceholderText(
|
||||
tr("Please describe what happened. Include dates, game details, or any evidence if available."));
|
||||
descriptionEdit->setFixedHeight(120);
|
||||
descLayout->addWidget(descriptionEdit);
|
||||
|
||||
auto *chatGroup = new QGroupBox(tr("Chat Log Context"));
|
||||
auto *chatLayout = new QVBoxLayout(chatGroup);
|
||||
chatLogEdit = new QTextEdit;
|
||||
chatLogEdit->setReadOnly(true);
|
||||
QFont monoFont("monospace");
|
||||
monoFont.setStyleHint(QFont::Monospace);
|
||||
const int systemPointSize = QFontDatabase::systemFont(QFontDatabase::GeneralFont).pointSize();
|
||||
if (systemPointSize > 0) {
|
||||
monoFont.setPointSize(systemPointSize);
|
||||
}
|
||||
chatLogEdit->setFont(monoFont);
|
||||
if (!_autoChatLog.isEmpty()) {
|
||||
chatLogEdit->setPlainText(_autoChatLog);
|
||||
} else {
|
||||
chatLogEdit->setPlaceholderText(tr("No chat context available (not triggered from chat)."));
|
||||
}
|
||||
chatLogEdit->setFixedHeight(100);
|
||||
chatLayout->addWidget(chatLogEdit);
|
||||
|
||||
auto *chatNote = new QLabel(
|
||||
tr("This chat log is captured from your local chat window and may not reflect the full conversation."));
|
||||
chatNote->setWordWrap(true);
|
||||
chatNote->setStyleSheet("color: palette(placeholderText);");
|
||||
chatLayout->addWidget(chatNote);
|
||||
|
||||
buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel);
|
||||
buttonBox->button(QDialogButtonBox::Ok)->setText(tr("Submit Report"));
|
||||
connect(buttonBox, &QDialogButtonBox::accepted, this, &DlgReportUser::actSubmit);
|
||||
connect(buttonBox, &QDialogButtonBox::rejected, this, &QDialog::reject);
|
||||
|
||||
auto *layout = new QVBoxLayout(this);
|
||||
layout->addWidget(infoLabel);
|
||||
layout->addWidget(reportGroup);
|
||||
layout->addWidget(categoryGroup);
|
||||
layout->addWidget(descGroup);
|
||||
layout->addWidget(chatGroup);
|
||||
layout->addWidget(buttonBox);
|
||||
}
|
||||
|
||||
void DlgReportUser::actSubmit()
|
||||
{
|
||||
const QString description = descriptionEdit->toPlainText().trimmed();
|
||||
if (description.isEmpty()) {
|
||||
QMessageBox::warning(this, tr("Missing description"), tr("Please describe what happened before submitting."));
|
||||
return;
|
||||
}
|
||||
|
||||
QMessageBox::StandardButton reply =
|
||||
QMessageBox::question(this, tr("Confirm Report"),
|
||||
tr("Submit report against %1 for %2?").arg(reportedUser, categoryBox->currentText()),
|
||||
QMessageBox::Yes | QMessageBox::No);
|
||||
|
||||
if (reply != QMessageBox::Yes) {
|
||||
return;
|
||||
}
|
||||
|
||||
buttonBox->setEnabled(false);
|
||||
buttonBox->button(QDialogButtonBox::Ok)->setText(tr("Submitting..."));
|
||||
|
||||
Command_Report cmd;
|
||||
cmd.set_reported_user(reportedUser.toStdString());
|
||||
cmd.set_category(categoryBox->currentData().toString().toStdString());
|
||||
cmd.set_description(description.toStdString());
|
||||
|
||||
if (gameId >= 0) {
|
||||
cmd.set_game_id(gameId);
|
||||
} else if (gameIdEdit && !gameIdEdit->text().trimmed().isEmpty()) {
|
||||
bool ok;
|
||||
int manualGameId = gameIdEdit->text().trimmed().toInt(&ok);
|
||||
if (ok && manualGameId > 0) {
|
||||
cmd.set_game_id(manualGameId);
|
||||
}
|
||||
}
|
||||
|
||||
const QString chatLog = chatLogEdit->toPlainText().trimmed();
|
||||
if (!chatLog.isEmpty()) {
|
||||
cmd.set_chat_log(chatLog.toStdString());
|
||||
}
|
||||
|
||||
PendingCommand *pend = client->prepareSessionCommand(cmd);
|
||||
connect(pend, &PendingCommand::finished, this, &DlgReportUser::reportResponse);
|
||||
client->sendCommand(pend);
|
||||
}
|
||||
|
||||
void DlgReportUser::reportResponse(const Response &response)
|
||||
{
|
||||
buttonBox->setEnabled(true);
|
||||
buttonBox->button(QDialogButtonBox::Ok)->setText(tr("Submit Report"));
|
||||
|
||||
if (response.response_code() == Response::RespOk) {
|
||||
QMessageBox::information(this, tr("Report Submitted"),
|
||||
tr("Your report has been submitted and will be reviewed by a moderator. Thank you."));
|
||||
accept();
|
||||
} else if (response.response_code() == Response::RespTooManyRequests) {
|
||||
QMessageBox::warning(this, tr("Submission Failed"),
|
||||
tr("You have reached the daily report limit. Please try again later."));
|
||||
} else if (response.response_code() == Response::RespNameNotFound) {
|
||||
QMessageBox::warning(
|
||||
this, tr("Submission Failed"),
|
||||
tr("The reported user could not be found. Guests (unregistered users) cannot be reported."));
|
||||
} else {
|
||||
QMessageBox::warning(this, tr("Submission Failed"), tr("Failed to submit report. Please try again."));
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue