From ede712dbf5b49f07b7649ded8af5d8868b3dbfac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Fri, 12 Dec 2025 00:05:30 +0100 Subject: [PATCH] Adjust format parsing. Took 8 minutes Took 3 seconds --- .../card/database/parser/cockatrice_xml_4.cpp | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/libcockatrice_card/libcockatrice/card/database/parser/cockatrice_xml_4.cpp b/libcockatrice_card/libcockatrice/card/database/parser/cockatrice_xml_4.cpp index 1b6fd2500..73e262b9c 100644 --- a/libcockatrice_card/libcockatrice/card/database/parser/cockatrice_xml_4.cpp +++ b/libcockatrice_card/libcockatrice/card/database/parser/cockatrice_xml_4.cpp @@ -164,23 +164,13 @@ static QSharedPointer parseFormat(QXmlStreamReader &xml) void CockatriceXml4Parser::loadFormats(QXmlStreamReader &xml) { while (!xml.atEnd()) { - auto token = xml.readNext(); - - // Stop when we hit - if (token == QXmlStreamReader::EndElement && xml.name() == "formats") { + if (xml.readNext() == QXmlStreamReader::EndElement) { break; } - // Only handle start elements - if (token != QXmlStreamReader::StartElement) - continue; - if (xml.name() == "format") { auto rulesPtr = parseFormat(xml); emit addFormat(rulesPtr); - } else { - qCInfo(CockatriceXml4Log) << "Unknown format child" << xml.name() << ", skipping"; - xml.skipCurrentElement(); } } }