jeirmeister/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-07-18 16:32:16 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Review: use hideEvent and call super

Browse source
This commit is contained in:
Basile Clément 2025-03-16 12:09:17 +01:00
parent e57a2116b8
commit f5674a3920
No known key found for this signature in database
3 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
cockatrice/src/client/tabs/tab_game.cpp
View file

@ -1751,10 +1751,8 @@ void TabGame::createMessageDock(bool bReplay)
connect(messageLayoutDock, SIGNAL(topLevelChanged(bool)), this, SLOT(dockTopLevelChanged(bool))); connect(messageLayoutDock, SIGNAL(topLevelChanged(bool)), this, SLOT(dockTopLevelChanged(bool)));
} }
void TabGame::closeEvent(QCloseEvent *event) void TabGame::hideEvent(QHideEvent *event)
{ {
Q_UNUSED(event);
LayoutsSettings &layouts = SettingsCache::instance().layouts(); LayoutsSettings &layouts = SettingsCache::instance().layouts();
if (replay) { if (replay) {
layouts.setReplayPlayAreaState(saveState()); layouts.setReplayPlayAreaState(saveState());
@ -1770,6 +1768,8 @@ void TabGame::closeEvent(QCloseEvent *event)
layouts.setGameMessageLayoutSize(messageLayoutDock->size()); layouts.setGameMessageLayoutSize(messageLayoutDock->size());
layouts.setGamePlayerListSize(playerListDock->size()); layouts.setGamePlayerListSize(playerListDock->size());
} }
Tab::hideEvent(event);
} }
// Method uses to sync docks state with menu items state // Method uses to sync docks state with menu items state

2
cockatrice/src/client/tabs/tab_game.h
View file

@ -208,7 +208,7 @@ private slots:
void actResetLayout(); void actResetLayout();
void freeDocksSize(); void freeDocksSize();
void closeEvent(QCloseEvent *event) override; void hideEvent(QHideEvent *event) override;
bool eventFilter(QObject *o, QEvent *e) override; bool eventFilter(QObject *o, QEvent *e) override;
void dockVisibleTriggered(); void dockVisibleTriggered();
void dockFloatingTriggered(); void dockFloatingTriggered();

3
cockatrice/src/client/tabs/tab_supervisor.cpp
View file

@ -234,6 +234,9 @@ void TabSupervisor::refreshShortcuts()
void TabSupervisor::closeEvent(QCloseEvent *event) void TabSupervisor::closeEvent(QCloseEvent *event)
{ {
// This will accept the event, which we may then override.
QTabWidget::closeEvent(event);
if (getGameCount()) { if (getGameCount()) {
if (QMessageBox::question(this, tr("Are you sure?"), if (QMessageBox::question(this, tr("Are you sure?"),
tr("There are still open games. Are you sure you want to quit?"), tr("There are still open games. Are you sure you want to quit?"),