From f994ffa02d4a5d04c999c571e97a2d10bb39b24d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= <Bruebach.Lukas@bdosecurity.de>
Date: Sat, 1 Mar 2025 11:29:42 +0100
Subject: [PATCH] Fix some weak warnings.

---
 .../tabs/visual_deck_editor/tab_deck_editor_visual.cpp     | 7 ++-----
 .../tabs/visual_deck_editor/tab_deck_editor_visual.h       | 4 ++--
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/cockatrice/src/client/tabs/visual_deck_editor/tab_deck_editor_visual.cpp b/cockatrice/src/client/tabs/visual_deck_editor/tab_deck_editor_visual.cpp
index c364c44be..401964fb0 100644
--- a/cockatrice/src/client/tabs/visual_deck_editor/tab_deck_editor_visual.cpp
+++ b/cockatrice/src/client/tabs/visual_deck_editor/tab_deck_editor_visual.cpp
@@ -2,8 +2,6 @@
 
 #include "../../../deck/deck_list_model.h"
 #include "../../../deck/deck_stats_interface.h"
-#include "../../../dialogs/dlg_load_deck.h"
-#include "../../../dialogs/dlg_load_deck_from_clipboard.h"
 #include "../../../game/cards/card_database_model.h"
 #include "../../../game/filters/filter_builder.h"
 #include "../../../server/pending_command.h"
@@ -27,7 +25,6 @@
 #include <QHeaderView>
 #include <QLineEdit>
 #include <QMenu>
-#include <QMessageBox>
 #include <QPrintPreviewDialog>
 #include <QProcessEnvironment>
 #include <QSplitter>
@@ -148,13 +145,13 @@ QString TabDeckEditorVisual::getTabText() const
     return result;
 }
 
-void TabDeckEditorVisual::changeModelIndexAndCardInfo(CardInfoPtr activeCard)
+void TabDeckEditorVisual::changeModelIndexAndCardInfo(const CardInfoPtr &activeCard)
 {
     updateCard(activeCard);
     changeModelIndexToCard(activeCard);
 }
 
-void TabDeckEditorVisual::changeModelIndexToCard(CardInfoPtr activeCard)
+void TabDeckEditorVisual::changeModelIndexToCard(const CardInfoPtr &activeCard)
 {
     QString cardName = activeCard->getName();
     QModelIndex index = deckDockWidget->deckModel->findCard(cardName, DECK_ZONE_MAIN);
diff --git a/cockatrice/src/client/tabs/visual_deck_editor/tab_deck_editor_visual.h b/cockatrice/src/client/tabs/visual_deck_editor/tab_deck_editor_visual.h
index 7d5c8da38..eac30a23e 100644
--- a/cockatrice/src/client/tabs/visual_deck_editor/tab_deck_editor_visual.h
+++ b/cockatrice/src/client/tabs/visual_deck_editor/tab_deck_editor_visual.h
@@ -34,8 +34,8 @@ public:
     explicit TabDeckEditorVisual(TabSupervisor *_tabSupervisor);
     void retranslateUi() override;
     QString getTabText() const override;
-    void changeModelIndexAndCardInfo(CardInfoPtr activeCard);
-    void changeModelIndexToCard(CardInfoPtr activeCard);
+    void changeModelIndexAndCardInfo(const CardInfoPtr &activeCard);
+    void changeModelIndexToCard(const CardInfoPtr &activeCard);
     void createDeckAnalyticsDock();
     void createMenus() override;
     void createSearchAndDatabaseFrame();