[VDS] Try to fix memory leak by properly parenting widgets

This commit is contained in:
RickyRister 2026-01-06 00:44:58 -08:00
parent b86853b65c
commit fdb4519f30
3 changed files with 5 additions and 2 deletions

View file

@ -47,7 +47,7 @@ CardInfoPictureWidget::CardInfoPictureWidget(QWidget *parent, const bool _hoverT
originalPos = this->pos();
// Create the animation
animation = new QPropertyAnimation(this, "pos");
animation = new QPropertyAnimation(this, "pos", this);
animation->setDuration(200); // 200ms animation duration
animation->setEasingCurve(QEasingCurve::OutQuad);

View file

@ -92,7 +92,7 @@ void DeckPreviewWidget::initializeUi(const bool deckLoadSuccess)
bannerCardComboBox->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Minimum);
bannerCardComboBox->setObjectName("bannerCardComboBox");
bannerCardComboBox->setCurrentText(deckLoader->getDeck().deckList.getBannerCard().name);
bannerCardComboBox->installEventFilter(new NoScrollFilter());
bannerCardComboBox->installEventFilter(new NoScrollFilter(bannerCardComboBox));
connect(bannerCardComboBox, QOverload<int>::of(&QComboBox::currentIndexChanged), this,
&DeckPreviewWidget::setBannerCard);

View file

@ -82,6 +82,9 @@ private slots:
class NoScrollFilter : public QObject
{
Q_OBJECT
public:
explicit NoScrollFilter(QObject *parent = nullptr) : QObject(parent) {};
protected:
bool eventFilter(QObject *obj, QEvent *event) override
{