From fe5f75a2913884c1c866ce7704444c3ebd2a2c9a Mon Sep 17 00:00:00 2001 From: RickyRister Date: Sun, 26 Jan 2025 01:52:14 -0800 Subject: [PATCH] clean up submenu parenting --- .../ui/widgets/cards/card_info_picture_widget.cpp | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.cpp b/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.cpp index c744b4923..e770182d0 100644 --- a/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.cpp +++ b/cockatrice/src/client/ui/widgets/cards/card_info_picture_widget.cpp @@ -299,22 +299,19 @@ QMenu *CardInfoPictureWidget::createAddToOpenDeckMenu() QList deckEditorTabs = mainWindow->getTabSupervisor()->getDeckEditorTabs(); for (auto &deckEditorTab : deckEditorTabs) { - auto *addCardMenu = new QMenu(deckEditorTab->getTabText()); - QAction *addCard = new QAction(this); - addCard->setText(tr("Mainboard")); + auto *addCardMenu = addToOpenDeckMenu->addMenu(deckEditorTab->getTabText()); + + QAction *addCard = addCardMenu->addAction(tr("Mainboard")); connect(addCard, &QAction::triggered, this, [this, deckEditorTab] { deckEditorTab->updateCardInfo(info); deckEditorTab->addCardHelper(info, DECK_ZONE_MAIN); }); - QAction *addCardSideboard = new QAction(this); - addCardSideboard->setText(tr("Sideboard")); + + QAction *addCardSideboard = addCardMenu->addAction(tr("Sideboard")); connect(addCardSideboard, &QAction::triggered, this, [this, deckEditorTab] { deckEditorTab->updateCardInfo(info); deckEditorTab->addCardHelper(info, DECK_ZONE_SIDE); }); - addCardMenu->addAction(addCard); - addCardMenu->addAction(addCardSideboard); - addToOpenDeckMenu->addMenu(addCardMenu); } return addToOpenDeckMenu;