From fe953bb3ebdfbc2d59dfe6c5a1064dec7d215ea5 Mon Sep 17 00:00:00 2001 From: RickyRister Date: Sat, 21 Jun 2025 23:04:40 -0700 Subject: [PATCH] delete reply first if able --- .../client/ui/picture_loader/picture_loader_worker_work.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cockatrice/src/client/ui/picture_loader/picture_loader_worker_work.cpp b/cockatrice/src/client/ui/picture_loader/picture_loader_worker_work.cpp index c68680a1e..d2bc65d23 100644 --- a/cockatrice/src/client/ui/picture_loader/picture_loader_worker_work.cpp +++ b/cockatrice/src/client/ui/picture_loader/picture_loader_worker_work.cpp @@ -115,8 +115,8 @@ void PictureLoaderWorkerWork::picDownloadFinished(QNetworkReply *reply) << "PictureLoader: [card: " << cardToDownload.getCard()->getName() << " set: " << cardToDownload.getSetName() << "]: following " << (isFromCache ? "cached redirect" : "redirect") << " to " << redirectUrl.toDisplayString(); - emit requestImageDownload(redirectUrl, this); reply->deleteLater(); + emit requestImageDownload(redirectUrl, this); return; } @@ -129,8 +129,8 @@ void PictureLoaderWorkerWork::picDownloadFinished(QNetworkReply *reply) << " set: " << cardToDownload.getSetName() << "]: Picture found, but blacklisted, will consider it as not found"; - picDownloadFailed(); reply->deleteLater(); + picDownloadFailed(); return; }