From 21c54a029bc1297275a531e196606fa420fb741b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= <Bruebach.Lukas@bdosecurity.de>
Date: Tue, 1 Sep 2026 16:15:29 +0200
Subject: [PATCH 1/3] [Build] Add precompiled headers for Qt-backed executables

Reparsing QtCore/QtGui/QtWidgets/QtNetwork in ~460 client translation
units is the dominant compilation cost. Precompile the two common layers:
- qtcore_pch.h (Qt Core only; safe even for headless Servatrice)
- qtwidgets_pch.h (adds Gui/Widgets/Network; used by Cockatrice and Oracle)

target_precompile_headers() requires CMake 3.16, now the project minimum.
Estimated 30-50% faster client rebuilds.
---
 cmake/pch/qtcore_pch.h    | 24 ++++++++++++++++++++++++
 cmake/pch/qtwidgets_pch.h | 31 +++++++++++++++++++++++++++++++
 cockatrice/CMakeLists.txt |  2 ++
 oracle/CMakeLists.txt     |  2 ++
 servatrice/CMakeLists.txt |  2 ++
 5 files changed, 61 insertions(+)
 create mode 100644 cmake/pch/qtcore_pch.h
 create mode 100644 cmake/pch/qtwidgets_pch.h

diff --git a/cmake/pch/qtcore_pch.h b/cmake/pch/qtcore_pch.h
new file mode 100644
index 000000000..9954bc8b9
--- /dev/null
+++ b/cmake/pch/qtcore_pch.h
@@ -0,0 +1,24 @@
+/** @file qtcore_pch.h
+ *  @brief Precompiled header for all Qt targets (Qt Core only).
+ *
+ * Safe for every target that links Qt Core, including the headless
+ * Servatrice binary. Keep this header free of any widget/gui types.
+ */
+
+#include <QBasicTimer>
+#include <QByteArray>
+#include <QDateTime>
+#include <QDebug>
+#include <QFile>
+#include <QHash>
+#include <QList>
+#include <QLoggingCategory>
+#include <QMap>
+#include <QMetaObject>
+#include <QObject>
+#include <QRandomGenerator>
+#include <QSharedPointer>
+#include <QString>
+#include <QStringList>
+#include <QTimer>
+#include <QVariant>
\ No newline at end of file
diff --git a/cmake/pch/qtwidgets_pch.h b/cmake/pch/qtwidgets_pch.h
new file mode 100644
index 000000000..e39d28de4
--- /dev/null
+++ b/cmake/pch/qtwidgets_pch.h
@@ -0,0 +1,31 @@
+/** @file qtwidgets_pch.h
+ *  @brief Precompiled header for GUI targets (Cockatrice client, Oracle).
+ *
+ * Includes the Qt Core precompiled header plus the heavy Gui, Widgets and
+ * Network layers that virtually every client translation unit re-parses.
+ * Do not use on Servatrice (headless, QT_DONT_USE_QTGUI).
+ */
+
+#include "qtcore_pch.h"
+
+#include <QAction>
+#include <QApplication>
+#include <QFrame>
+#include <QGraphicsItem>
+#include <QGraphicsScene>
+#include <QGraphicsView>
+#include <QImage>
+#include <QLabel>
+#include <QLayout>
+#include <QMainWindow>
+#include <QMenu>
+#include <QPainter>
+#include <QPushButton>
+#include <QScrollArea>
+#include <QTabWidget>
+#include <QToolBar>
+#include <QTreeWidget>
+#include <QWidget>
+
+#include <QNetworkAccessManager>
+#include <QNetworkReply>
\ No newline at end of file
diff --git a/cockatrice/CMakeLists.txt b/cockatrice/CMakeLists.txt
index 2f629fed2..44bfa90e0 100644
--- a/cockatrice/CMakeLists.txt
+++ b/cockatrice/CMakeLists.txt
@@ -516,6 +516,8 @@ qt6_add_executable(
   MANUAL_FINALIZATION
 )
 
+target_precompile_headers(cockatrice PRIVATE "${CMAKE_SOURCE_DIR}/cmake/pch/qtwidgets_pch.h")
+
 qt6_add_shaders(
   cockatrice
   "onboarding_shaders"
diff --git a/oracle/CMakeLists.txt b/oracle/CMakeLists.txt
index 0736db7f5..ec09f1dee 100644
--- a/oracle/CMakeLists.txt
+++ b/oracle/CMakeLists.txt
@@ -113,6 +113,8 @@ qt6_add_executable(
   MANUAL_FINALIZATION
 )
 
+target_precompile_headers(oracle PRIVATE "${CMAKE_SOURCE_DIR}/cmake/pch/qtwidgets_pch.h")
+
 # ------------------------
 # Link libraries
 # ------------------------
diff --git a/servatrice/CMakeLists.txt b/servatrice/CMakeLists.txt
index aba63800c..5d8089ad1 100644
--- a/servatrice/CMakeLists.txt
+++ b/servatrice/CMakeLists.txt
@@ -95,6 +95,8 @@ set(DESKTOPDIR
 # Build servatrice binary and link it
 add_executable(servatrice MACOSX_BUNDLE ${servatrice_MOC_SRCS} ${servatrice_RESOURCES_RCC} ${servatrice_SOURCES})
 
+target_precompile_headers(servatrice PRIVATE "${CMAKE_SOURCE_DIR}/cmake/pch/qtcore_pch.h")
+
 if(CMAKE_HOST_SYSTEM MATCHES "FreeBSD")
   target_link_libraries(
     servatrice libcockatrice_deck_list libcockatrice_network_server_remote Threads::Threads ${SERVATRICE_QT_MODULES}

From fe07d43b91829a1c7e8e7386d3e6a0f90a2bfafc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= <Bruebach.Lukas@bdosecurity.de>
Date: Tue, 1 Sep 2026 16:47:22 +0200
Subject: [PATCH 2/3] [Build] Format qtwidgets precompiled header

clang-format include regrouping and a missing trailing newline.
---
 cmake/pch/qtwidgets_pch.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/cmake/pch/qtwidgets_pch.h b/cmake/pch/qtwidgets_pch.h
index e39d28de4..2c63f450e 100644
--- a/cmake/pch/qtwidgets_pch.h
+++ b/cmake/pch/qtwidgets_pch.h
@@ -19,6 +19,8 @@
 #include <QLayout>
 #include <QMainWindow>
 #include <QMenu>
+#include <QNetworkAccessManager>
+#include <QNetworkReply>
 #include <QPainter>
 #include <QPushButton>
 #include <QScrollArea>
@@ -26,6 +28,3 @@
 #include <QToolBar>
 #include <QTreeWidget>
 #include <QWidget>
-
-#include <QNetworkAccessManager>
-#include <QNetworkReply>
\ No newline at end of file

From 39962d3b6aaad3d7c63cd10867704485b0307387 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= <Bruebach.Lukas@bdosecurity.de>
Date: Wed, 2 Sep 2026 15:09:53 +0200
Subject: [PATCH 3/3] [Build] Add PCH-aware ccache sloppiness config; format
 cmake/pch headers

---
 .ci/compile.sh         | 3 +++
 CMakeLists.txt         | 4 ++++
 cmake/pch/qtcore_pch.h | 2 +-
 format.sh              | 1 +
 4 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/.ci/compile.sh b/.ci/compile.sh
index 8a16d3243..bd8c900c8 100755
--- a/.ci/compile.sh
+++ b/.ci/compile.sh
@@ -149,6 +149,9 @@ if [[ $MAKE_TEST ]]; then
 fi
 if [[ $USE_CCACHE ]]; then
   flags+=("-DUSE_CCACHE=1")
+  # PCH-aware caching is required or ccache refuses to cache any TU that
+  # consumes a precompiled header, silently recompiling everything on every run.
+  ccache --set-config sloppiness=pch_defines,time_macros
   if [[ $CCACHE_SIZE ]]; then
     # note, this setting persists after running the script
     ccache --max-size "$CCACHE_SIZE"
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5ef0f5573..239329a95 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -44,6 +44,10 @@ if(USE_CCACHE)
   if(CCACHE_PROGRAM)
     # Support Unix Makefiles and Ninja
     set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE "${CCACHE_PROGRAM}")
+    # PCH-aware caching, matching .ci/compile.sh: without this ccache refuses
+    # to cache any TU that consumes a precompiled header, so every PCH-backed
+    # target recompiles from scratch on each build.
+    execute_process(COMMAND ${CCACHE_PROGRAM} --set-config sloppiness=pch_defines,time_macros)
     message(STATUS "Found CCache ${CCACHE_PROGRAM}")
   endif()
 endif()
diff --git a/cmake/pch/qtcore_pch.h b/cmake/pch/qtcore_pch.h
index 9954bc8b9..cc3dd12ee 100644
--- a/cmake/pch/qtcore_pch.h
+++ b/cmake/pch/qtcore_pch.h
@@ -21,4 +21,4 @@
 #include <QString>
 #include <QStringList>
 #include <QTimer>
-#include <QVariant>
\ No newline at end of file
+#include <QVariant>
diff --git a/format.sh b/format.sh
index 3fa435be1..4a91aee47 100755
--- a/format.sh
+++ b/format.sh
@@ -18,6 +18,7 @@ include=("cockatrice/src" \
 libcockatrice_* \
 "oracle/src" \
 "servatrice/src" \
+"cmake/pch" \
 "tests")
 exclude=("libcockatrice_rng/libcockatrice/rng/sfmt/" \
 "libcockatrice_utility/libcockatrice/utility/peglib.h" \