[Fonts] Fix font preview leaks and reuse default-font loader

- Set the sizes the stylesheets carried with setPixelSize() rather than
  setPointSize(): home buttons (34), banner (24), home group box (20),
  the placeholder labels (14), the analytics drag handle (10), the EDHREC
  navigation buttons (24), the user info popup (11/14/11/10/11) and the
  game overlays (14/16/12). Points at 96 DPI were ~33% larger.
- The drag/total counters and tally columns keep the monospace family the
  stylesheets set, so digit widths stop changing as counts tick and
  white-space: pre stays aligned.
- applyDeckListFont() drops the cached tally rows before re-measuring, so
  previewing a larger DeckList font no longer leaves the tally clipped.
- Tally labels and the constructor/fontsChanged pairs in the shared-deck
  preview, quick setup, analytics panel, home box and public decks build
  their font once in a local lambda instead of twice.

cockatrice/src/game_graphics/game_view.cpp

@@ -117,11 +117,10 @@ GameView::GameView(GameScene *scene, QWidget *parent) : QGraphicsView(scene, par
     tallyLayout->setSpacing(2);
     tallyContainer->hide();
 
-    applyDeckListFont();
+    applyDeckOverlayFonts();
-    connect(themeManager, &ThemeManager::fontsChanged, this, &GameView::applyDeckListFont);
 }
 
-void GameView::applyDeckListFont()
+void GameView::applyDeckOverlayFonts()
 {
     dragCountLabel->setFont(deckOverlayFont(14, true));
     totalCountLabel->setFont(deckOverlayFont(16, true));

cockatrice/src/game_graphics/game_view.h

@@ -50,7 +50,7 @@ private slots:
     void refreshShortcuts();
     void updateTotalSelectionCount(const QSize &viewSize = QSize());
     void setFocusDisabled(bool disabled);
-    void applyDeckListFont();
+    void applyDeckOverlayFonts();
 public slots:
     void updateSceneRect(const QRectF &rect);
 

cockatrice/src/interface/palette_editor/font_grid_widget.cpp

@@ -79,11 +79,12 @@ void FontGridWidget::loadFonts(const FontConfig &cfg)
         auto role = static_cast<AppFont::Role>(fontEnum.value(i));
         const FontRow &row = fontRows[role];
 
-        // Roles absent from the file resolve to the startup font, not to the
+        // Roles absent from the file resolve the same way the runtime does: an unset
-        // live preview: appFont() would return the previewed config, so Reset
+        // role falls back to the config's InterfaceDefault, and only then to the
-        // and a first load would both show the edited font instead of the
+        // startup font. appFont() would return the live preview instead, so Reset and
-        // theme's real default.
+        // a first load must not measure against it.
-        const QFont font = cfg.fonts.value(role, themeManager->defaultAppFont(role));
+        const QFont fallback = cfg.fonts.value(AppFont::InterfaceDefault, themeManager->defaultAppFont(role));
+        const QFont font = cfg.fonts.value(role, fallback);
         row.familyCombo->setCurrentFont(font);
 
         int size = font.pointSize();

cockatrice/src/interface/palette_editor/palette_editor_dialog.cpp

@@ -285,9 +285,7 @@ void PaletteEditorDialog::loadSchemes()
 void PaletteEditorDialog::loadFonts()
 {
     savedFontConfig = ThemeManager::loadDefaultFontConfig(themeDirPath, themeName);
-    fontGrid->blockSignals(true);
     fontGrid->loadFonts(savedFontConfig);
-    fontGrid->blockSignals(false);
     fontsDirty = false;
 }
 
@@ -394,7 +392,6 @@ void PaletteEditorDialog::onSave()
 
 void PaletteEditorDialog::onReset()
 {
-    const bool hadFontPreview = fontsDirty;
     workingConfig[loadedScheme] = savedConfig[loadedScheme];
     paletteGrid->loadPalette(savedConfig[loadedScheme]);
     // Restore the live theme before re-reading the grid: loadFonts resolves
@@ -403,9 +400,6 @@ void PaletteEditorDialog::onReset()
     themeManager->reloadCurrentTheme();
     fontGrid->loadFonts(savedFontConfig);
     fontsDirty = false;
-    if (hadFontPreview) {
-        themeManager->previewFonts(savedFontConfig);
-    }
     seedAccentFromScheme(loadedScheme);
 }
 

cockatrice/src/interface/palette_editor/palette_editor_dialog.h

@@ -19,7 +19,6 @@ class FontGridWidget;
 class QuickSetupPanel;
 class QFrame;
 class QWidget;
-class QCloseEvent;
 
 class PaletteEditorDialog : public QDialog
 {

cockatrice/src/interface/theme_manager.cpp

@@ -657,17 +657,9 @@ QFont ThemeManager::appFont(AppFont::Role role) const
     }
 
     // Role fallbacks preserve the pre-theme defaults when no fonts.toml is
-    // present: chat logs rendered monospace (matching the report dialogs),
+    // present: an unset role resolves to the application font, so the result is
-    // card text from a serif basis, everything else from the app font.
+    // identical to before. The report dialogs that used to hardcode monospace
-    if (role == AppFont::ChatLog) {
+    // ask for it explicitly (report_utils::reportLogFont), and the counter
-        // ChatView never set a font before the theme role existed, so an unset
-        // ChatLog must keep resolving to the application font. The report
-        // dialogs that used to hardcode monospace ask for it explicitly
-        // (report_utils::reportLogFont) instead of through this fallback.
-        return qApp->font();
-    }
-    // No per-role scaling: an unset role resolves to the application font, so
-    // with no fonts.toml present the result is identical to before. The counter
     // painters that used to hardcode Serif ask for it through cardTextFont().
     return qApp->font();
 }

cockatrice/src/interface/theme_manager.h

@@ -150,9 +150,8 @@ public:
     // when present, otherwise a palette-accent-derived fallback.
     QColor appColor(AppColor::Role role) const;
     /** @brief Resolves an application font role: the theme's stored [Fonts]
-     *         value when present, otherwise a per-role fallback (monospace for
+     *         value when present, otherwise a per-role fallback (serif basis
-     *         ChatLog, serif basis for CardText, the application font for the
+     *         for CardText, the application font for the remaining roles). */
-     *         remaining roles). */
     QFont appFont(AppFont::Role role) const;
     /** @brief Whether the active theme defines this role in fonts.toml. */
     bool hasAppFont(AppFont::Role role) const;