[Fonts] Keep the DeckList fallback on the application font

DeckList is read by the deck editor headers, the filter tree and the deck
view too, not only by the two surfaces that hardcoded Serif. Resolving the
unset role to Serif in appFont() made every user without a fonts.toml see
Serif outside the deck list.

- appFont(DeckList) falls back to the application font again.
- ThemeManager::deckListFont() resolves the role and keeps the Serif
  fallback for the two historical sites: the deck view zone headers and
  the printed deck list.
- DeckView no longer repaints its viewport on fontsChanged; touching the
  scene items already schedules the repaint in every attached view.

cockatrice/src/game_graphics/game_view.cpp

@@ -117,10 +117,11 @@ GameView::GameView(GameScene *scene, QWidget *parent) : QGraphicsView(scene, par
     tallyLayout->setSpacing(2);
     tallyContainer->hide();
 
-    applyDeckOverlayFonts();
+    applyDeckListFont();
+    connect(themeManager, &ThemeManager::fontsChanged, this, &GameView::applyDeckListFont);
 }
 
-void GameView::applyDeckOverlayFonts()
+void GameView::applyDeckListFont()
 {
     dragCountLabel->setFont(deckOverlayFont(14, true));
     totalCountLabel->setFont(deckOverlayFont(16, true));

cockatrice/src/game_graphics/game_view.h

@@ -50,7 +50,7 @@ private slots:
     void refreshShortcuts();
     void updateTotalSelectionCount(const QSize &viewSize = QSize());
     void setFocusDisabled(bool disabled);
-    void applyDeckOverlayFonts();
+    void applyDeckListFont();
 public slots:
     void updateSceneRect(const QRectF &rect);
 

cockatrice/src/interface/palette_editor/font_grid_widget.cpp

@@ -79,12 +79,11 @@ void FontGridWidget::loadFonts(const FontConfig &cfg)
         auto role = static_cast<AppFont::Role>(fontEnum.value(i));
         const FontRow &row = fontRows[role];
 
-        // Roles absent from the file resolve the same way the runtime does: an unset
+        // Roles absent from the file resolve to the startup font, not to the
-        // role falls back to the config's InterfaceDefault, and only then to the
+        // live preview: appFont() would return the previewed config, so Reset
-        // startup font. appFont() would return the live preview instead, so Reset and
+        // and a first load would both show the edited font instead of the
-        // a first load must not measure against it.
+        // theme's real default.
-        const QFont fallback = cfg.fonts.value(AppFont::InterfaceDefault, themeManager->defaultAppFont(role));
+        const QFont font = cfg.fonts.value(role, themeManager->defaultAppFont(role));
-        const QFont font = cfg.fonts.value(role, fallback);
         row.familyCombo->setCurrentFont(font);
 
         int size = font.pointSize();

cockatrice/src/interface/palette_editor/palette_editor_dialog.cpp

@@ -285,7 +285,9 @@ void PaletteEditorDialog::loadSchemes()
 void PaletteEditorDialog::loadFonts()
 {
     savedFontConfig = ThemeManager::loadDefaultFontConfig(themeDirPath, themeName);
+    fontGrid->blockSignals(true);
     fontGrid->loadFonts(savedFontConfig);
+    fontGrid->blockSignals(false);
     fontsDirty = false;
 }
 
@@ -392,6 +394,7 @@ void PaletteEditorDialog::onSave()
 
 void PaletteEditorDialog::onReset()
 {
+    const bool hadFontPreview = fontsDirty;
     workingConfig[loadedScheme] = savedConfig[loadedScheme];
     paletteGrid->loadPalette(savedConfig[loadedScheme]);
     // Restore the live theme before re-reading the grid: loadFonts resolves
@@ -400,6 +403,9 @@ void PaletteEditorDialog::onReset()
     themeManager->reloadCurrentTheme();
     fontGrid->loadFonts(savedFontConfig);
     fontsDirty = false;
+    if (hadFontPreview) {
+        themeManager->previewFonts(savedFontConfig);
+    }
     seedAccentFromScheme(loadedScheme);
 }
 

cockatrice/src/interface/palette_editor/palette_editor_dialog.h

@@ -19,6 +19,7 @@ class FontGridWidget;
 class QuickSetupPanel;
 class QFrame;
 class QWidget;
+class QCloseEvent;
 
 class PaletteEditorDialog : public QDialog
 {

cockatrice/src/interface/theme_manager.cpp

@@ -657,12 +657,23 @@ QFont ThemeManager::appFont(AppFont::Role role) const
     }
 
     // Role fallbacks preserve the pre-theme defaults when no fonts.toml is
-    // present: an unset role resolves to the application font. Surfaces that
+    // present: chat logs rendered monospace (matching the report dialogs) and
-    // hardcoded a different family ask for it explicitly: counter painters
+    // every other role resolves to the app font. The surfaces that hardcoded a
-    // through cardTextFont(), the deck view headers and printed deck list
+    // different family ask for it explicitly: counter painters through
-    // through deckListFont(), the report dialogs through
+    // cardTextFont(), the deck view headers and printed deck list through
-    // report_utils::reportLogFont(). Only the family basis is fixed there;
+    // deckListFont(). Only the family basis is fixed there; sizes stay
-    // sizes stay caller-side.
+    // caller-side.
+    if (role == AppFont::ChatLog) {
+        // ChatView never set a font before the theme role existed, so an unset
+        // ChatLog must keep resolving to the application font. The report
+        // dialogs that used to hardcode monospace ask for it explicitly
+        // (report_utils::reportLogFont) instead of through this fallback.
+        return qApp->font();
+    }
+    // No per-role scaling: an unset role resolves to the application font, so
+    // with no fonts.toml present the result is identical to before. The counter
+    // painters that used to hardcode Serif ask for it through cardTextFont(),
+    // and the two deck-list sites that did through deckListFont().
     return qApp->font();
 }