format

cockatrice/CMakeLists.txt

@@ -692,7 +692,7 @@ if(WIN32) # Windows (including 64bit)
   # Install the runtime of every linked module explicitly. An unused DLL costs a
   # few hundred kilobytes; a missing one is what stops the client starting after
   # an update, and it stays invisible until then.
-  foreach(_qt_module IN LISTS COCKATRICE_QT_MODULES)
+  foreach(_qt_module IN LISTS QT_MODULES_COCKATRICE)
     get_target_property(_qt_module_type ${_qt_module} TYPE)
     if(_qt_module_type STREQUAL "SHARED_LIBRARY")
       install(FILES "$<TARGET_FILE:${_qt_module}>" DESTINATION ./)

cockatrice/src/game_graphics/board/abstract_card_drag_item.cpp

@@ -14,7 +14,7 @@ const QColor GHOST_MASK = QColor(255, 255, 255, 50);
 AbstractCardDragItem::AbstractCardDragItem(AbstractCardItem *_item,
                                            const QPointF &_hotSpot,
                                            AbstractCardDragItem *parentDrag)
-    : QGraphicsItem(), item(_item), hotSpot(_hotSpot)
+    : QGraphicsObject(), item(_item), hotSpot(_hotSpot)
 {
     if (parentDrag) {
         parentDrag->addChildDrag(this);

cockatrice/src/game_graphics/board/abstract_card_drag_item.h

@@ -13,7 +13,7 @@ class QGraphicsScene;
 class CardZone;
 class CardInfo;
 
-class AbstractCardDragItem : public QObject, public QGraphicsItem
+class AbstractCardDragItem : public QGraphicsObject
 {
     Q_OBJECT
 protected:

cockatrice/src/game_graphics/board/abstract_counter.cpp

@@ -23,7 +23,7 @@ AbstractCounter::AbstractCounter(CounterState *state,
                                  bool _shownInCounterArea,
                                  bool _useNameForShortcut,
                                  QGraphicsItem *parent)
-    : QGraphicsItem(parent), player(_player), id(state->getId()), name(state->getName()), value(state->getValue()),
+    : QGraphicsObject(parent), player(_player), id(state->getId()), name(state->getName()), value(state->getValue()),
       color(state->getColor()), radius(state->getRadius()), useNameForShortcut(_useNameForShortcut),
       shownInCounterArea(_shownInCounterArea)
 {

cockatrice/src/game_graphics/board/abstract_counter.h

@@ -20,7 +20,7 @@ class QKeyEvent;
 class QMenu;
 class QString;
 
-class AbstractCounter : public QObject, public QGraphicsItem, public AbstractPlayerComponent
+class AbstractCounter : public QGraphicsObject, public AbstractPlayerComponent
 {
     Q_OBJECT
 

cockatrice/src/game_graphics/board/arrow_item.cpp

@@ -42,7 +42,7 @@ qreal easeOutCubic(qreal t)
 } // namespace
 
 ArrowItem::ArrowItem(QSharedPointer<const ArrowData> _data, ArrowTarget *_startItem, ArrowTarget *_targetItem)
-    : data(std::move(_data)), startItem(_startItem), targetItem(_targetItem)
+    : QGraphicsObject(), data(std::move(_data)), startItem(_startItem), targetItem(_targetItem)
 {
     setZValue(ZValues::ARROWS);
 

cockatrice/src/game_graphics/board/arrow_item.h

@@ -16,7 +16,7 @@ class CardItem;
 class QGraphicsSceneMouseEvent;
 class PlayerLogic;
 
-class ArrowItem : public QObject, public QGraphicsItem, public IAnimatedItem
+class ArrowItem : public QGraphicsObject, public IAnimatedItem
 {
     Q_OBJECT
 signals:

cockatrice/src/game_graphics/phases_toolbar.cpp

@@ -14,8 +14,8 @@
 #include <libcockatrice/utility/zone_names.h>
 
 PhaseButton::PhaseButton(const QString &_name, QGraphicsItem *parent, QAction *_doubleClickAction, bool _highlightable)
-    : QObject(), QGraphicsItem(parent), name(_name), active(false), highlightable(_highlightable),
-      activeAnimationCounter(0), doubleClickAction(_doubleClickAction), width(50)
+    : QGraphicsObject(parent), name(_name), active(false), highlightable(_highlightable), activeAnimationCounter(0),
+      doubleClickAction(_doubleClickAction), width(50)
 {
     if (highlightable) {
         activeAnimationTimer = new QTimer(this);
@@ -108,7 +108,7 @@ void PhaseButton::triggerDoubleClickAction()
 }
 
 PhasesToolbar::PhasesToolbar(QGraphicsItem *parent)
-    : QGraphicsItem(parent), width(100), height(100), ySpacing(1), symbolSize(8)
+    : QGraphicsObject(parent), width(100), height(100), ySpacing(1), symbolSize(8)
 {
     auto *aUntapAll = new QAction(this);
     connect(aUntapAll, &QAction::triggered, this, &PhasesToolbar::actUntapAll);

cockatrice/src/game_graphics/phases_toolbar.h

@@ -24,7 +24,7 @@ class Message;
 class PlayerLogic;
 class GameCommand;
 
-class PhaseButton : public QObject, public QGraphicsItem
+class PhaseButton : public QGraphicsObject
 {
     Q_OBJECT
 private:
@@ -61,7 +61,7 @@ protected:
     void mouseDoubleClickEvent(QGraphicsSceneMouseEvent *event) override;
 };
 
-class PhasesToolbar : public QObject, public QGraphicsItem
+class PhasesToolbar : public QGraphicsObject
 {
     Q_OBJECT
 private:

cockatrice/src/game_graphics/player/player_area.cpp

@@ -4,7 +4,7 @@
 
 #include <QPainter>
 
-PlayerArea::PlayerArea(QGraphicsItem *parentItem) : QObject(), QGraphicsItem(parentItem)
+PlayerArea::PlayerArea(QGraphicsItem *parentItem) : QGraphicsObject(parentItem)
 {
     setCacheMode(DeviceCoordinateCache);
     connect(themeManager, &ThemeManager::themeChanged, this, &PlayerArea::updateBg);

cockatrice/src/game_graphics/player/player_area.h

@@ -13,7 +13,7 @@
 /**
  * The entire graphical area belonging to a single player.
  */
-class PlayerArea : public QObject, public QGraphicsItem
+class PlayerArea : public QGraphicsObject
 {
     Q_OBJECT
 private:

cockatrice/src/game_graphics/zones/view_zone.h

@@ -34,6 +34,7 @@ class QGraphicsSceneWheelEvent;
 class ZoneViewZone : public SelectZone, public QGraphicsLayoutItem
 {
     Q_OBJECT
+    Q_INTERFACES(QGraphicsLayoutItem)
 private:
     static constexpr int HORIZONTAL_PADDING = 12;
     static constexpr int VERTICAL_PADDING = 5;

tests/CMakeLists.txt

@@ -205,7 +205,7 @@ target_link_libraries(
 )
 
 if(WITH_CLIENT)
-  target_link_libraries(single_instance_manager_test Threads::Threads ${GTEST_BOTH_LIBRARIES} ${TEST_QT_MODULES})
+  target_link_libraries(single_instance_manager_test Threads::Threads ${GTEST_BOTH_LIBRARIES} ${QT_MODULES_TEST})
 endif()
 
 add_subdirectory(card_zone_algorithms)

tests/picture_loader_benchmark/CMakeLists.txt

@@ -22,5 +22,5 @@ target_link_libraries(
   libcockatrice_interfaces
   libcockatrice_utility
   Threads::Threads
-  ${TEST_QT_MODULES}
+  ${QT_MODULES_TEST}
 )

tests/theme_migration/CMakeLists.txt

@@ -20,7 +20,7 @@ target_link_libraries(
   libcockatrice_protocol
   Threads::Threads
   ${GTEST_BOTH_LIBRARIES}
-  ${TEST_QT_MODULES}
+  ${QT_MODULES_TEST}
 )
 
 add_test(NAME theme_migration_test COMMAND theme_migration_test)