From ec98bcf95dd58624830d07001b86aa0e11326204 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Br=C3=BCbach=2C=20Lukas?= Date: Wed, 3 Dec 2025 10:37:50 +0100 Subject: [PATCH 1/8] [Oracle] Add low-memory check (<=4GiB) and use mtgxml url instead. --- libcockatrice_utility/CMakeLists.txt | 5 +- .../utility/system_memory_querier.cpp | 107 ++++++++++++++++++ .../utility/system_memory_querier.h | 19 ++++ oracle/src/pages.cpp | 19 ++++ 4 files changed, 148 insertions(+), 2 deletions(-) create mode 100644 libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp create mode 100644 libcockatrice_utility/libcockatrice/utility/system_memory_querier.h diff --git a/libcockatrice_utility/CMakeLists.txt b/libcockatrice_utility/CMakeLists.txt index 0575c260f..d626b1dc1 100644 --- a/libcockatrice_utility/CMakeLists.txt +++ b/libcockatrice_utility/CMakeLists.txt @@ -6,12 +6,13 @@ set(CMAKE_AUTOUIC ON) set(CMAKE_AUTORCC ON) set(UTILITY_SOURCES libcockatrice/utility/expression.cpp libcockatrice/utility/levenshtein.cpp - libcockatrice/utility/passwordhasher.cpp + libcockatrice/utility/passwordhasher.cpp libcockatrice/utility/system_memory_querier.cpp ) set(UTILITY_HEADERS libcockatrice/utility/color.h libcockatrice/utility/expression.h libcockatrice/utility/levenshtein.h - libcockatrice/utility/macros.h libcockatrice/utility/passwordhasher.h libcockatrice/utility/trice_limits.h + libcockatrice/utility/macros.h libcockatrice/utility/passwordhasher.h libcockatrice/utility/system_memory_querier.h + libcockatrice/utility/trice_limits.h ) add_library(libcockatrice_utility STATIC ${UTILITY_SOURCES} ${UTILITY_HEADERS}) diff --git a/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp new file mode 100644 index 000000000..e42aee987 --- /dev/null +++ b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp @@ -0,0 +1,107 @@ +#include "system_memory_querier.h" + +#ifdef Q_OS_WIN +#include +#endif + +#ifdef Q_OS_LINUX +#include +#include +#endif + +#ifdef Q_OS_MACOS +#include +#include +#include +#include +#endif + +qulonglong SystemMemoryQuerier::totalMemoryBytes() +{ +#if defined(Q_OS_WIN) + + MEMORYSTATUSEX statex; + statex.dwLength = sizeof(statex); + if (GlobalMemoryStatusEx(&statex)) + return statex.ullTotalPhys; + return 0; + +#elif defined(Q_OS_LINUX) + + QFile file("/proc/meminfo"); + if (!file.open(QIODevice::ReadOnly | QIODevice::Text)) + return 0; + + QTextStream in(&file); + while (!in.atEnd()) { + QString line = in.readLine(); + if (line.startsWith("MemTotal:")) { + QStringList parts = line.split(QRegExp("\\s+"), Qt::SkipEmptyParts); + if (parts.size() >= 2) + return parts[1].toULongLong() * 1024; // kB → bytes + } + } + return 0; + +#elif defined(Q_OS_MACOS) + + int mib[2] = {CTL_HW, HW_MEMSIZE}; + qulonglong memsize = 0; + size_t len = sizeof(memsize); + + if (sysctl(mib, 2, &memsize, &len, nullptr, 0) == 0) + return memsize; + + return 0; + +#else + return 0; +#endif +} + +qulonglong SystemMemoryQuerier::availableMemoryBytes() +{ +#if defined(Q_OS_WIN) + + MEMORYSTATUSEX statex; + statex.dwLength = sizeof(statex); + if (GlobalMemoryStatusEx(&statex)) + return statex.ullAvailPhys; + return 0; + +#elif defined(Q_OS_LINUX) + + QFile file("/proc/meminfo"); + if (!file.open(QIODevice::ReadOnly | QIODevice::Text)) + return 0; + + QTextStream in(&file); + while (!in.atEnd()) { + QString line = in.readLine(); + if (line.startsWith("MemAvailable:")) { + QStringList parts = line.split(QRegExp("\\s+"), Qt::SkipEmptyParts); + if (parts.size() >= 2) + return parts[1].toULongLong() * 1024; + } + } + return 0; + +#elif defined(Q_OS_MACOS) + + vm_size_t pageSize; + host_page_size(mach_host_self(), &pageSize); + + mach_msg_type_number_t count = HOST_VM_INFO_COUNT; + vm_statistics64_data_t vmstat; + + if (host_statistics64(mach_host_self(), HOST_VM_INFO, (host_info64_t)&vmstat, &count) != KERN_SUCCESS) + return 0; + + qulonglong freeBytes = (qulonglong)vmstat.free_count * (qulonglong)pageSize; + + return freeBytes; + +#else + return 0; +#endif +} diff --git a/libcockatrice_utility/libcockatrice/utility/system_memory_querier.h b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.h new file mode 100644 index 000000000..44fd9f6f9 --- /dev/null +++ b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.h @@ -0,0 +1,19 @@ +#ifndef COCKATRICE_SYSTEM_MEMORY_QUERIER_H +#define COCKATRICE_SYSTEM_MEMORY_QUERIER_H + +#include + +class SystemMemoryQuerier +{ +public: + static qulonglong totalMemoryBytes(); + static qulonglong availableMemoryBytes(); + + static bool hasAtLeastGiB(int gib) + { + const qulonglong GiB = 1024ull * 1024ull * 1024ull; + return totalMemoryBytes() >= (qulonglong)gib * GiB; + } +}; + +#endif // COCKATRICE_SYSTEM_MEMORY_QUERIER_H diff --git a/oracle/src/pages.cpp b/oracle/src/pages.cpp index 46edf1cf8..fcf26cc16 100644 --- a/oracle/src/pages.cpp +++ b/oracle/src/pages.cpp @@ -1,6 +1,7 @@ #include "pages.h" #include "client/settings/cache_settings.h" +#include "libcockatrice/utility/system_memory_querier.h" #include "main.h" #include "oracleimporter.h" #include "oraclewizard.h" @@ -43,6 +44,7 @@ #define MTGJSON_V4_URL_COMPONENT "mtgjson.com/files/" #define ALLSETS_URL_FALLBACK "https://www.mtgjson.com/api/v5/AllPrintings.json" #define MTGJSON_VERSION_URL "https://www.mtgjson.com/api/v5/Meta.json" +#define MTGXML_URL "https://github.com/ebbit1q/mtgxml/releases/latest/download/mtg.xml.xz" #ifdef HAS_LZMA #define ALLSETS_URL "https://www.mtgjson.com/api/v5/AllPrintings.json.xz" @@ -185,6 +187,23 @@ void LoadSetsPage::initializePage() { urlLineEdit->setText(wizard()->settings->value("allsetsurl", ALLSETS_URL).toString()); + // Memory check because Oracle parsing fails on systems with less than 4GiB for MTGJsons allPrintings.json + if (!SystemMemoryQuerier::hasAtLeastGiB(33)) { + // Ask user whether to switch URL + QMessageBox msgBox( + QMessageBox::Question, tr("Low Memory Detected"), + tr("Your system has less than 4 GiB of memory.\n" + "Using the default AllPrintings URL may cause high memory usage and is known to fail as a result.\n\n" + "Would you like to switch to the direct-download pre-parsed URL instead? (Updated daily)"), + QMessageBox::Yes | QMessageBox::No, this); + + msgBox.setDefaultButton(QMessageBox::Yes); + + if (msgBox.exec() == QMessageBox::Yes) { + urlLineEdit->setText(MTGXML_URL); + } + } + progressLabel->hide(); progressBar->hide(); From d4bf40694a5987e57ce87bfef972d5d7ed4b2e83 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Br=C3=BCbach=2C=20Lukas?= Date: Wed, 3 Dec 2025 10:44:40 +0100 Subject: [PATCH 2/8] [Oracle] Correct size and only do this if the user has not set a non-default url. --- oracle/src/pages.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/oracle/src/pages.cpp b/oracle/src/pages.cpp index fcf26cc16..6110fb58b 100644 --- a/oracle/src/pages.cpp +++ b/oracle/src/pages.cpp @@ -188,7 +188,7 @@ void LoadSetsPage::initializePage() urlLineEdit->setText(wizard()->settings->value("allsetsurl", ALLSETS_URL).toString()); // Memory check because Oracle parsing fails on systems with less than 4GiB for MTGJsons allPrintings.json - if (!SystemMemoryQuerier::hasAtLeastGiB(33)) { + if (!SystemMemoryQuerier::hasAtLeastGiB(4) && urlLineEdit->text() == ALLSETS_URL) { // Ask user whether to switch URL QMessageBox msgBox( QMessageBox::Question, tr("Low Memory Detected"), From 4ddbc8d018f5ef05894bc12c7cc27b8f1cffc4ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Br=C3=BCbach=2C=20Lukas?= Date: Wed, 3 Dec 2025 10:51:02 +0100 Subject: [PATCH 3/8] [Oracle] Include QRegularExpression. --- .../libcockatrice/utility/system_memory_querier.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp index e42aee987..9a4539256 100644 --- a/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp +++ b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp @@ -6,6 +6,7 @@ #ifdef Q_OS_LINUX #include +#include #include #endif From 65a34230092dd3428a4a536e513319812d6758f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Br=C3=BCbach=2C=20Lukas?= Date: Wed, 3 Dec 2025 10:53:08 +0100 Subject: [PATCH 4/8] [Oracle] Lint. --- libcockatrice_utility/CMakeLists.txt | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libcockatrice_utility/CMakeLists.txt b/libcockatrice_utility/CMakeLists.txt index d626b1dc1..be07ad2f4 100644 --- a/libcockatrice_utility/CMakeLists.txt +++ b/libcockatrice_utility/CMakeLists.txt @@ -6,13 +6,17 @@ set(CMAKE_AUTOUIC ON) set(CMAKE_AUTORCC ON) set(UTILITY_SOURCES libcockatrice/utility/expression.cpp libcockatrice/utility/levenshtein.cpp - libcockatrice/utility/passwordhasher.cpp libcockatrice/utility/system_memory_querier.cpp + libcockatrice/utility/passwordhasher.cpp libcockatrice/utility/system_memory_querier.cpp ) set(UTILITY_HEADERS - libcockatrice/utility/color.h libcockatrice/utility/expression.h libcockatrice/utility/levenshtein.h - libcockatrice/utility/macros.h libcockatrice/utility/passwordhasher.h libcockatrice/utility/system_memory_querier.h - libcockatrice/utility/trice_limits.h + libcockatrice/utility/color.h + libcockatrice/utility/expression.h + libcockatrice/utility/levenshtein.h + libcockatrice/utility/macros.h + libcockatrice/utility/passwordhasher.h + libcockatrice/utility/system_memory_querier.h + libcockatrice/utility/trice_limits.h ) add_library(libcockatrice_utility STATIC ${UTILITY_SOURCES} ${UTILITY_HEADERS}) From 2c0c8b416a646c867712695d263d4db26cb9027e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Br=C3=BCbach=2C=20Lukas?= Date: Wed, 3 Dec 2025 10:57:56 +0100 Subject: [PATCH 5/8] [Oracle] Qt version guard for regexp --- .../libcockatrice/utility/system_memory_querier.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp index 9a4539256..46c24f69c 100644 --- a/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp +++ b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp @@ -37,7 +37,11 @@ qulonglong SystemMemoryQuerier::totalMemoryBytes() while (!in.atEnd()) { QString line = in.readLine(); if (line.startsWith("MemTotal:")) { - QStringList parts = line.split(QRegExp("\\s+"), Qt::SkipEmptyParts); +#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) + QStringList parts = line.split(QRegExp("\\s+"), QString::SkipEmptyParts); +#else + QStringList parts = line.split(QRegularExpression("\\s+"), Qt::SkipEmptyParts); +#endif if (parts.size() >= 2) return parts[1].toULongLong() * 1024; // kB → bytes } From fdbc4734a473e2b40b16519d0e893aa9059ea7a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Sun, 11 Oct 2026 15:25:36 +0200 Subject: [PATCH 6/8] [Oracle] Fix Qt6 build and treat unknown memory as sufficient Use QRegularExpression behind the same Qt version guard as totalMemoryBytes() in availableMemoryBytes(), where a bare QRegExp broke every Qt6 Linux build. hasAtLeastGiB() now treats a 0 reading (unsupported platform or failed query) as unknown and skips the low-memory prompt instead of misreading it as low memory. --- .../libcockatrice/utility/system_memory_querier.cpp | 6 +++++- .../libcockatrice/utility/system_memory_querier.h | 8 +++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp index 46c24f69c..b4553f8d2 100644 --- a/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp +++ b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.cpp @@ -84,7 +84,11 @@ qulonglong SystemMemoryQuerier::availableMemoryBytes() while (!in.atEnd()) { QString line = in.readLine(); if (line.startsWith("MemAvailable:")) { - QStringList parts = line.split(QRegExp("\\s+"), Qt::SkipEmptyParts); +#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) + QStringList parts = line.split(QRegExp("\\s+"), QString::SkipEmptyParts); +#else + QStringList parts = line.split(QRegularExpression("\\s+"), Qt::SkipEmptyParts); +#endif if (parts.size() >= 2) return parts[1].toULongLong() * 1024; } diff --git a/libcockatrice_utility/libcockatrice/utility/system_memory_querier.h b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.h index 44fd9f6f9..8a15fecdd 100644 --- a/libcockatrice_utility/libcockatrice/utility/system_memory_querier.h +++ b/libcockatrice_utility/libcockatrice/utility/system_memory_querier.h @@ -11,8 +11,14 @@ public: static bool hasAtLeastGiB(int gib) { + const qulonglong total = totalMemoryBytes(); + // 0 means the amount could not be determined (unsupported platform or failed query). + // Treat it as unknown and skip the check instead of misreading it as low memory. + if (total == 0) { + return true; + } const qulonglong GiB = 1024ull * 1024ull * 1024ull; - return totalMemoryBytes() >= (qulonglong)gib * GiB; + return total >= (qulonglong)gib * GiB; } }; From 7a4cfa56853d8bdb8ebf9a0c6019ea1a90da6a9a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Sun, 11 Oct 2026 15:25:36 +0200 Subject: [PATCH 7/8] [Build] Fix toolchain rot: const PlayerReference comparison, static writeMetadata --- libcockatrice_deck_list/libcockatrice/deck_list/deck_list.cpp | 2 +- .../network/server/remote/server_player_reference.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libcockatrice_deck_list/libcockatrice/deck_list/deck_list.cpp b/libcockatrice_deck_list/libcockatrice/deck_list/deck_list.cpp index cea759428..30b7ba314 100644 --- a/libcockatrice_deck_list/libcockatrice/deck_list/deck_list.cpp +++ b/libcockatrice_deck_list/libcockatrice/deck_list/deck_list.cpp @@ -166,7 +166,7 @@ bool DeckList::readElement(QXmlStreamReader *xml) return true; } -void writeMetadata(QXmlStreamWriter *xml, const DeckList::Metadata &metadata) +static void writeMetadata(QXmlStreamWriter *xml, const DeckList::Metadata &metadata) { xml->writeTextElement("lastLoadedTimestamp", metadata.lastLoadedTimestamp); xml->writeTextElement("deckname", metadata.name); diff --git a/libcockatrice_network/libcockatrice/network/server/remote/server_player_reference.h b/libcockatrice_network/libcockatrice/network/server/remote/server_player_reference.h index 07b2d3d2b..b478a4244 100644 --- a/libcockatrice_network/libcockatrice/network/server/remote/server_player_reference.h +++ b/libcockatrice_network/libcockatrice/network/server/remote/server_player_reference.h @@ -24,7 +24,7 @@ public: { return playerId; } - bool operator==(const PlayerReference &other) + bool operator==(const PlayerReference &other) const { return ((roomId == other.roomId) && (gameId == other.gameId) && (playerId == other.playerId)); } From 94c5a7d43fb7a194636c1fc1d32dff7e0c809c59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Br=C3=BCbach?= Date: Sun, 11 Oct 2026 17:51:52 +0200 Subject: [PATCH 8/8] [Oracle] Skip low-memory prompt in background mode, guard with HAS_LZMA --- oracle/src/pages.cpp | 31 ++++++++++++++++++++----------- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/oracle/src/pages.cpp b/oracle/src/pages.cpp index 6110fb58b..0b500a29a 100644 --- a/oracle/src/pages.cpp +++ b/oracle/src/pages.cpp @@ -188,21 +188,30 @@ void LoadSetsPage::initializePage() urlLineEdit->setText(wizard()->settings->value("allsetsurl", ALLSETS_URL).toString()); // Memory check because Oracle parsing fails on systems with less than 4GiB for MTGJsons allPrintings.json + // The fallback URL is xz-compressed, so only offer it in builds that can read it. + // During background (automatic) updates there is no user to answer, so switch silently. +#ifdef HAS_LZMA if (!SystemMemoryQuerier::hasAtLeastGiB(4) && urlLineEdit->text() == ALLSETS_URL) { - // Ask user whether to switch URL - QMessageBox msgBox( - QMessageBox::Question, tr("Low Memory Detected"), - tr("Your system has less than 4 GiB of memory.\n" - "Using the default AllPrintings URL may cause high memory usage and is known to fail as a result.\n\n" - "Would you like to switch to the direct-download pre-parsed URL instead? (Updated daily)"), - QMessageBox::Yes | QMessageBox::No, this); - - msgBox.setDefaultButton(QMessageBox::Yes); - - if (msgBox.exec() == QMessageBox::Yes) { + if (wizard()->backgroundMode) { urlLineEdit->setText(MTGXML_URL); + } else { + // Ask user whether to switch URL + QMessageBox msgBox( + QMessageBox::Question, tr("Low Memory Detected"), + tr("Your system has less than 4 GiB of memory.\n" + "Using the default AllPrintings URL may cause high memory usage and is known to fail as a " + "result.\n\n" + "Would you like to switch to the direct-download pre-parsed URL instead? (Updated daily)"), + QMessageBox::Yes | QMessageBox::No, this); + + msgBox.setDefaultButton(QMessageBox::Yes); + + if (msgBox.exec() == QMessageBox::Yes) { + urlLineEdit->setText(MTGXML_URL); + } } } +#endif progressLabel->hide(); progressBar->hide();