mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-21 09:05:10 -07:00
* [Client] Show localized card names, texts and pictures
Localization wiring now runs end to end: the oracle importer collects
foreignData for the configured language and the client renders it.
- [Oracle] Import localized names and rules texts for the selected cardLang
- single-face cards store their foreignData name and full text
- multi-face (split/adventure/aftermath/prepare) cards collect the joined
name once and join each face's translated text with the same separator
as the English merge; an incomplete translation falls back to English;
the joined text follows the same highest-priority-set policy as the
single-face path and is only collected when localization is enabled
- the wizard switching languages re-imports the card database
- [Client] Display localized card info throughout the client
- card info text/picture widgets and the game board re-render on language
change
- pictures resolve cardLang art through Scryfall's named endpoint using the
localized name, falling back to id-based art when no match exists
- deck editor keeps canonical English names as card identity (EditRole)
while showing localized names (DisplayRole), so decks and wire names
stay stable
- [Card] Add CardLocalization-backed name/text lookup and cards.xml v4
localization elements with a bounded-size translation cache
- [Tests] Cover oracle foreignData import (incl. multi-face joins, priority
and fallback paths), XML v4 localization parsing, deck model localized
display and the language-aware settings default
Existing installations need to re-run Oracle to see translations: localized
data only lands in cards.xml when the Oracle app is started with the
preferred language selected — launch the separate "Oracle" program that
ships with Cockatrice, pick the language in the wizard and let it re-import
the card database.
The client's database cache (cards.xml.cache) is invalidated by the cache
format bump and the source-hash checks, but a cache written before the
re-import can still hold English-only entries (the hash uses file size and
mtime, so a same-size/same-timestamp rewrite may be served as-is); delete
cards.xml.cache and relaunch if no localized names/texts show up after
re-importing.
* [Card] Pass localized card names and texts into CardInfo construction
Address review: instead of constructing the card and then calling
setLocalizedName/setLocalizedText (which emit a cardInfoChanged signal per
language), both constructors, both newInstance overloads and their callers
(cards.xml v4 parser and the binary cache reader) now pass the localized maps
as constructor arguments.
* [Client] Rename LocalizedCard:: helpers namespace to CardLocalization
The namespace now matches its header file name, as the review pointed out;
LocalizedCard reads more like a class or struct. Callers (card info text
widget, board card name rendering) are updated to match.
* [Client] Drop unused info member from the card info text widget
The CardInfoPtr member was only ever initialized to nullptr and never read;
remove it together with its initializer.
* [PictureLoader] Add the localized picture URL explicitly, not implicitly
Address review: silently prepending the Scryfall named-picture URL to the
download list whenever a non-English card language was active was surprising,
consumed quota per card when it failed, and could grab the wrong (canon) art on
name collisions, with no way to turn it off.
The insert is now opt-in and user-controlled: changing the card language adds
the template to the top of the download URLs once (persisted, documented in the
re-import prompt, and editable/removable in the deck editor settings), while the
picture loader no longer injects it at request time.
* [Card] Show card languages in the same native (English) format as the UI
Address review: the card text & images language dropdown listed bare native
names, some in inconsistent lowercase (e.g. "čeština", "español de España"),
which makes the languages easy to mix up for users that do not read the script
(e.g. 日本語 vs 한국어). It now mirrors the UI language dropdown and always pairs
the native name with its English name (e.g. "Deutsch (German)",
"日本語 (Japanese)"), using the same fixed casing.
---------
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
100 lines
3.1 KiB
C++
100 lines
3.1 KiB
C++
/**
|
|
* @file dlg_settings.h
|
|
* @brief Main settings dialog for the Cockatrice client
|
|
* @ingroup Dialogs
|
|
*/
|
|
#ifndef DLG_SETTINGS_H
|
|
#define DLG_SETTINGS_H
|
|
|
|
#include <QDialog>
|
|
#include <QLoggingCategory>
|
|
|
|
class QPushButton;
|
|
|
|
inline Q_LOGGING_CATEGORY(DlgSettingsLog, "dlg_settings");
|
|
|
|
class QStackedWidget;
|
|
class QToolButton;
|
|
class QListView;
|
|
class QLineEdit;
|
|
|
|
class AbstractSettingsPage;
|
|
class SettingsSearchModel;
|
|
class SettingsSearchDelegate;
|
|
|
|
/**
|
|
* @brief Main application settings dialog with tabbed navigation and search
|
|
*
|
|
* Provides a modern settings interface organized into tabbed pages. Users can
|
|
* either navigate by clicking tabs or search for specific settings using the
|
|
* built-in search bar. Search results are filtered and ranked by relevance.
|
|
*/
|
|
class DlgSettings : public QDialog
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
/**
|
|
* @brief Page order in the tab bar, matching the order pages are added in setupUi()
|
|
*
|
|
* Use these values instead of raw indices so reordering pages never silently
|
|
* breaks external callers like tab_room.cpp.
|
|
*/
|
|
enum SettingsPage
|
|
{
|
|
GeneralPage = 0,
|
|
AppearancePage,
|
|
UserInterfacePage,
|
|
DeckEditorPage,
|
|
StoragePage,
|
|
MessagesPage,
|
|
SoundPage,
|
|
ShortcutsPage,
|
|
NumPages
|
|
};
|
|
|
|
explicit DlgSettings(QWidget *parent = nullptr);
|
|
void setTab(int index);
|
|
AbstractSettingsPage *page(SettingsPage which) const;
|
|
|
|
private slots:
|
|
void onTabClicked(int index);
|
|
void onSearchTextChanged(const QString &text);
|
|
void onSearchResultClicked(const QModelIndex &index);
|
|
void updateLanguage();
|
|
|
|
private:
|
|
// UI elements
|
|
QLineEdit *searchEdit; ///< Search bar for filtering settings
|
|
QWidget *tabBarWidget; ///< Container widget for the tab buttons
|
|
QList<QToolButton *> tabButtons; ///< Navigation tab buttons
|
|
QStackedWidget *pagesWidget; ///< Stacked widget containing settings pages
|
|
QListView *searchResultsView; ///< Search results list view
|
|
QWidget *pagesContainer; ///< Container stacking pages and search results
|
|
QPushButton *okButton; ///< Button to close the dialog
|
|
|
|
// Data
|
|
QList<AbstractSettingsPage *> pages; ///< All settings page instances
|
|
SettingsSearchModel *searchModel; ///< Model for search results
|
|
SettingsSearchDelegate *searchDelegate; ///< Delegate for search result rendering
|
|
int currentTabIndex; ///< Currently active tab index
|
|
bool searchActive; ///< Whether search mode is active
|
|
|
|
void setupUi();
|
|
void setupTabBar();
|
|
void buildSearchIndex();
|
|
void switchToTabMode();
|
|
void switchToSearchMode();
|
|
void navigateToSearchResult(const QModelIndex &index);
|
|
void setActiveTab(int index);
|
|
static void flashWidget(QWidget *widget);
|
|
static QStringList translatedPageNames();
|
|
|
|
void retranslateUi();
|
|
void retranslateTabNames();
|
|
|
|
protected:
|
|
void closeEvent(QCloseEvent *event) override;
|
|
bool eventFilter(QObject *watched, QEvent *event) override;
|
|
};
|
|
|
|
#endif // DLG_SETTINGS_H
|