mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-11-05 09:33:25 -08:00
068ea1627f
The guard answered "nothing is holding the payload" from two lookups that can both miss a running instance: Restart Manager does not reliably report a program's own image or the modules it mapped, and the image path of a process running under another account cannot be read from the probe at all. A user log showed exactly that: the first guard passed while cockatrice.exe was running from the directory, the old uninstaller silently skipped the file it could not delete, and the update aborted half an uninstall later with "cancelled by user" after a close attempt the running window ignored. Ask the file itself. A running image is opened without write sharing, so the write open replacing it needs is refused with ERROR_SHARING_VIOLATION for as long as the program runs, while a file that is merely being read still accepts it. When neither lookup named anybody and a payload executable refuses that open, the probe answers that the file is in use and that the program holding it could not be identified - the guard's "could not confirm" dialog, whose Retry works once the user has closed it - instead of passing the payload as free. Only the payload executables are tested, not every file the purge removes: a locked executable proves a program is running and a mapped DLL belongs to a running executable, while a locked DLL or qt.conf can be the asking process itself, which is the loop the guard already had. The open is retried once after 300 ms, and only for the files that refused, so a scanner holding a file for a moment cannot stop an install for nothing. The Windows probe check now covers that answer: a payload executable held by the asking process, so that it cannot be named, has to come back as in use rather than as free. Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
25 lines
1.4 KiB
CMake
25 lines
1.4 KiB
CMake
# Windows-only. The installer runs this before anything is replaced (the running-instance
|
|
# guard in .onInit) and on the abort path of a failed purge, to name the applications and
|
|
# services holding the payload open (Restart Manager); see the GuardAppsNotRunning and
|
|
# LogProcessesUsingInstallDir functions in cmake/NSIS.template.in. It ships inside the
|
|
# installer and the uninstaller and is extracted to $PLUGINSDIR there, never installed, so
|
|
# it links nothing from this project: no Qt, and a static C runtime because the installed
|
|
# runtime is exactly what the purge may have failed to replace.
|
|
add_executable(
|
|
installer-holder-probe close_holders.cpp holder_line.cpp main.cpp payload_locks.cpp payload_paths.cpp
|
|
restart_manager_holders.cpp
|
|
)
|
|
|
|
target_link_libraries(installer-holder-probe PRIVATE rstrtmgr)
|
|
|
|
# The NSIS template embeds the built file by the same relative path that resolves
|
|
# NSIS.definitions.nsh, and that path points at the build root.
|
|
set_target_properties(
|
|
installer-holder-probe
|
|
PROPERTIES MSVC_RUNTIME_LIBRARY "MultiThreaded"
|
|
RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}"
|
|
RUNTIME_OUTPUT_DIRECTORY_DEBUG "${CMAKE_BINARY_DIR}"
|
|
RUNTIME_OUTPUT_DIRECTORY_MINSIZEREL "${CMAKE_BINARY_DIR}"
|
|
RUNTIME_OUTPUT_DIRECTORY_RELEASE "${CMAKE_BINARY_DIR}"
|
|
RUNTIME_OUTPUT_DIRECTORY_RELWITHDEBINFO "${CMAKE_BINARY_DIR}"
|
|
)
|