mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-11-05 09:33:25 -08:00
068ea1627f
The guard answered "nothing is holding the payload" from two lookups that can both miss a running instance: Restart Manager does not reliably report a program's own image or the modules it mapped, and the image path of a process running under another account cannot be read from the probe at all. A user log showed exactly that: the first guard passed while cockatrice.exe was running from the directory, the old uninstaller silently skipped the file it could not delete, and the update aborted half an uninstall later with "cancelled by user" after a close attempt the running window ignored. Ask the file itself. A running image is opened without write sharing, so the write open replacing it needs is refused with ERROR_SHARING_VIOLATION for as long as the program runs, while a file that is merely being read still accepts it. When neither lookup named anybody and a payload executable refuses that open, the probe answers that the file is in use and that the program holding it could not be identified - the guard's "could not confirm" dialog, whose Retry works once the user has closed it - instead of passing the payload as free. Only the payload executables are tested, not every file the purge removes: a locked executable proves a program is running and a mapped DLL belongs to a running executable, while a locked DLL or qt.conf can be the asking process itself, which is the loop the guard already had. The open is retried once after 300 ms, and only for the files that refused, so a scanner holding a file for a moment cannot stop an install for nothing. The Windows probe check now covers that answer: a payload executable held by the asking process, so that it cannot be named, has to come back as in use rather than as free. Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
48 lines
1.6 KiB
C++
48 lines
1.6 KiB
C++
#include "payload_paths.h"
|
|
|
|
#include <algorithm>
|
|
#include <cstddef>
|
|
#include <iterator>
|
|
|
|
namespace
|
|
{
|
|
/// Compares two file names the way the file system does, without a locale.
|
|
///
|
|
/// Only the names above are ever compared against, and all of them are ASCII, so folding
|
|
/// the ASCII letters is the whole answer. The Windows ordinal comparison is not used here
|
|
/// on purpose: this file is compiled into a test that runs everywhere, and the question
|
|
/// "is this image a program the payload installs?" must be answerable without Windows.
|
|
bool equalsIgnoringAsciiCase(const std::wstring &left, const std::wstring &right)
|
|
{
|
|
if (left.size() != right.size()) {
|
|
return false;
|
|
}
|
|
return std::equal(left.begin(), left.end(), right.begin(), [](wchar_t a, wchar_t b) {
|
|
const wchar_t foldedA = a >= L'A' && a <= L'Z' ? static_cast<wchar_t>(a - L'A' + L'a') : a;
|
|
const wchar_t foldedB = b >= L'A' && b <= L'Z' ? static_cast<wchar_t>(b - L'A' + L'a') : b;
|
|
return foldedA == foldedB;
|
|
});
|
|
}
|
|
} // namespace
|
|
|
|
std::wstring fileNameOf(const std::wstring &path)
|
|
{
|
|
const std::size_t separator = path.find_last_of(L"\\/");
|
|
return separator == std::wstring::npos ? path : path.substr(separator + 1);
|
|
}
|
|
|
|
std::wstring parentDirectoryOf(const std::wstring &path)
|
|
{
|
|
const std::size_t separator = path.find_last_of(L"\\/");
|
|
return separator == std::wstring::npos ? std::wstring() : path.substr(0, separator);
|
|
}
|
|
|
|
bool isPayloadProgram(const std::wstring &imageName)
|
|
{
|
|
for (const wchar_t *program : PAYLOAD_PROGRAMS) {
|
|
if (equalsIgnoringAsciiCase(imageName, program)) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|