mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-22 01:25:10 -07:00
Some checks are pending
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 44 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 12 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Docker Image / amd64 & arm64 (push) Waiting to run
* [Server/Client/Protocol] Reporting users + moderation queue functionality Took 6 minutes Took 3 minutes Took 8 seconds Took 11 minutes Took 12 minutes Took 7 minutes Took 15 seconds Took 2 minutes Took 1 minute Took 30 seconds Took 16 seconds * CI Fix Took 6 minutes * CI Fix Took 6 minutes * [Protocol] Add moderation investigation commands Adds the protocol layer for the moderation investigation suite: - Command_GetUserSessions/GetUserAlts/GetModeratorLastLogins/ResetUserPassword/RemoveUserAvatar (1013-1017) - Response extensions 1215-1219 with ServerInfo messages for sessions, alts, and staff logins - last_login on Response_ReportUserInfo and warning_il on Response_WarnList Took 2 minutes * [Utility] Add warning categories parser with infraction levels Parses the server's 'officialwarnings' setting (comma-separated, optional '|IL' suffix) into WarningCategory structs so the client can display the infraction level of each warning category. Includes GTest coverage. * [Server] Add moderation investigation tools Implements the server side of the moderation suite: - getUserSessions/getUserAlts/getModeratorLastLogins/removeUserAvatar DB methods - Handlers for all five new commands with audit records (PASSWORD_RESET, REMOVE_USER_AVATAR); password resets return a generated temporary password - cmdGetWarnList now reports per-category infraction levels from the officialwarnings setting; cmdReportUserInfo reports last_login - Update servatrice.ini.example with the warning taxonomy - Password/avatar mutations report RespNameNotFound when the user does not exist * [Client] Add moderation tab with investigate, password reset, and avatar removal - New Moderation tab: search a user to show account info, alternate accounts, login sessions, and staff last logins; actions to reset the user's password (shows the generated temporary password) and remove the user's avatar - 'Investigate user' entry in the user context menu opens the tab pre-loaded for that user - Warning dialog shows the infraction level of each warning category - Tab wired into TabSupervisor with a moderator-gated menu action, shortcut, and tabs.ini persistence (default closed) * [Server/Client/Protocol] Address PR #7091 review: security, bug, and perf fixes Security: - Promote RESET_USER_PASSWORD to admin-only dispatch (was moderator-accessible) - Reject password reset on users with equal/higher privilege than caller - Notify affected user via Event_NotifyUser::CUSTOM when password is reset - Add server-side category whitelist for reports - Drop reporter name fallback in comment/details authorization (ID-only) - Force password change: new DB column + login enforcement + client disconnect Bugs: - XSS via QTextEdit::append() → insertPlainText() in report tab and utils - allNotified initialized to true even with empty recipients list - Warning combo box: use currentData() instead of baked-in display text - Report resolution now records who resolved (resolved_by column + audit) Performance: - IP-correlation subquery: add 6-month window + LIMIT 200 - getUserSessions: clamp limit to 500 Non-blocking: - Palette-aware colors in report_utils.cpp (dark/light mode) - Report list pagination: offset/limit fields + total_count in response - SessionCommand enum gap comment for reserved values 1201-1203 Schema: 36→37 (force_password_change), 37→38 (resolved_by) Took 12 minutes Took 16 seconds * Fix macOs pedantry Took 5 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
286 lines
13 KiB
C++
286 lines
13 KiB
C++
/***************************************************************************
|
|
* Copyright (C) 2008 by Max-Wilhelm Bruker *
|
|
* brukie@laptop *
|
|
* *
|
|
* This program is free software; you can redistribute it and/or modify *
|
|
* it under the terms of the GNU General Public License as published by *
|
|
* the Free Software Foundation; either version 2 of the License, or *
|
|
* (at your option) any later version. *
|
|
* *
|
|
* This program is distributed in the hope that it will be useful, *
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
|
|
* GNU General Public License for more details. *
|
|
* *
|
|
* You should have received a copy of the GNU General Public License *
|
|
* along with this program; if not, write to the *
|
|
* Free Software Foundation, Inc., *
|
|
* 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *
|
|
***************************************************************************/
|
|
#ifndef SERVERSOCKETINTERFACE_H
|
|
#define SERVERSOCKETINTERFACE_H
|
|
|
|
#include <QHostAddress>
|
|
#include <QMutex>
|
|
#include <QTcpSocket>
|
|
#include <QWebSocket>
|
|
#include <libcockatrice/protocol/pb/command_replay_download_by_game_id.pb.h>
|
|
#include <libcockatrice/protocol/pb/command_report.pb.h>
|
|
#include <libcockatrice/protocol/pb/command_report_add_comment.pb.h>
|
|
#include <libcockatrice/protocol/pb/command_report_assign.pb.h>
|
|
#include <libcockatrice/protocol/pb/command_report_details.pb.h>
|
|
#include <libcockatrice/protocol/pb/command_report_list.pb.h>
|
|
#include <libcockatrice/protocol/pb/command_report_my_list.pb.h>
|
|
#include <libcockatrice/protocol/pb/command_report_resolve.pb.h>
|
|
#include <libcockatrice/protocol/pb/command_report_stats.pb.h>
|
|
#include <libcockatrice/protocol/pb/command_report_user_info.pb.h>
|
|
#include <server_protocolhandler.h>
|
|
|
|
class Servatrice;
|
|
class Servatrice_DatabaseInterface;
|
|
class DeckList;
|
|
class ServerInfo_DeckStorage_Folder;
|
|
|
|
class Command_AddToList;
|
|
class Command_RemoveFromList;
|
|
class Command_DeckList;
|
|
class Command_DeckNewDir;
|
|
class Command_DeckDelDir;
|
|
class Command_DeckDel;
|
|
class Command_DeckDownload;
|
|
class Command_DeckUpload;
|
|
class Command_ReplayList;
|
|
class Command_ReplayDownload;
|
|
class Command_ReplayModifyMatch;
|
|
class Command_ReplayDeleteMatch;
|
|
class Command_ReplayGetCode;
|
|
class Command_ReplaySubmitCode;
|
|
|
|
class Command_BanFromServer;
|
|
class Command_UpdateServerMessage;
|
|
class Command_ShutdownServer;
|
|
class Command_ReloadConfig;
|
|
class Command_ReplayDownloadByGameId;
|
|
|
|
class Command_AccountEdit;
|
|
class Command_AccountImage;
|
|
class Command_AccountPassword;
|
|
|
|
class AbstractServerSocketInterface : public Server_ProtocolHandler
|
|
{
|
|
Q_OBJECT
|
|
protected slots:
|
|
void catchSocketError(QAbstractSocket::SocketError socketError);
|
|
void catchSocketDisconnected();
|
|
virtual void flushOutputQueue() = 0;
|
|
signals:
|
|
void outputQueueChanged();
|
|
void incTxBytes(qint64 amount);
|
|
|
|
protected:
|
|
void logDebugMessage(const QString &message) override;
|
|
bool tooManyRegistrationAttempts(const QString &ipAddress);
|
|
|
|
virtual void writeToSocket(QByteArray &data) = 0;
|
|
virtual void flushSocket() = 0;
|
|
|
|
Servatrice *servatrice;
|
|
QList<ServerMessage> outputQueue;
|
|
QMutex outputQueueMutex;
|
|
|
|
private:
|
|
Servatrice_DatabaseInterface *sqlInterface;
|
|
|
|
Response::ResponseCode cmdAddToList(const Command_AddToList &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdRemoveFromList(const Command_RemoveFromList &cmd, ResponseContainer &rc);
|
|
int getDeckPathId(int basePathId, QStringList path);
|
|
int getDeckPathId(const QString &path);
|
|
bool deckListHelper(int folderId, ServerInfo_DeckStorage_Folder *folder);
|
|
Response::ResponseCode cmdDeckList(const Command_DeckList &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdDeckNewDir(const Command_DeckNewDir &cmd, ResponseContainer &rc);
|
|
void deckDelDirHelper(int basePathId);
|
|
void sendServerMessage(const QString userName, const QString message);
|
|
Response::ResponseCode cmdDeckDelDir(const Command_DeckDelDir &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdDeckDel(const Command_DeckDel &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdDeckUpload(const Command_DeckUpload &cmd, ResponseContainer &rc);
|
|
DeckList *getDeckFromDatabase(int deckId);
|
|
Response::ResponseCode cmdDeckDownload(const Command_DeckDownload &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdReplayList(const Command_ReplayList &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdReplayDownload(const Command_ReplayDownload &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdReplayModifyMatch(const Command_ReplayModifyMatch &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdReplayDeleteMatch(const Command_ReplayDeleteMatch &cmd, ResponseContainer &rc);
|
|
QString createHashForReplay(int gameId);
|
|
Response::ResponseCode cmdReplayGetCode(const Command_ReplayGetCode &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdReplaySubmitCode(const Command_ReplaySubmitCode &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdBanFromServer(const Command_BanFromServer &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdReportList(const Command_ReportList &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdWarnUser(const Command_WarnUser &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdGetLogHistory(const Command_ViewLogHistory &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdGetBanHistory(const Command_GetBanHistory &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdGetWarnList(const Command_GetWarnList &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdGetWarnHistory(const Command_GetWarnHistory &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdShutdownServer(const Command_ShutdownServer &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdUpdateServerMessage(const Command_UpdateServerMessage &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdReportAssign(const Command_ReportAssign &cmd, ResponseContainer &);
|
|
Response::ResponseCode cmdReportResolve(const Command_ReportResolve &cmd, ResponseContainer &);
|
|
Response::ResponseCode cmdReportUserInfo(const Command_ReportUserInfo &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdReportStats(const Command_ReportStats &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdRegisterAccount(const Command_Register &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdActivateAccount(const Command_Activate &cmd, ResponseContainer & /* rc */);
|
|
Response::ResponseCode cmdReloadConfig(const Command_ReloadConfig & /* cmd */, ResponseContainer & /*rc*/);
|
|
Response::ResponseCode cmdAdjustMod(const Command_AdjustMod &cmd, ResponseContainer & /*rc*/);
|
|
Response::ResponseCode cmdForgotPasswordRequest(const Command_ForgotPasswordRequest &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode continuePasswordRequest(const QString &userName,
|
|
const QString &clientId,
|
|
ResponseContainer &rc,
|
|
bool challenged = false);
|
|
Response::ResponseCode cmdForgotPasswordReset(const Command_ForgotPasswordReset &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdForgotPasswordChallenge(const Command_ForgotPasswordChallenge &cmd,
|
|
ResponseContainer &rc);
|
|
Response::ResponseCode cmdRequestPasswordSalt(const Command_RequestPasswordSalt &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdReport(const Command_Report &cmd, ResponseContainer &);
|
|
Response::ResponseCode cmdReportMyList(const Command_ReportMyList &cmd, ResponseContainer &rc);
|
|
void sendPendingReportNotifications(ResponseContainer &rc);
|
|
void onLogin(ResponseContainer &rc) override;
|
|
Response::ResponseCode cmdReportDetails(const Command_ReportDetails &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdReportAddComment(const Command_ReportAddComment &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdReplayDownloadByGameId(const Command_ReplayDownloadByGameId &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode
|
|
processExtendedSessionCommand(int cmdType, const SessionCommand &cmd, ResponseContainer &rc) override;
|
|
Response::ResponseCode
|
|
processExtendedModeratorCommand(int cmdType, const ModeratorCommand &cmd, ResponseContainer &rc) override;
|
|
Response::ResponseCode
|
|
processExtendedAdminCommand(int cmdType, const AdminCommand &cmd, ResponseContainer &rc) override;
|
|
|
|
Response::ResponseCode cmdAccountEdit(const Command_AccountEdit &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdAccountImage(const Command_AccountImage &cmd, ResponseContainer &rc);
|
|
bool isCardNameAllowed(const QString &cardName, const QString &cardProviderId);
|
|
Response::ResponseCode cmdSetCardArtParams(const Command_SetCardArtParams &cmd, ResponseContainer &);
|
|
Response::ResponseCode cmdAddCardArtRule(const Command_AddCardArtRule &cmd, ResponseContainer &);
|
|
Response::ResponseCode cmdRemoveCardArtRule(const Command_RemoveCardArtRule &cmd, ResponseContainer &);
|
|
Response::ResponseCode cmdListCardArtRules(const Command_ListCardArtRules &, ResponseContainer &rc);
|
|
Response::ResponseCode cmdAccountPassword(const Command_AccountPassword &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdGrantReplayAccess(const Command_GrantReplayAccess &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdForceActivateUser(const Command_ForceActivateUser &cmd, ResponseContainer &rc);
|
|
|
|
Response::ResponseCode cmdGetAdminNotes(const Command_GetAdminNotes &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdUpdateAdminNotes(const Command_UpdateAdminNotes &cmd, ResponseContainer &rc);
|
|
|
|
Response::ResponseCode cmdGetUserSessions(const Command_GetUserSessions &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdGetUserAlts(const Command_GetUserAlts &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdGetModeratorLastLogins(const Command_GetModeratorLastLogins &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdResetUserPassword(const Command_ResetUserPassword &cmd, ResponseContainer &rc);
|
|
Response::ResponseCode cmdRemoveUserAvatar(const Command_RemoveUserAvatar &cmd, ResponseContainer &rc);
|
|
|
|
bool addAdminFlagToUser(const QString &user, int flag);
|
|
bool removeAdminFlagFromUser(const QString &user, int flag);
|
|
|
|
bool isPasswordLongEnough(const int passwordLength);
|
|
void removeSaidMessages(const QString &userName, int amount);
|
|
|
|
public:
|
|
AbstractServerSocketInterface(Servatrice *_server,
|
|
Servatrice_DatabaseInterface *_databaseInterface,
|
|
QObject *parent = 0);
|
|
~AbstractServerSocketInterface()
|
|
{
|
|
}
|
|
bool initSession();
|
|
|
|
virtual QHostAddress getPeerAddress() const = 0;
|
|
QString getAddress() const override = 0;
|
|
|
|
void transmitProtocolItem(const ServerMessage &item) override;
|
|
};
|
|
|
|
class TcpServerSocketInterface : public AbstractServerSocketInterface
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
TcpServerSocketInterface(Servatrice *_server,
|
|
Servatrice_DatabaseInterface *_databaseInterface,
|
|
QObject *parent = 0);
|
|
~TcpServerSocketInterface();
|
|
|
|
QHostAddress getPeerAddress() const
|
|
{
|
|
return socket->peerAddress();
|
|
}
|
|
QString getAddress() const
|
|
{
|
|
return socket->peerAddress().toString();
|
|
}
|
|
QString getConnectionType() const
|
|
{
|
|
return "tcp";
|
|
}
|
|
|
|
private:
|
|
QTcpSocket *socket;
|
|
QByteArray inputBuffer;
|
|
bool messageInProgress;
|
|
bool handshakeStarted;
|
|
int messageLength;
|
|
|
|
protected:
|
|
void writeToSocket(QByteArray &data)
|
|
{
|
|
socket->write(data);
|
|
}
|
|
void flushSocket()
|
|
{
|
|
socket->flush();
|
|
}
|
|
void initSessionDeprecated();
|
|
bool initTcpSession();
|
|
protected slots:
|
|
void readClient();
|
|
void flushOutputQueue();
|
|
public slots:
|
|
void initConnection(int socketDescriptor);
|
|
};
|
|
|
|
class WebsocketServerSocketInterface : public AbstractServerSocketInterface
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
WebsocketServerSocketInterface(Servatrice *_server,
|
|
Servatrice_DatabaseInterface *_databaseInterface,
|
|
QObject *parent = nullptr);
|
|
~WebsocketServerSocketInterface();
|
|
|
|
QHostAddress getPeerAddress() const
|
|
{
|
|
return address;
|
|
}
|
|
QString getAddress() const
|
|
{
|
|
return address.toString();
|
|
}
|
|
QString getConnectionType() const
|
|
{
|
|
return "websocket";
|
|
}
|
|
|
|
private:
|
|
QWebSocket *socket;
|
|
QHostAddress address;
|
|
|
|
protected:
|
|
void writeToSocket(QByteArray &data)
|
|
{
|
|
socket->sendBinaryMessage(data);
|
|
}
|
|
void flushSocket()
|
|
{
|
|
socket->flush();
|
|
}
|
|
bool initWebsocketSession();
|
|
protected slots:
|
|
void binaryMessageReceived(const QByteArray &message);
|
|
void flushOutputQueue();
|
|
public slots:
|
|
void initConnection(void *_socket);
|
|
};
|
|
|
|
#endif
|