mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-11-07 10:33:24 -08:00
d9cd308a2e
Limited deck views (view top/bottom N cards, scry, surveil) made it ambiguous which card was the top or bottom of the library. Label the card itself with a small in-view marker instead of placing text above or below the whole zone, which became ambiguous once the grid used several columns or the window was resized. The marker stays on the part of its card that the column leaves visible: for a top view, the right end of the exposed strip of the first card; for a bottom view, the bottom-left corner of the last, fully visible card. The view logic now answers whether it is a limited library-end view and which edge it shows. The graphics zone draws and positions a marker on the first or last displayed card, and re-translates its tooltip with the rest of the zone view. Co-authored-by: Lukas Brübach <44814898+BruebachL@users.noreply.github.com>
135 lines
4.8 KiB
C++
135 lines
4.8 KiB
C++
#include "gtest/gtest.h"
|
|
#include <QSignalSpy>
|
|
#include <QString>
|
|
#include <libcockatrice/game/board/card_state.h>
|
|
#include <libcockatrice/game/zones/hand_zone_logic.h>
|
|
#include <libcockatrice/game/zones/view_zone_logic.h>
|
|
#include <libcockatrice/utility/card_ref.h>
|
|
#include <libcockatrice/utility/zone_names.h>
|
|
|
|
namespace
|
|
{
|
|
|
|
CardRef cardRefFor(const QString &name)
|
|
{
|
|
CardRef cardRef;
|
|
cardRef.name = name;
|
|
return cardRef;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
TEST(CardZoneLogicTest, AddsAndTakesCardsWithoutAGraphicsSide)
|
|
{
|
|
HandZoneLogic zone(nullptr, QStringLiteral("hand"), false, false, true);
|
|
CardState card(nullptr, nullptr, cardRefFor(QStringLiteral("Lightning Bolt")), 7);
|
|
|
|
QSignalSpy cardAddedSpy(&zone, &CardZoneLogic::cardAdded);
|
|
QSignalSpy cardCountSpy(&zone, &CardZoneLogic::cardCountChanged);
|
|
|
|
zone.addCard(&card, false, 0);
|
|
|
|
ASSERT_EQ(zone.getCards().size(), 1);
|
|
EXPECT_EQ(zone.getCards().first(), &card);
|
|
EXPECT_EQ(card.getZone(), &zone);
|
|
EXPECT_EQ(cardAddedSpy.count(), 1);
|
|
EXPECT_GE(cardCountSpy.count(), 1);
|
|
|
|
EXPECT_EQ(zone.takeCard(0, 7), &card);
|
|
EXPECT_TRUE(zone.getCards().isEmpty());
|
|
EXPECT_EQ(card.getId(), 7);
|
|
}
|
|
|
|
TEST(CardZoneLogicTest, AsksTheGraphicsSideToCreateCards)
|
|
{
|
|
HandZoneLogic zone(nullptr, QStringLiteral("library"), false, true, true);
|
|
// The graphics side owns the view logic and registers it on the zone it
|
|
// shows; adding a card then goes through prepareAddCard and the request
|
|
// signal instead of the test emitting the signal itself.
|
|
ZoneViewZoneLogic view(nullptr, &zone, 1, true, false, false);
|
|
zone.getViews().append(&view);
|
|
|
|
QSignalSpy requestSpy(&view, &CardZoneLogic::createCardRequested);
|
|
|
|
CardState card(nullptr, nullptr, cardRefFor(QStringLiteral("Lightning Bolt")), 7);
|
|
zone.addCard(&card, true, 0, 0);
|
|
|
|
ASSERT_EQ(requestSpy.count(), 1);
|
|
const QList<QVariant> arguments = requestSpy.takeFirst();
|
|
const ServerInfo_Card cardInfo = arguments.at(0).value<ServerInfo_Card>();
|
|
EXPECT_EQ(cardInfo.id(), 7);
|
|
EXPECT_EQ(cardInfo.name(), "Lightning Bolt");
|
|
EXPECT_TRUE(arguments.at(1).toBool());
|
|
EXPECT_EQ(card.getZone(), &zone);
|
|
EXPECT_EQ(zone.getCards().size(), 1);
|
|
}
|
|
|
|
TEST(CardZoneLogicTest, MoveBetweenZonesUpdatesCardZone)
|
|
{
|
|
HandZoneLogic first(nullptr, QStringLiteral("hand"), false, false, true);
|
|
HandZoneLogic second(nullptr, QStringLiteral("grave"), false, false, true);
|
|
CardState card(nullptr, nullptr, cardRefFor(QStringLiteral("Cat")), 7);
|
|
|
|
first.addCard(&card, false, 0);
|
|
ASSERT_EQ(first.getCards().size(), 1);
|
|
|
|
CardState *taken = first.takeCard(0, 7);
|
|
ASSERT_EQ(taken, &card);
|
|
EXPECT_TRUE(first.getCards().isEmpty());
|
|
|
|
second.addCard(taken, false, 0);
|
|
EXPECT_EQ(second.getCards().size(), 1);
|
|
EXPECT_EQ(card.getZone(), &second);
|
|
}
|
|
|
|
TEST(CardZoneLogicTest, GetCardFindsById)
|
|
{
|
|
HandZoneLogic zone(nullptr, QStringLiteral("hand"), false, false, true);
|
|
CardState first(nullptr, nullptr, cardRefFor(QStringLiteral("Cat")), 7);
|
|
CardState second(nullptr, nullptr, cardRefFor(QStringLiteral("Dog")), 8);
|
|
|
|
zone.addCard(&first, false, 0);
|
|
zone.addCard(&second, false, 0);
|
|
|
|
EXPECT_EQ(zone.getCard(7), &first);
|
|
EXPECT_EQ(zone.getCard(8), &second);
|
|
EXPECT_EQ(zone.getCard(99), nullptr);
|
|
}
|
|
|
|
TEST(CardZoneLogicTest, ReorganizeSignalFiresOnAdd)
|
|
{
|
|
HandZoneLogic zone(nullptr, QStringLiteral("hand"), false, false, true);
|
|
CardState card(nullptr, nullptr, cardRefFor(QStringLiteral("Cat")), 7);
|
|
QSignalSpy reorganizeSpy(&zone, &CardZoneLogic::reorganizeCards);
|
|
|
|
zone.addCard(&card, true, 0);
|
|
|
|
EXPECT_EQ(reorganizeSpy.count(), 1);
|
|
}
|
|
|
|
TEST(CardZoneLogicTest, LibraryEdgeViewIsLimitedToOneEndOfTheLibrary)
|
|
{
|
|
HandZoneLogic deck(nullptr, QString::fromLatin1(ZoneNames::DECK), false, true, true);
|
|
HandZoneLogic grave(nullptr, QString::fromLatin1(ZoneNames::GRAVE), false, true, true);
|
|
|
|
ZoneViewZoneLogic fullDeckView(nullptr, &deck, -1, false, false, false);
|
|
EXPECT_FALSE(fullDeckView.isLibraryEdgeView());
|
|
EXPECT_FALSE(fullDeckView.showsTopOfLibrary());
|
|
EXPECT_FALSE(fullDeckView.showsBottomOfLibrary());
|
|
|
|
ZoneViewZoneLogic emptyDeckView(nullptr, &deck, 0, false, false, false);
|
|
EXPECT_FALSE(emptyDeckView.isLibraryEdgeView());
|
|
|
|
ZoneViewZoneLogic topView(nullptr, &deck, 3, false, false, false);
|
|
EXPECT_TRUE(topView.isLibraryEdgeView());
|
|
EXPECT_TRUE(topView.showsTopOfLibrary());
|
|
EXPECT_FALSE(topView.showsBottomOfLibrary());
|
|
|
|
ZoneViewZoneLogic bottomView(nullptr, &deck, 3, false, false, true);
|
|
EXPECT_TRUE(bottomView.isLibraryEdgeView());
|
|
EXPECT_FALSE(bottomView.showsTopOfLibrary());
|
|
EXPECT_TRUE(bottomView.showsBottomOfLibrary());
|
|
|
|
ZoneViewZoneLogic graveView(nullptr, &grave, 3, false, false, false);
|
|
EXPECT_FALSE(graveView.isLibraryEdgeView());
|
|
}
|