mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-06-14 01:54:47 -07:00
371b74732e
Adds OS-level URL-scheme handlers so users can click a link in a browser,
chat client, or third-party tool to launch Cockatrice straight into a
server / game / Oracle update.
Supported URL forms:
cockatrice://joingame?hostname=H&port=P&roomid=R&gameid=G[&spectate=1]
cockatrice-oracle://update[?spoilers=1]
Credentials passed via URL (username/password query params) are deliberately
ignored — URLs leak through shell history, browser history, EDR capture, etc.
If the target server requires auth and no saved credentials match, the Connect
dialog opens pre-filled with the URL's host/port so the user types their
password locally.
OS integration
- Linux: MimeType=x-scheme-handler/cockatrice (and -oracle) added to the
.desktop files; Exec=cockatrice %u passes the URL through.
- Windows: NSIS installer writes HKCR\cockatrice and HKCR\cockatrice-oracle
registry entries; uninstaller removes them.
- macOS: per-app Info.cockatrice.plist / Info.oracle.plist declare
CFBundleURLTypes; a QFileOpenEvent filter is installed on QApplication
before any nested event loop so cold-start URLs aren't lost.
New abstractions
- Intent (libcockatrice_utility/libcockatrice/utility/intent.h): abstract base
for chained async actions. Guarantees finished() fires at most once,
execute() is idempotent, self-deletes via deleteLater, and
startTimeoutSafetyNet() arms a configurable per-stage deadline. Concrete
intents (IntentConnectToServer, IntentLogin, IntentJoinServerRoom,
IntentJoinServerGame) compose the joingame flow via UrlParser.
- SingleInstanceManager: async per-user local-socket primary/secondary
handshake; URL forwarded from secondary to primary with QDataStream framing
both ways. shared_ptr-backed resolved flag survives every lambda capture.
- UrlSchemeEventFilter (new libcockatrice_utility_gui sibling library): QObject
event filter that translates macOS QFileOpenEvent into a urlReceived(QString)
signal. Lives in its own Gui-bearing lib so libcockatrice_utility stays
Core+Network only and doesn't drag Qt::Gui into servatrice.
- UrlUtils (header-only): pure URL parsing, fully unit-tested.
Wiring
- MainWindow::handleUrl(QString) — single entry point for any URL source.
- DlgConnect::prefillNewHost(host, port) — pre-fills new-host inputs.
- ServersSettings::findSavedCredsByHostPort — case-insensitive saved-creds
lookup.
- TabSupervisor::requestJoinRoom + roomJoinedById / roomJoinFailedById signals,
TabServer::roomAlreadyJoined for the short-circuit "already in this room"
path — single source of truth for duplicate-join handling.
Tests
- 36 new unit tests across four single-purpose targets in tests/:
- url_utils_test (22 tests) — scheme matching, port/room/game validation,
spectator flag, credentials ignored, case-insensitivity.
- url_scheme_event_filter_test (3 tests) — QFileOpenEvent capture.
- intent_test (7 tests) — self-delete, abort propagation, parent-destruction-
mid-flight, finish-once gate, execute() idempotence.
- single_instance_manager_test (4 tests) — per-user socket naming, becoming-
primary alone, forwarding to an existing primary, single-emission of
roleResolved.
Build tooling (incidental)
- Dockerfile.format, docker-compose.format.yml, Makefile — a docker-based
runner for format.sh that mirrors CI's desktop-lint step.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
41 lines
1.2 KiB
C++
41 lines
1.2 KiB
C++
#ifndef INTENT_JOIN_SERVER_GAME_H
|
|
#define INTENT_JOIN_SERVER_GAME_H
|
|
|
|
#include "contexts/context_join_game.h"
|
|
|
|
#include <libcockatrice/utility/intent.h>
|
|
|
|
class TabSupervisor;
|
|
class ConnectionController;
|
|
|
|
/**
|
|
* @brief Sends a Command_JoinGame for the given context and emits finished()
|
|
* based on the server response.
|
|
*
|
|
* Mirrors GameSelector::joinGame: short-circuits if the user already has a
|
|
* tab for the target game, sets override_restrictions when the user is not
|
|
* admin-locked, and passes through the spectator flag. Password and
|
|
* join_as_judge are intentionally not exposed via URL.
|
|
*
|
|
* Aborts (finished(false)) on manual disconnect or after a 30-second timeout,
|
|
* so the chain never hangs indefinitely.
|
|
*/
|
|
class IntentJoinServerGame : public Intent
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
explicit IntentJoinServerGame(const ContextJoinGame &ctx,
|
|
TabSupervisor *supervisor,
|
|
ConnectionController *controller,
|
|
QObject *parent = nullptr);
|
|
|
|
protected:
|
|
void doExecute() override;
|
|
|
|
private:
|
|
ContextJoinGame ctx;
|
|
TabSupervisor *supervisor;
|
|
ConnectionController *controller;
|
|
};
|
|
|
|
#endif // INTENT_JOIN_SERVER_GAME_H
|