Cockatrice/cockatrice/src/interface/widgets/tabs
BruebachL 4ce2e8c3d3
[UserList] Fix join/spectate from the profile hover card doing nothing (#7383)
The games list in the profile hover card offered "Join game" and
"Spectate", but UserInfoPopup::joinGameRequested was only forwarded to an
identical UserListWidget::joinGameRequested signal that nothing connected
to. Clicking either entry sent no command, opened no tab and showed no
error.

Route the request to TabSupervisor, which owns the join flow. The popup's
games list spans every room the user is in, so the target room may not be
open yet; IntentJoinServerGame already joins the room first and retries,
which is why this goes through the intent rather than straight to
GameSelector.

Extract the intent construction that joinReportGame already had into a
shared joinGameByIntent helper instead of duplicating it.

Also stop disabling "Join game" for games that are full or already
running. GameSelector::joinGame() offers to join as a spectator in that
case, so a greyed-out entry read as a dead button; GameSelector's own
context menu never disables it either.

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-10-02 18:57:07 +02:00
..
api [Accessibility] Bind card size sliders to Ctrl + Scroll (#7338) 2026-09-23 21:03:34 +02:00
visual_deck_editor [Client] Expose custom zone management in the deck editor (#7205) 2026-09-05 22:00:21 +02:00
visual_deck_storage [DeckShare] Browse and open public decks with loading, error and accessibility states (#7245) 2026-09-20 20:22:17 +02:00
abstract_tab_deck_editor.cpp [DeckShare] Browse and open public decks with loading, error and accessibility states (#7245) 2026-09-20 20:22:17 +02:00
abstract_tab_deck_editor.h [DeckShare] Create temporary share links for local and server decks (#7243) 2026-09-20 20:22:16 +02:00
tab.cpp [Move refactor] Move tabs to interface/widgets (#6235) 2025-10-09 14:51:47 +02:00
tab.h [Client] Route cockatrice:// link clicks from chat to the intent chain (#7136) 2026-08-17 01:03:37 +02:00
tab_account.cpp [Client] Explain the buddy and ignore lists in the user tab (#2072) (#7258) 2026-09-07 02:29:17 +02:00
tab_account.h [Server/Client/Protocol] Reporting users + moderation queue functionality (#7091) 2026-08-21 15:00:13 +02:00
tab_admin.cpp Split trice_limits.h into dedicated headers (#7025) 2026-06-29 14:37:52 -07:00
tab_admin.h Standardize Doxygen documentation (#6885) 2026-05-21 22:58:07 +02:00
tab_card_art_rules.cpp [CardSearch] Add card completion popups to chats and search fields (#7089) 2026-08-11 18:50:30 +02:00
tab_card_art_rules.h [UserListDelegate] Consider providerId (#7018) 2026-06-27 11:23:55 -04:00
tab_deck_editor.cpp [Settings] Split cache_settings monolith into multiple SettingsManager sub-classes (#7050) 2026-07-27 11:25:39 +02:00
tab_deck_editor.h [TabDeckEditor] Refactor: pull up showPrintingSelector (#6964) 2026-06-03 09:35:48 -07:00
tab_deck_storage.cpp [Client/Server] Keep non-deck files out of the deck storage (#7352) 2026-09-27 21:32:49 +02:00
tab_deck_storage.h [DeckShare] Browse and open public decks with loading, error and accessibility states (#7245) 2026-09-20 20:22:17 +02:00
tab_developer.cpp [Client/Server/Protocol] Surface live metrics in the Developer tab (#7212) 2026-09-11 17:18:56 +02:00
tab_developer.h [Client/Server/Protocol] Surface live metrics in the Developer tab (#7212) 2026-09-11 17:18:56 +02:00
tab_game.cpp [Replay] Fix cards accumulating in zone view when rewinding (#7357) 2026-10-02 17:17:34 +02:00
tab_game.h [Replay] Fix cards accumulating in zone view when rewinding (#7357) 2026-10-02 17:17:34 +02:00
tab_home.cpp [Cleanup] Unused #includes (#6367) 2025-11-29 18:53:11 +01:00
tab_home.h Standardize Doxygen documentation (#6885) 2026-05-21 22:58:07 +02:00
tab_logs.cpp [Server/Client/Protocol] Add developer staff role (#7211) 2026-09-11 17:18:56 +02:00
tab_logs.h [Server/Client/Protocol] Add developer staff role (#7211) 2026-09-11 17:18:56 +02:00
tab_message.cpp [Client] Prevent contacting users on the ignore list (#7262) 2026-09-07 08:14:15 +02:00
tab_message.h [Game] Add an invite button to non-started and not full games (#7143) 2026-08-17 21:37:15 +02:00
tab_moderation.cpp [Server/Client/Protocol] Add developer staff role (#7211) 2026-09-11 17:18:56 +02:00
tab_moderation.h [Server/Client/Protocol] Reporting users + moderation queue functionality (#7091) 2026-08-21 15:00:13 +02:00
tab_public_decks.cpp [Accessibility] Bind card size sliders to Ctrl + Scroll (#7338) 2026-09-23 21:03:34 +02:00
tab_public_decks.h [DeckShare] Browse and open public decks with loading, error and accessibility states (#7245) 2026-09-20 20:22:17 +02:00
tab_replays.cpp [Client/Server] Keep non-deck files out of the deck storage (#7352) 2026-09-27 21:32:49 +02:00
tab_replays.h Standardize Doxygen documentation (#6885) 2026-05-21 22:58:07 +02:00
tab_report.cpp [Server/Client/Protocol] Reporting users + moderation queue functionality (#7091) 2026-08-21 15:00:13 +02:00
tab_report.h [Server/Client/Protocol] Reporting users + moderation queue functionality (#7091) 2026-08-21 15:00:13 +02:00
tab_room.cpp Migrate theme asset loads to scheme-variant resolution (#7209-2) (#7276) 2026-09-11 17:59:57 +02:00
tab_room.h [UserList] Unify friends/online/ignored list with section dividers and add search bar. (#7119) 2026-08-15 22:53:13 +02:00
tab_server.cpp [Client] Fix spurious server room join error (#7259) 2026-09-19 09:56:09 +02:00
tab_server.h [Client] Fix spurious server room join error (#7259) 2026-09-19 09:56:09 +02:00
tab_supervisor.cpp [UserList] Fix join/spectate from the profile hover card doing nothing (#7383) 2026-10-02 18:57:07 +02:00
tab_supervisor.h [UserList] Fix join/spectate from the profile hover card doing nothing (#7383) 2026-10-02 18:57:07 +02:00
tab_visual_database_display.cpp [TabDeckEditor] Refactor card database view into own class (#6967) 2026-06-05 10:20:46 -07:00
tab_visual_database_display.h [TabDeckEditor] Refactor card database view into own class (#6967) 2026-06-05 10:20:46 -07:00