Cockatrice/oracle/src
BruebachL a8a3fca8c9
Clean up inter-library dependencies with interfaces (#6280)
* Have CardDatabase::getPreferredPrintingInfo respect card provider ID overrides (pinned printings)

Took 13 minutes

Took 37 seconds

Took 10 seconds

Took 10 seconds

# Commit time for manual adjustment:
# Took 30 seconds

Took 15 seconds


Took 8 minutes

Took 21 seconds

* Move settings cache and settings card preference provider out of libcockatrice_settings and into cockatrice

Took 52 minutes

Took 9 minutes

Took 1 minute

* Temp cache.

Took 16 minutes

* Dependency Injection for SettingsCache

* Turn SettingsCache into a QSharedPointer.
* Implement interfaces for settings that need it

Took 2 hours 38 minutes

* Adjust oracle.

Took 5 minutes

* Move abstract/noop interfaces to libcockatrice_interfaces so they can be linked against independently.

Took 52 minutes

* Clean up some links.

Took 3 minutes

* Cleanup two includes.

Took 3 minutes

* More fixes.

Took 7 minutes

* More includes that slipped past.

Took 3 minutes

* Stop mocking and start injecting for tests.

Took 15 minutes

* I don't know why remote_client was including main.

Took 4 minutes

* Include.

Took 3 minutes

* Lint.

Took 2 minutes

* Don't use Qt pointers.

Took 1 hour 7 minutes

* Make parser use CardSettingsInterface

Took 13 minutes

* Also adjust constructor lol.

Took 8 minutes

* Lint.

Took 32 minutes

* Revert "Lint."

This reverts commit ecb596c39e.


Took 3 minutes

* Test.

Took 3 minutes

---------

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2025-11-08 22:19:40 +01:00
..
lzma [WIP] Basic mtgjsonv4 support (#3458) 2018-12-20 18:05:03 -05:00
qt-json replace foreach macro with standard for each loop (#5485) 2025-01-17 05:18:15 +00:00
zip make package on macos 13 (#4961) 2023-12-15 21:15:57 -05:00
main.cpp Clean up inter-library dependencies with interfaces (#6280) 2025-11-08 22:19:40 +01:00
main.h workaround for foreign card arts getting priority by default (#3652) 2019-03-12 10:12:31 +01:00
oracleimporter.cpp Clean up inter-library dependencies with interfaces (#6280) 2025-11-08 22:19:40 +01:00
oracleimporter.h Turn Card, Deck_List, Protocol, RNG, Network (Client, Server), Settings and Utility into libraries and remove cockatrice_common. (#6212) 2025-10-09 07:36:12 +02:00
oraclewizard.cpp Clean up inter-library dependencies with interfaces (#6280) 2025-11-08 22:19:40 +01:00
oraclewizard.h update format.sh (#6240) 2025-11-07 15:00:39 +01:00
pagetemplates.cpp Automatic Card Database Updates (#6004) 2025-06-29 22:21:52 -04:00
pagetemplates.h update format.sh (#6240) 2025-11-07 15:00:39 +01:00
parsehelpers.cpp Optimize cipt parsing by early returning (#5727) 2025-03-15 21:23:41 +00:00
parsehelpers.h Update cipt parsing (#5712) 2025-03-14 21:44:13 -04:00