Cockatrice/cockatrice/src/interface/widgets/utility/report_utils.cpp
BruebachL ed4eb1cb31
Some checks are pending
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 44 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 12 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Docker Image / amd64 & arm64 (push) Waiting to run
[Server/Client/Protocol] Reporting users + moderation queue functionality (#7091)
* [Server/Client/Protocol] Reporting users + moderation queue functionality

Took 6 minutes

Took 3 minutes

Took 8 seconds

Took 11 minutes

Took 12 minutes

Took 7 minutes

Took 15 seconds

Took 2 minutes

Took 1 minute


Took 30 seconds

Took 16 seconds

* CI Fix

Took 6 minutes

* CI Fix

Took 6 minutes

* [Protocol] Add moderation investigation commands

Adds the protocol layer for the moderation investigation suite:
- Command_GetUserSessions/GetUserAlts/GetModeratorLastLogins/ResetUserPassword/RemoveUserAvatar (1013-1017)
- Response extensions 1215-1219 with ServerInfo messages for sessions, alts, and staff logins
- last_login on Response_ReportUserInfo and warning_il on Response_WarnList

Took 2 minutes

* [Utility] Add warning categories parser with infraction levels

Parses the server's 'officialwarnings' setting (comma-separated, optional
'|IL' suffix) into WarningCategory structs so the client can display the
infraction level of each warning category. Includes GTest coverage.

* [Server] Add moderation investigation tools

Implements the server side of the moderation suite:
- getUserSessions/getUserAlts/getModeratorLastLogins/removeUserAvatar DB methods
- Handlers for all five new commands with audit records (PASSWORD_RESET,
  REMOVE_USER_AVATAR); password resets return a generated temporary password
- cmdGetWarnList now reports per-category infraction levels from the
  officialwarnings setting; cmdReportUserInfo reports last_login
- Update servatrice.ini.example with the warning taxonomy
- Password/avatar mutations report RespNameNotFound when the user does not exist

* [Client] Add moderation tab with investigate, password reset, and avatar removal

- New Moderation tab: search a user to show account info, alternate
  accounts, login sessions, and staff last logins; actions to reset the
  user's password (shows the generated temporary password) and remove the
  user's avatar
- 'Investigate user' entry in the user context menu opens the tab pre-loaded
  for that user
- Warning dialog shows the infraction level of each warning category
- Tab wired into TabSupervisor with a moderator-gated menu action, shortcut,
  and tabs.ini persistence (default closed)

* [Server/Client/Protocol] Address PR #7091 review: security, bug, and perf fixes

Security:
- Promote RESET_USER_PASSWORD to admin-only dispatch (was moderator-accessible)
- Reject password reset on users with equal/higher privilege than caller
- Notify affected user via Event_NotifyUser::CUSTOM when password is reset
- Add server-side category whitelist for reports
- Drop reporter name fallback in comment/details authorization (ID-only)
- Force password change: new DB column + login enforcement + client disconnect

Bugs:
- XSS via QTextEdit::append() → insertPlainText() in report tab and utils
- allNotified initialized to true even with empty recipients list
- Warning combo box: use currentData() instead of baked-in display text
- Report resolution now records who resolved (resolved_by column + audit)

Performance:
- IP-correlation subquery: add 6-month window + LIMIT 200
- getUserSessions: clamp limit to 500

Non-blocking:
- Palette-aware colors in report_utils.cpp (dark/light mode)
- Report list pagination: offset/limit fields + total_count in response
- SessionCommand enum gap comment for reserved values 1201-1203

Schema: 36→37 (force_password_change), 37→38 (resolved_by)

Took 12 minutes


Took 16 seconds

* Fix macOs pedantry

Took 5 minutes

---------

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-08-21 15:00:13 +02:00

119 lines
4.1 KiB
C++

#include "report_utils.h"
#include <QApplication>
#include <QBrush>
#include <QDateTime>
#include <QPalette>
#include <QTableWidget>
#include <QTextCursor>
#include <QTextEdit>
namespace report_utils
{
namespace
{
QColor reportStatusColor(const QString &status)
{
const QColor text = qApp->palette().color(QPalette::Text);
const int luminance = (299 * text.red() + 587 * text.green() + 114 * text.blue()) / 1000;
const bool dark = luminance < 128;
if (status == "open") {
return dark ? QColor("#e06060") : QColor("#c0392b");
}
if (status == "assigned") {
return dark ? QColor("#e0a030") : QColor("#d68910");
}
if (status == "resolved") {
return dark ? QColor("#50c878") : QColor("#1e8449");
}
if (status == "dismissed") {
return qApp->palette().color(QPalette::PlaceholderText);
}
return QColor();
}
void setReportStatusItemColor(QTableWidgetItem *item, const QString &status)
{
const QColor color = reportStatusColor(status);
if (color.isValid()) {
item->setForeground(QBrush(color));
}
}
} // namespace
QString formatReportCategory(const QString &category)
{
QString result = category;
result.replace('_', ' ');
return result.left(1).toUpper() + result.mid(1);
}
QString formatReportTime(qint64 secondsSinceEpoch)
{
const QDateTime dt = QDateTime::fromSecsSinceEpoch(secondsSinceEpoch);
return dt.toString("yyyy-MM-dd hh:mm");
}
void fillReportTableRow(QTableWidget *table,
int row,
const ServerInfo_Report &report,
int idColumn,
int timeColumn,
int reportedColumn,
int categoryColumn,
int gameIdColumn,
int statusColumn,
int assignedColumn)
{
auto *idItem = new QTableWidgetItem(QString::number(report.report_id()));
idItem->setData(Qt::UserRole, report.report_id());
table->setItem(row, idColumn, idItem);
table->setItem(row, timeColumn, new QTableWidgetItem(formatReportTime(report.report_time())));
table->setItem(row, reportedColumn, new QTableWidgetItem(QString::fromStdString(report.reported_user_name())));
table->setItem(row, categoryColumn,
new QTableWidgetItem(formatReportCategory(QString::fromStdString(report.category()))));
table->setItem(row, gameIdColumn,
new QTableWidgetItem(report.game_id() > 0 ? QString::number(report.game_id()) : QString()));
auto *statusItem = new QTableWidgetItem(QString::fromStdString(report.status()));
setReportStatusItemColor(statusItem, QString::fromStdString(report.status()));
table->setItem(row, statusColumn, statusItem);
table->setItem(row, assignedColumn, new QTableWidgetItem(QString::fromStdString(report.assigned_mod_name())));
}
void renderReportDetails(QTextEdit *chatLogEdit,
QTextEdit *commentsEdit,
const ServerInfo_Report &report,
const QString &commentsEmptyText,
const QString &moderatorPrefix,
const QString &nonModeratorPrefix)
{
if (report.has_chat_log() && !report.chat_log().empty()) {
chatLogEdit->setPlainText(QString::fromStdString(report.chat_log()));
} else {
chatLogEdit->clear();
}
commentsEdit->clear();
if (report.comments_size() == 0) {
commentsEdit->setPlainText(commentsEmptyText);
return;
}
for (int i = 0; i < report.comments_size(); ++i) {
const ServerInfo_ReportComment &c = report.comments(i);
const QString author = QString::fromStdString(c.author_name());
const QString text = QString::fromStdString(c.comment_text());
const QString prefix = c.is_moderator() ? moderatorPrefix : nonModeratorPrefix;
commentsEdit->moveCursor(QTextCursor::End);
commentsEdit->insertPlainText(
QString("[%1] %2 %3:\n%4\n\n").arg(formatReportTime(c.comment_time()), prefix, author, text));
}
}
} // namespace report_utils