mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-07-04 12:33:55 -07:00
7aed233bd8
- Add addClamped() in new header clamped_arithmetic.h; uses a 64-bit intermediate so the addition cannot overflow int. - Use it in Server_Card::incrementCounter() (clamps [0, MAX_COUNTERS_ON_CARD]) and Server_Counter::incrementCount() (clamps [INT_MIN, INT_MAX]), removing the duplicated overflow-safe logic and its keep-in-sync TODO. - Inline incrementCount() into server_counter.h; server_counter.cpp now holds only the constructor and getInfo(). - Clarify the card-counter bounds comment in trice_limits.h.
43 lines
1.8 KiB
C++
43 lines
1.8 KiB
C++
#ifndef TRICE_LIMITS_H
|
|
#define TRICE_LIMITS_H
|
|
|
|
//! \todo Split trice_limits.h into focused single-purpose headers: string_limits.h,
|
|
//! dice_limits.h, counter_limits.h.
|
|
|
|
#include <QString>
|
|
|
|
// max size for short strings, like names and things that are generally a single phrase
|
|
constexpr int MAX_NAME_LENGTH = 0xff;
|
|
// max size for chat messages and text contents
|
|
constexpr int MAX_TEXT_LENGTH = 0xfff;
|
|
// max size for deck files and pictures
|
|
constexpr int MAX_FILE_LENGTH = 0x1fffff; // about 2 megabytes
|
|
|
|
constexpr uint MINIMUM_DIE_SIDES = 2;
|
|
constexpr uint MAXIMUM_DIE_SIDES = 1000000;
|
|
constexpr uint MINIMUM_DICE_TO_ROLL = 1;
|
|
constexpr uint MAXIMUM_DICE_TO_ROLL = 100;
|
|
|
|
// Card counter value bounds [0, MAX_COUNTERS_ON_CARD].
|
|
// This caps an individual counter's VALUE (e.g. a +1/+1 counter at 999), not how many counters a card holds.
|
|
// Applies to card counters only; player counters (Server_Counter) are unbounded and may go
|
|
// negative (e.g. life total), saturating only at the int range.
|
|
// The max of 999 is a display constraint (3-digit rendering) and reasonable gameplay limit.
|
|
// Server enforces these bounds; client may also check for UX optimization.
|
|
constexpr int MAX_COUNTERS_ON_CARD = 999;
|
|
|
|
// optimized functions to get qstrings that are at most that long
|
|
static inline QString nameFromStdString(const std::string &_string)
|
|
{
|
|
return QString::fromUtf8(_string.data(), std::min(int(_string.size()), MAX_NAME_LENGTH));
|
|
}
|
|
static inline QString textFromStdString(const std::string &_string)
|
|
{
|
|
return QString::fromUtf8(_string.data(), std::min(int(_string.size()), MAX_TEXT_LENGTH));
|
|
}
|
|
static inline QString fileFromStdString(const std::string &_string)
|
|
{
|
|
return QString::fromUtf8(_string.data(), std::min(int(_string.size()), MAX_FILE_LENGTH));
|
|
}
|
|
|
|
#endif // TRICE_LIMITS_H
|