mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-21 00:55:09 -07:00
7d04c50f2c
Picture downloads were throttled to a uniform 10 requests/second per host with no way to tune a specific server. A rate-limited API host (Scryfall caps at 10 req/s) can trip 429s during bursts, and CDN hosts with no rate limit were throttled needlessly. Introduce developer-owned per-host caps that users can only ever lower, never raise, exposed in the download settings page: - DownloadSettings::DEVELOPER_HOST_CAPS sets the ceiling per host (api.scryfall.com 9, cards.scryfall.io unlimited, others 10). - A new hostRequestLimits setting stores user overrides in downloads.ini; clampHostRequestLimit() bounds them to [1, devCap] so a user can reduce api.scryfall.com to 5 but never raise it above 9. - The picture worker seeds, halves on 429, and recovers its sustained per-host allowance against the effective ceiling instead of the global maximum, and skips per-host accounting entirely for unlocked hosts (cards.scryfall.io) while global pacing and 429 backoff still apply. - The deck editor settings page gains one spinbox per known host, each clamped to its developer cap.
112 lines
3.9 KiB
C++
112 lines
3.9 KiB
C++
#include "download_settings.h"
|
|
|
|
#include "settings_manager.h"
|
|
|
|
const QStringList DownloadSettings::DEFAULT_DOWNLOAD_URLS = {
|
|
"https://cards.scryfall.io/large/!prop:side!/!set:uuid_substr_0_1!/!set:uuid_substr_1_1!/!set:uuid!.jpg",
|
|
"https://api.scryfall.com/cards/!set:uuid!?format=image&face=!prop:side!&lang=!sflang!",
|
|
"https://api.scryfall.com/cards/multiverse/!set:muid!?format=image&lang=!sflang!",
|
|
"https://gatherer.wizards.com/Handlers/Image.ashx?multiverseid=!set:muid!&type=card",
|
|
"https://gatherer.wizards.com/Handlers/Image.ashx?name=!name!&type=card"};
|
|
|
|
const QString DownloadSettings::SCRYFALL_NAMED_LOCALIZED_URL =
|
|
"https://api.scryfall.com/cards/named?fuzzy=!localizedName!&lang=!sflang!&format=image&face=!prop:side!";
|
|
|
|
// Developer-set ceilings for the per-host request allowance. Users may lower a host's
|
|
// allowance via the download settings, but can never raise it above these values. Hosts
|
|
// not listed default to DEFAULT_HOST_REQUEST_LIMIT. A cap of UNLIMITED_HOST_QUOTA marks a
|
|
// host that is never throttled per host (request pacing and 429 backoff still apply).
|
|
const QHash<QString, int> DownloadSettings::DEVELOPER_HOST_CAPS = {
|
|
// The Scryfall API enforces 10 requests/second; stay one under so a burst can't trip 429s.
|
|
{"api.scryfall.com", 9},
|
|
// The Scryfall image CDN has no documented per-client rate limit.
|
|
{"cards.scryfall.io", UNLIMITED_HOST_QUOTA},
|
|
};
|
|
|
|
const QHash<QString, int> &DownloadSettings::getDeveloperHostCaps()
|
|
{
|
|
return DEVELOPER_HOST_CAPS;
|
|
}
|
|
|
|
DownloadSettings::DownloadSettings(const QString &settingPath, QObject *parent = nullptr)
|
|
: SettingsManager(settingPath + "downloads.ini", "downloads", QString(), parent)
|
|
{
|
|
}
|
|
|
|
void DownloadSettings::setDownloadUrls(const QStringList &downloadURLs)
|
|
{
|
|
setValue(QVariant::fromValue(downloadURLs), "urls");
|
|
}
|
|
|
|
QStringList DownloadSettings::getAllURLs() const
|
|
{
|
|
return getValue("urls").toStringList();
|
|
}
|
|
|
|
void DownloadSettings::resetToDefaultURLs()
|
|
{
|
|
setValue(QVariant::fromValue(DEFAULT_DOWNLOAD_URLS), "urls");
|
|
}
|
|
|
|
bool DownloadSettings::addLocalizedScryfallUrl()
|
|
{
|
|
const QStringList urls = getAllURLs();
|
|
if (urls.contains(SCRYFALL_NAMED_LOCALIZED_URL)) {
|
|
return false;
|
|
}
|
|
QStringList updated = urls;
|
|
updated.prepend(SCRYFALL_NAMED_LOCALIZED_URL);
|
|
setDownloadUrls(updated);
|
|
return true;
|
|
}
|
|
|
|
bool DownloadSettings::getPicDownload() const
|
|
{
|
|
return getValue("pictureDownload", QString(), QString(), true).toBool();
|
|
}
|
|
|
|
void DownloadSettings::setPicDownload(bool _picDownload)
|
|
{
|
|
setValue(_picDownload, "pictureDownload");
|
|
emit picDownloadChanged();
|
|
}
|
|
|
|
bool DownloadSettings::getDownloadSpoilersStatus() const
|
|
{
|
|
return getValue("downloadSpoilers", QString(), QString(), false).toBool();
|
|
}
|
|
|
|
void DownloadSettings::setDownloadSpoilerStatus(bool _spoilerStatus)
|
|
{
|
|
setValue(_spoilerStatus, "downloadSpoilers");
|
|
emit downloadSpoilerStatusChanged();
|
|
}
|
|
|
|
QHash<QString, int> DownloadSettings::getHostRequestLimits() const
|
|
{
|
|
const QVariantMap stored = getValue("hostRequestLimits").toMap();
|
|
QHash<QString, int> hostRequestLimits;
|
|
for (auto it = stored.cbegin(); it != stored.cend(); ++it) {
|
|
hostRequestLimits.insert(it.key(), it.value().toInt());
|
|
}
|
|
return hostRequestLimits;
|
|
}
|
|
|
|
void DownloadSettings::setHostRequestLimits(const QHash<QString, int> &hostRequestLimits)
|
|
{
|
|
QVariantMap stored;
|
|
for (auto it = hostRequestLimits.cbegin(); it != hostRequestLimits.cend(); ++it) {
|
|
stored.insert(it.key(), it.value());
|
|
}
|
|
setValue(stored, "hostRequestLimits");
|
|
emit hostRequestLimitsChanged();
|
|
}
|
|
|
|
int DownloadSettings::clampHostRequestLimit(const QString &host, int requested) const
|
|
{
|
|
const int devCap = DEVELOPER_HOST_CAPS.value(host, DEFAULT_HOST_REQUEST_LIMIT);
|
|
if (devCap == UNLIMITED_HOST_QUOTA) {
|
|
return qMax(MIN_HOST_REQUEST_LIMIT, requested);
|
|
}
|
|
return qBound(MIN_HOST_REQUEST_LIMIT, requested, devCap);
|
|
}
|