mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-25 02:43:02 -07:00
Some checks are pending
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 44 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 12 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Docker Image / amd64 & arm64 (push) Waiting to run
* [Server/Client/Protocol] Reporting users + moderation queue functionality Took 6 minutes Took 3 minutes Took 8 seconds Took 11 minutes Took 12 minutes Took 7 minutes Took 15 seconds Took 2 minutes Took 1 minute Took 30 seconds Took 16 seconds * CI Fix Took 6 minutes * CI Fix Took 6 minutes * [Protocol] Add moderation investigation commands Adds the protocol layer for the moderation investigation suite: - Command_GetUserSessions/GetUserAlts/GetModeratorLastLogins/ResetUserPassword/RemoveUserAvatar (1013-1017) - Response extensions 1215-1219 with ServerInfo messages for sessions, alts, and staff logins - last_login on Response_ReportUserInfo and warning_il on Response_WarnList Took 2 minutes * [Utility] Add warning categories parser with infraction levels Parses the server's 'officialwarnings' setting (comma-separated, optional '|IL' suffix) into WarningCategory structs so the client can display the infraction level of each warning category. Includes GTest coverage. * [Server] Add moderation investigation tools Implements the server side of the moderation suite: - getUserSessions/getUserAlts/getModeratorLastLogins/removeUserAvatar DB methods - Handlers for all five new commands with audit records (PASSWORD_RESET, REMOVE_USER_AVATAR); password resets return a generated temporary password - cmdGetWarnList now reports per-category infraction levels from the officialwarnings setting; cmdReportUserInfo reports last_login - Update servatrice.ini.example with the warning taxonomy - Password/avatar mutations report RespNameNotFound when the user does not exist * [Client] Add moderation tab with investigate, password reset, and avatar removal - New Moderation tab: search a user to show account info, alternate accounts, login sessions, and staff last logins; actions to reset the user's password (shows the generated temporary password) and remove the user's avatar - 'Investigate user' entry in the user context menu opens the tab pre-loaded for that user - Warning dialog shows the infraction level of each warning category - Tab wired into TabSupervisor with a moderator-gated menu action, shortcut, and tabs.ini persistence (default closed) * [Server/Client/Protocol] Address PR #7091 review: security, bug, and perf fixes Security: - Promote RESET_USER_PASSWORD to admin-only dispatch (was moderator-accessible) - Reject password reset on users with equal/higher privilege than caller - Notify affected user via Event_NotifyUser::CUSTOM when password is reset - Add server-side category whitelist for reports - Drop reporter name fallback in comment/details authorization (ID-only) - Force password change: new DB column + login enforcement + client disconnect Bugs: - XSS via QTextEdit::append() → insertPlainText() in report tab and utils - allNotified initialized to true even with empty recipients list - Warning combo box: use currentData() instead of baked-in display text - Report resolution now records who resolved (resolved_by column + audit) Performance: - IP-correlation subquery: add 6-month window + LIMIT 200 - getUserSessions: clamp limit to 500 Non-blocking: - Palette-aware colors in report_utils.cpp (dark/light mode) - Report list pagination: offset/limit fields + total_count in response - SessionCommand enum gap comment for reserved values 1201-1203 Schema: 36→37 (force_password_change), 37→38 (resolved_by) Took 12 minutes Took 16 seconds * Fix macOs pedantry Took 5 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
131 lines
4.6 KiB
C++
131 lines
4.6 KiB
C++
/**
|
|
* @file user_context_menu.h
|
|
* @ingroup Lobby
|
|
*/
|
|
//! \todo Document this file.
|
|
|
|
#ifndef USER_CONTEXT_MENU_H
|
|
#define USER_CONTEXT_MENU_H
|
|
|
|
#include "../../interface/widgets/server/game_link.h"
|
|
|
|
#include <QList>
|
|
#include <QObject>
|
|
#include <functional>
|
|
#include <libcockatrice/network/server/remote/user_level.h>
|
|
class AbstractGame;
|
|
class UserListProxy;
|
|
class AbstractClient;
|
|
class ChatView;
|
|
class CommandContainer;
|
|
class QAction;
|
|
class QMenu;
|
|
class QPoint;
|
|
class Response;
|
|
class ServerInfo_User;
|
|
class TabSupervisor;
|
|
|
|
class UserContextMenu : public QObject
|
|
{
|
|
Q_OBJECT
|
|
private:
|
|
AbstractClient *client;
|
|
TabSupervisor *tabSupervisor;
|
|
const UserListProxy *userListProxy;
|
|
AbstractGame *game;
|
|
|
|
QAction *aUserName;
|
|
QAction *aDetails;
|
|
QAction *aShowGames;
|
|
QAction *aChat;
|
|
QAction *aAddToBuddyList, *aRemoveFromBuddyList;
|
|
QAction *aAddToIgnoreList, *aRemoveFromIgnoreList;
|
|
QAction *aKick;
|
|
QAction *aReport;
|
|
QAction *aBan, *aBanHistory;
|
|
QAction *aPromoteToMod, *aDemoteFromMod;
|
|
QAction *aPromoteToJudge, *aDemoteFromJudge;
|
|
QAction *aWarnUser, *aWarnHistory;
|
|
QAction *aGetAdminNotes;
|
|
std::function<QList<GameInviteOption>()> gameInviteLinkProvider;
|
|
QAction *aInvestigateUser;
|
|
signals:
|
|
void openMessageDialog(const QString &userName, bool focus);
|
|
private slots:
|
|
void banUser_processUserInfoResponse(const Response &resp);
|
|
void warnUser_processGetWarningsListResponse(const Response &r);
|
|
void warnUser_processUserInfoResponse(const Response &resp);
|
|
void banUserHistory_processResponse(const Response &resp);
|
|
void warnUserHistory_processResponse(const Response &resp);
|
|
void getAdminNotes_processResponse(const Response &resp);
|
|
void adjustMod_processUserResponse(const Response &resp, const CommandContainer &commandContainer);
|
|
void banUser_dialogFinished();
|
|
void warnUser_dialogFinished();
|
|
void updateAdminNotes_dialogFinished();
|
|
void gamesOfUserReceived(const Response &resp, const CommandContainer &commandContainer);
|
|
|
|
public:
|
|
UserContextMenu(TabSupervisor *_tabSupervisor, QWidget *_parent, AbstractGame *_game = 0);
|
|
void retranslateUi();
|
|
void showContextMenu(const QPoint &pos,
|
|
const QString &userName,
|
|
UserLevelFlags userLevel,
|
|
bool online = true,
|
|
int playerId = -1);
|
|
void showContextMenu(const QPoint &pos, const QString &userName, UserLevelFlags userLevel, ChatView *chatView);
|
|
void showContextMenu(const QPoint &pos,
|
|
const QString &userName,
|
|
UserLevelFlags userLevel,
|
|
bool online,
|
|
int playerId,
|
|
const QString &deckHash,
|
|
ChatView *chatView = nullptr);
|
|
|
|
const UserListProxy *getUserListProxy() const
|
|
{
|
|
return userListProxy;
|
|
}
|
|
|
|
void setGameInviteLinkProvider(std::function<QList<GameInviteOption>()> provider)
|
|
{
|
|
gameInviteLinkProvider = std::move(provider);
|
|
}
|
|
|
|
/**
|
|
* The games currently inviteable for @p userName, honoring the room's
|
|
* buddy-only setting (the inviter must be the game's creator and the
|
|
* target a buddy of theirs). Empty when there is no live provider.
|
|
*/
|
|
QList<GameInviteOption> inviteOptionsForUser(const QString &userName) const;
|
|
|
|
/** Whether at least one invite link is currently available for @p userName. */
|
|
bool hasGameInviteLink(const QString &userName) const
|
|
{
|
|
return !inviteOptionsForUser(userName).isEmpty();
|
|
}
|
|
|
|
// Individual action entry points — used by UserInfoPopup to trigger
|
|
// actions without re-running the full context menu flow.
|
|
void execChat(const QString &userName);
|
|
void execInvite(const QString &userName);
|
|
void execDetails(const QString &userName);
|
|
void execShowGames(const QString &userName);
|
|
void execAddToBuddy(const QString &userName);
|
|
void execRemoveFromBuddy(const QString &userName);
|
|
void execAddToIgnore(const QString &userName);
|
|
void execRemoveFromIgnore(const QString &userName);
|
|
void execKick(int playerId);
|
|
void execBan(const QString &userName);
|
|
void execWarn(const QString &userName);
|
|
void execBanHistory(const QString &userName);
|
|
void execWarnHistory(const QString &userName);
|
|
void execAdminNotes(const QString &userName);
|
|
void execInvestigateUser(const QString &userName);
|
|
void execAdjustMod(const QString &userName, bool shouldBeMod);
|
|
void execAdjustJudge(const QString &userName, bool shouldBeJudge);
|
|
|
|
private:
|
|
void execInvite(const QString &userName, const GameInviteOption &option);
|
|
};
|
|
|
|
#endif
|