Cockatrice/libcockatrice_protocol/libcockatrice/protocol
Lukas Brübach b855b279a7 [Server] Record only the dispatched command family; drop unused totals
processCommandContainer recorded every family in a container even though
the base if/else-if dispatch processes at most one. An unauthenticated
client could batch a session command (login) with fabricated developer,
moderator, and admin entries and forge genuine-looking samples that were
never executed or authorized. Mirror the base's selection, skip when the
handler was already deleted, and skip entries whose extension number is
-1 (which would otherwise wrap into the previous kind's id range).

[Server] Drop dead process-lifetime byte/uptime counters

txBytesTotal/rxBytesTotal added an atomic RMW to every socket write and
read for counters nothing consumes (cmdGetServerStats fills tx_bytes,
rx_bytes, and uptime_secs from the DB snapshot). Remove the two atomics
and the getTxBytesTotal/getRxBytesTotal/getUptimeSeconds getters; the
incTxBytes/incRxBytes slots and mutexes remain for the ISL legacy
counters.

[Protocol] Document kind 5 as developer in CommandStats

NumKinds is 6 and the server emits kind_index = 5 for developer
commands; the comment stopped at 4.
2026-09-11 09:01:55 +02:00
..
pb [Server] Record only the dispatched command family; drop unused totals 2026-09-11 09:01:55 +02:00
debug_pb_message.cpp Split trice_limits.h into dedicated headers (#7025) 2026-06-29 14:37:52 -07:00
debug_pb_message.h Turn Card, Deck_List, Protocol, RNG, Network (Client, Server), Settings and Utility into libraries and remove cockatrice_common. (#6212) 2025-10-09 07:36:12 +02:00
featureset.cpp style: Add braces to all control flow statements (#6887) 2026-05-16 19:19:53 +02:00
featureset.h [Cleanup] Unused #includes (#6367) 2025-11-29 18:53:11 +01:00
get_pb_extension.cpp style: Add braces to all control flow statements (#6887) 2026-05-16 19:19:53 +02:00
get_pb_extension.h Turn Card, Deck_List, Protocol, RNG, Network (Client, Server), Settings and Utility into libraries and remove cockatrice_common. (#6212) 2025-10-09 07:36:12 +02:00
pending_command.cpp [Network] Measure real server round-trip times (#7153) 2026-08-23 00:03:52 +02:00
pending_command.h [Network] Measure real server round-trip times (#7153) 2026-08-23 00:03:52 +02:00