mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-21 00:55:09 -07:00
ef68a7bdcc
* [Card] Add a setting for the language used in card search Localized card names and texts can now be searched too, controlled by a 'Language used in card search' toggle (English, selected card language, or both) on the general settings page. Untranslated cards always keep matching in English. Removed the redundant local copy of the URL templates list in the localized picture loader while here. * [Card] Bind search language per FilterString instance The peg parser rules are set up once per process, so the GenericQuery and OracleQuery rule actions could not capture per-instance state. Instead of storing the search language in a process-global that FilterString instance methods mutate, hand it to the rule actions through a thread-local parse context and copy it into the filter closures they produce. Card evaluation in FilterString::check no longer reads any process-global state, and each instance keeps the language it was built with; constructing one instance no longer changes what unrelated instances (deck filter, drop-to-hand, zone views) match against. The card database display model stores the raw query and rebuilds the FilterString when the search language changes, since the language is now bound at parse time. Add tests for the English/Selected/Both search modes, the English fallback for untranslated cards, and per-instance language independence. * [Card] Pass the card search language to deck and zone card searches Wire the two remaining FilterString consumers to the configured card search language so card-name matches respect it everywhere: - DeckFilterString now takes the search language and mode, exposes them to its [[card name]] rule action via a thread-local parse context (same pattern as FilterString), and the engine's card database uses them for content search. - ZoneViewZone reads the card language from CardsDisplaySettings when applying its search filter, and the reveal-zone widget re-applies the active search when the language setting changes. - The deck-storage search re-runs its filter against the current card language setting, including live re-application when the setting changes. Game-action targeting (DlgMoveTopCardsUntil) intentionally keeps evaluating against English card names. * [Card] Rename CardSearchLanguage to SearchLanguageMode * [Card] Restore displaced namespace doc in card_localization.h * [Filters] Pass CardSearchLanguage as a single struct * [CardSearchModel] Match English and localized names in Both mode Card names are stored in both English and localized forms, so search for matches in both during the 'Both' search mode instead of checking only the localized name. * [CreateTokenDialog] Fetch cardsDisplay settings inside the apply lambda Avoid capturing the raw settings pointer in the lambda: resolve the card language and card search language from the settings cache at call time so the values are always current when the search language is re-applied. --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
100 lines
2.8 KiB
C++
100 lines
2.8 KiB
C++
#ifndef COCKATRICE_GENERAL_SETTINGS_PAGE_H
|
|
#define COCKATRICE_GENERAL_SETTINGS_PAGE_H
|
|
|
|
#include "abstract_settings_page.h"
|
|
|
|
#include <QCheckBox>
|
|
#include <QComboBox>
|
|
#include <QGroupBox>
|
|
#include <QLabel>
|
|
#include <QLoggingCategory>
|
|
#include <QPushButton>
|
|
#include <QSpinBox>
|
|
|
|
inline Q_LOGGING_CATEGORY(GeneralSettingsPageLog, "general_settings_page");
|
|
|
|
class GeneralSettingsPage : public AbstractSettingsPage
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
GeneralSettingsPage();
|
|
void retranslateUi() override;
|
|
|
|
static QStringList findQmFiles();
|
|
static QString languageName(const QString &lang);
|
|
|
|
signals:
|
|
/// Request to re-import the card database with the newly selected card language
|
|
void cardDatabaseUpdateRequested();
|
|
|
|
private slots:
|
|
void deckPathButtonClicked();
|
|
void filtersPathButtonClicked();
|
|
void replaysPathButtonClicked();
|
|
void picsPathButtonClicked();
|
|
void cardDatabasePathButtonClicked();
|
|
void customCardDatabaseButtonClicked();
|
|
void tokenDatabasePathButtonClicked();
|
|
void resetAllPathsClicked();
|
|
void languageBoxChanged(int index);
|
|
void cardLanguageBoxChanged(int index);
|
|
void cardSearchLanguageBoxChanged(int index);
|
|
void updateStartupServerControlsVisibility();
|
|
|
|
private:
|
|
QGroupBox *languageGroupBox;
|
|
QGroupBox *versionGroupBox;
|
|
QGroupBox *cardDatabaseGroupBox;
|
|
QGroupBox *startupGroupBox;
|
|
QGroupBox *pathsGroupBox;
|
|
|
|
QLabel languageLabel;
|
|
QComboBox languageBox;
|
|
QLabel advertiseTranslationPageLabel;
|
|
|
|
QLabel cardLanguageLabel;
|
|
QComboBox cardLanguageBox;
|
|
QLabel cardLanguageNoteLabel;
|
|
|
|
QLabel cardSearchLanguageLabel;
|
|
QComboBox cardSearchLanguageBox;
|
|
|
|
QLabel updateReleaseChannelLabel;
|
|
QComboBox updateReleaseChannelBox;
|
|
QCheckBox startupUpdateCheckCheckBox;
|
|
QCheckBox updateNotificationCheckBox;
|
|
QCheckBox newVersionOracleCheckBox;
|
|
|
|
QLabel startupCardUpdateCheckBehaviorLabel;
|
|
QComboBox startupCardUpdateCheckBehaviorSelector;
|
|
QLabel cardUpdateCheckIntervalLabel;
|
|
QSpinBox cardUpdateCheckIntervalSpinBox;
|
|
QLabel lastCardUpdateCheckDateLabel;
|
|
|
|
QCheckBox showTipsOnStartup;
|
|
QLabel startupTabLabel;
|
|
QComboBox startupTabSelector;
|
|
QLabel startupServerLabel;
|
|
QComboBox startupServerSelector;
|
|
QLabel startupRoomLabel;
|
|
QLineEdit *startupRoomNameEdit;
|
|
|
|
QLabel deckPathLabel;
|
|
QLabel filtersPathLabel;
|
|
QLabel replaysPathLabel;
|
|
QLabel picsPathLabel;
|
|
QLabel cardDatabasePathLabel;
|
|
QLabel customCardDatabasePathLabel;
|
|
QLabel tokenDatabasePathLabel;
|
|
QLineEdit *deckPathEdit;
|
|
QLineEdit *filtersPathEdit;
|
|
QLineEdit *replaysPathEdit;
|
|
QLineEdit *picsPathEdit;
|
|
QLineEdit *cardDatabasePathEdit;
|
|
QLineEdit *customCardDatabasePathEdit;
|
|
QLineEdit *tokenDatabasePathEdit;
|
|
QPushButton *resetAllPathsButton;
|
|
QLabel *allPathsResetLabel;
|
|
};
|
|
|
|
#endif // COCKATRICE_GENERAL_SETTINGS_PAGE_H
|