mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-24 10:23:02 -07:00
8ca749c07d
* [DeckShare] Open shared decks via links with a gated preview flow - Serialized url-chain dispatcher in IntentUrlParser; queue-drained urlChainFinished(bool) drives the startup auto-connect fallback - Open-shared-deck intent with sequential download state machine, 15s per-item timeout, partial-success offer, livable Cancel via ApplicationModal dlg_login_prompt interactive fallback - Preview dialog: download progress label, share vocab sweep, palette-highlight selection frame, Space/Enter keyboard toggle, NoFocus checkbox, double-click tile opens immediately - Confirm-before-server-migration with one-shot restore to the previous server on failed/cancelled chains (statusChanged settle deferral), hostname-only identity comparisons - Skip credential link when already connected; arrow-key navigation in FlowWidget; card glows use palette highlight - Address code-review M1-M4 and UI/UX QA blockers 1-2 * [DeckShare] End the open-shared-deck files with a trailing newline * [DeckShare] Forward a dependency's cancellation as the owner's own * [DeckShare] Let intent chains opt into the link sign-in dialog * [DeckShare] Track link-intent chains per-run so each can restore its own session * [Settings] Match a server on the exact host and port when adding it * [DeckShare] Confirm the share link's target server before opening a deck * [DeckShare] Reformat the link sign-in intent constructor * [DeckShare] Time the share-list round trip and backstop silently-destroyed intent chains * [Client] Drain a single-instance payload before its handlers read the socket again * [Client] Treat a busy single-instance primary as alive instead of stealing its socket * [DeckShare] Keep arrow-key navigation between flow items inside a scroll area * [Client] Skip the startup connection when a macOS URL launch owns the connection * [Client] Redact share secrets from activation URL logs * [Client] Make the link-connection gates port-aware and keyboard-safe Second-pass review notes for the shared-deck link flow (Cockatrice#7244): - FlowWidget arrow-key navigation is opt-in via addNavigableWidget, so combo/spin controls on the analytics flows keep their own arrow keys - isConnectedTo and the open-deck/join-game preconditions compare the configured server port alongside the host, so a same-host/different-port link cannot resolve its share token or game id on the wrong instance - the link sign-in dialog reuses an existing server entry's saved name instead of renaming it to the raw hostname - skipStartupAutoConnect is cleared once the launch chain connects, so a later mid-session declined link cannot fire the startup fallback - the plain-launch path of SingleInstanceManager no longer blocks on the primary's ACK - link- and server-supplied text is html-escaped in the confirm prompts and shared-deck preview so markup cannot spoof the shown messages --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de> |
||
|---|---|---|
| .. | ||
| appearance_settings.cpp | ||
| appearance_settings.h | ||
| cache_storage_settings.cpp | ||
| cache_storage_settings.h | ||
| card_database_settings.cpp | ||
| card_database_settings.h | ||
| card_override_settings.cpp | ||
| card_override_settings.h | ||
| cards_display_settings.cpp | ||
| cards_display_settings.h | ||
| chat_settings.cpp | ||
| chat_settings.h | ||
| commander_bracket_settings.cpp | ||
| commander_bracket_settings.h | ||
| debug_settings.cpp | ||
| debug_settings.h | ||
| deck_editor_settings.cpp | ||
| deck_editor_settings.h | ||
| download_settings.cpp | ||
| download_settings.h | ||
| game_filters_settings.cpp | ||
| game_filters_settings.h | ||
| game_settings.cpp | ||
| game_settings.h | ||
| interface_settings.cpp | ||
| interface_settings.h | ||
| layouts_settings.cpp | ||
| layouts_settings.h | ||
| message_settings.cpp | ||
| message_settings.h | ||
| network_settings.cpp | ||
| network_settings.h | ||
| paths_settings.cpp | ||
| paths_settings.h | ||
| personal_settings.cpp | ||
| personal_settings.h | ||
| recents_settings.cpp | ||
| recents_settings.h | ||
| servers_settings.cpp | ||
| servers_settings.h | ||
| settings_manager.cpp | ||
| settings_manager.h | ||
| settings_migration.cpp | ||
| settings_migration.h | ||
| sound_settings.cpp | ||
| sound_settings.h | ||
| tabs_settings.cpp | ||
| tabs_settings.h | ||
| updates_settings.cpp | ||
| updates_settings.h | ||
| visual_deck_storage_settings.cpp | ||
| visual_deck_storage_settings.h | ||