mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-11-08 02:53:25 -08:00
90bb3b8807
* [Tests] Cover DeckFilterString parse-error reporting DeckFilterString had no tests, so nothing pinned its error contract. Add coverage for the parse-error message, per-instance isolation, and the fact that the permanent parser's logger keeps no state between instances. The logger is reinstalled by each constructor and invoked only by the parse that immediately follows, so the logger's capture is live whenever it runs. These tests guard that arrangement rather than a fixed defect. * [Tests] Link gtest_main on the fetched-gtest path The downloaded-gtest branch set GTEST_BOTH_LIBRARIES to `gtest` alone, while FindGTest sets it to both halves. Every test target links that list rather than picking an entry point, so on this path nothing provides main() and any test source that does not define its own fails at link with `undefined reference to main` pointing at crt1.o, naming neither gtest nor the line responsible. That stayed latent while every test carried its own four-line main(). A test that omits it now fails, and the error points at the C runtime rather than at gtest, which is a long way from the cause. Restoring both halves makes the two paths agree and drops the boilerplate requirement on new test sources. The 18 sources that still define main() keep linking: gtest_main.cc defines nothing but main, so the linker leaves its object in the archive unused rather than reporting a duplicate. --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de> |
||
|---|---|---|
| .. | ||
| card_zone_algorithms | ||
| carddatabase | ||
| deck_list_model | ||
| deck_list_zones | ||
| loading_from_clipboard | ||
| movecard_tests | ||
| oracle | ||
| picture_loader_benchmark | ||
| settings | ||
| theme_migration | ||
| card_update_progress_test.cpp | ||
| clamped_arithmetic_test.cpp | ||
| CMakeLists.txt | ||
| deck_filter_string_test.cpp | ||
| deck_hash_performance_test.cpp | ||
| expression_test.cpp | ||
| lag_monitor_test.cpp | ||
| latency_tracker_test.cpp | ||
| loader_local_matching_test.cpp | ||
| metrics_registry_test.cpp | ||
| password_hash_test.cpp | ||
| playmat_resolver_test.cpp | ||
| report_categories_test.cpp | ||
| server_card_counter_test.cpp | ||
| server_counter_test.cpp | ||
| server_developer_role_test.cpp | ||
| server_dump_zone_test.cpp | ||
| server_game_join_test.cpp | ||
| server_rate_limiter_test.cpp | ||
| single_instance_manager_test.cpp | ||
| test_age_formatting.cpp | ||
| translation_loader_test.cpp | ||
| translation_loader_test.ts | ||
| warning_categories_test.cpp | ||