Cockatrice/servatrice/src
Lukas Brübach 9d34fa19af [Server] Record only the dispatched command family; drop unused totals
processCommandContainer recorded every family in a container even though
the base if/else-if dispatch processes at most one. An unauthenticated
client could batch a session command (login) with fabricated developer,
moderator, and admin entries and forge genuine-looking samples that were
never executed or authorized. Mirror the base's selection, skip when the
handler was already deleted, and skip entries whose extension number is
-1 (which would otherwise wrap into the previous kind's id range).

[Server] Drop dead process-lifetime byte/uptime counters

txBytesTotal/rxBytesTotal added an atomic RMW to every socket write and
read for counters nothing consumes (cmdGetServerStats fills tx_bytes,
rx_bytes, and uptime_secs from the DB snapshot). Remove the two atomics
and the getTxBytesTotal/getRxBytesTotal/getUptimeSeconds getters; the
incTxBytes/incRxBytes slots and mutexes remain for the ISL legacy
counters.

[Protocol] Document kind 5 as developer in CommandStats

NumKinds is 6 and the server emits kind_index = 5 for developer
commands; the comment stopped at 4.
2026-09-02 14:18:34 +02:00
..
smtp [CI] Remove Qt5 (#7071) 2026-08-08 22:04:50 +02:00
email_parser.cpp Strip dashes in Yahoo addresses (#6284) 2025-11-07 13:35:44 -05:00
email_parser.h Fix #4903: Parse Email Addresses whenever used (#4932) 2023-12-09 00:52:47 -05:00
event_loop_watchdog.cpp [Server] Instrument command processing, game starts, and event loops 2026-09-02 13:56:38 +02:00
event_loop_watchdog.h [Server] Instrument command processing, game starts, and event loops 2026-09-02 13:56:38 +02:00
isl_interface.cpp style: Add braces to all control flow statements (#6887) 2026-05-16 19:19:53 +02:00
isl_interface.h Turn Card, Deck_List, Protocol, RNG, Network (Client, Server), Settings and Utility into libraries and remove cockatrice_common. (#6212) 2025-10-09 07:36:12 +02:00
main.cpp style: Add braces to all control flow statements (#6887) 2026-05-16 19:19:53 +02:00
main.h Refactor servatrice email send 2015-07-25 18:48:34 +02:00
metrics_registry.cpp [Server] Drop dead Prometheus histogram, add developer command metrics, fix watchdog init order 2026-09-02 13:56:38 +02:00
metrics_registry.h [Server] Drop dead Prometheus histogram, add developer command metrics, fix watchdog init order 2026-09-02 13:56:38 +02:00
servatrice.cpp [Server] Record only the dispatched command family; drop unused totals 2026-09-02 14:18:34 +02:00
servatrice.h [Server] Record only the dispatched command family; drop unused totals 2026-09-02 14:18:34 +02:00
servatrice_connection_pool.cpp clangify everything with the new header sorting (#3908) 2020-03-18 17:36:02 -04:00
servatrice_connection_pool.h Support Qt6, Min Qt5.8, Fix Win32, Fix Servatrice 2022-05-06 17:31:08 -04:00
servatrice_database_interface.cpp [Server/Client/Protocol] Address developer role review feedback 2026-08-30 21:06:31 +02:00
servatrice_database_interface.h [Server/Client/Protocol] Address developer role review feedback 2026-08-30 21:06:31 +02:00
server_logger.cpp style: Add braces to all control flow statements (#6887) 2026-05-16 19:19:53 +02:00
server_logger.h Support Qt6, Min Qt5.8, Fix Win32, Fix Servatrice 2022-05-06 17:31:08 -04:00
serversocketinterface.cpp [Server] Record only the dispatched command family; drop unused totals 2026-09-02 14:18:34 +02:00
serversocketinterface.h [Server] Instrument command processing, game starts, and event loops 2026-09-02 13:56:38 +02:00
settingscache.cpp style: Add braces to all control flow statements (#6887) 2026-05-16 19:19:53 +02:00
settingscache.h remove dependency on deprecated qt5 libraries for qt6 (#4692) 2022-10-31 23:24:11 +01:00
signalhandler.cpp style: Add braces to all control flow statements (#6887) 2026-05-16 19:19:53 +02:00
signalhandler.h update format.sh (#6240) 2025-11-07 15:00:39 +01:00
smtpclient.cpp style: Add braces to all control flow statements (#6887) 2026-05-16 19:19:53 +02:00
smtpclient.h Clang-format (#3028) 2018-01-27 10:41:32 +01:00