mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-11-05 09:33:25 -08:00
Some checks are pending
CodeQL / Analyze (cpp) (push) Waiting to run
CodeQL / Analyze (actions) (push) Waiting to run
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 44 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 12 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 cover (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 26 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Desktop / Prune caches (push) Waiting to run
Build Docker / Servatrice (arm) (push) Waiting to run
Build Docker / Servatrice (x86) (push) Waiting to run
Build Docker / Publish multi-platform Servatrice image (push) Blocked by required conditions
* [Security] Add challenge-response auth with scrypt verifiers and stop storing plaintext passwords Challenge-response authentication: the client derives a scrypt verifier (RFC 7914, EVP_PBE_scrypt, N=32768, r=8, p=1) and authenticates with HMAC-SHA256(key, nonce), so neither the password nor its hash is transmitted. The stored format becomes "$scrypt$<n>$<r>$<p>$<salt>$<verifier>" and Response_PasswordSalt now carries the cost parameters. Strict servers only accept scrypt verifiers; legacy accounts are migrated after a successful login. Fix #344 for challenge-response servers: a saved profile stores the derived verifier under the password key instead of the plaintext password. The connect dialog loads it without revealing it, autoconnect passes it through, the change-password dialog no longer prefills the old password field with it, and the client only persists the verifier when "Save password" is checked. Took 3 minutes Took 1 minute Took 10 seconds Took 7 minutes * [Security] Harden credential format acceptance and challenge nonce validation * [Security] Refuse KDF downgrade; trim profile name and warn on silent credential drop * [Security] Add SupportsAll ServerOptions enumerator to fix enum validation assert The server advertised both SupportsPasswordHash (1) and SupportsChallengeResponseAuth (2) via a bitwise-OR that produced the value 3, which no enumerator declared. Protobuf's proto2 enum validation rejects the value in _internal_set_server_options, crashing servatrice on the debug assertion. Add a SupportsAll = 3 enumerator with an identical wire value so the bitmask reads unchanged while the value is now a documented, valid member of the enum. * [Security] Normalize username when issuing challenge nonce cmdRequestPasswordSalt bound the challenge nonce to the raw, un-simplified username while cmdLogin verifies it against the simplified name. A user who typed leading or trailing whitespace in the username box would be silently rejected during challenge-response login even with the correct password. Simplify at the nonce-issuing site so both commands agree on the normalized name. Also drive-by formatting: collapse the now single-expression serverOptions initializer onto one line. * [Security] Keep an encrypted legacy password backup for old-client logins Migrating an account to scrypt stranded pre-challenge clients, which can only present the legacy salt+hash: after migration the server served them a scrypt salt they cannot use, so the only recovery was a password reset. When security/legacy_backup_key is configured (64 hex chars, openssl rand -hex 32), submitPasswordVerifier now seals the legacy credential with AES-256-GCM under that key before overwriting the row, storing it in password_legacy_backup with the time it was last used. Old clients keep working: cmdRequestPasswordSalt serves the backup's 16-char salt in password_salt so they can derive the legacy hash they were always able to compute, while new clients derive the verifier from the new scrypt_salt field, which always carries the verifier salt. The non-challenge login path accepts the plaintext or legacy hash against the decrypted backup and refreshes its window; a migrated row with no usable backup fails closed. Backups age out so a database dump taken after the window closes never carries a crackable legacy hash: getUsableLegacyBackup purges on first use past security/legacy_backup_ttl_days (default 90, clamped 1..3650), and a six-hourly sweep drops backups idle accounts never touch. changeUserPassword clears the backup since a new credential invalidates it. Without a configured key nothing is sealed or purged, so a temporarily missing key cannot destroy existing backups. The AAD is the simplified user name on both sides, sealing the blob to its row so it cannot be moved between accounts. Sealing failures degrade to the previous lockout behaviour rather than blocking migration. The columns extend the unmerged 0036->0037 migration, so the schema version stays 37. * [Security] Address review: proto compat, plaintext verify, AAD case, strict scope Fix the two blockers and follow-ups from the 2026-10-16 review: - Advertise challenge-response in a new supports_challenge_response field instead of the ServerOptions enum and drop SupportsAll: proto2 enums are closed, so already-released clients parsed server_options = 3 as NoOptions and fell back to plaintext passwords. server_options stays exactly SupportsPasswordHash on the wire; old clients ignore the new field. - Verify a plaintext password directly against a migrated scrypt row with verifyPassword() so email changes (cmdAccountEdit) and old clients sending password keep working without a legacy backup key. Pre-hashed values are still checked against the backup, and its TTL window is refreshed only when the backup is what actually matched. - Use the stored row name as the AES-GCM AAD on both seal and open so a login whose case differs from the stored name (utf8mb4_unicode_ci) still opens its backup. - Require challenge-response in strict mode only for registered SQL accounts (userExists gate), leaving guest/unregistered logins and none/password auth methods unaffected. - Document in servatrice.ini.example that a captured legacy hash can take over a not-yet-migrated account and that strict only constrains registered SQL accounts. Schema version is 38. * [Security] Raise legacy backup TTL default to 180 days Gives operators and slow-to-upgrade users a longer downgrade window for pre-challenge clients before unused encrypted legacy password backups age out. * [Security] Fix servatrice.cpp formatting per clang-format-18 * [Security] Add missing forward declaration for Command_SubmitPasswordVerifier The cmdSubmitPasswordVerifier declaration references the proto-generated type, which otherwise does not name a type in this header and breaks every C++ build. --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de> Co-authored-by: BruebachL <bruebachl@cockatrice.example>
300 lines
9.3 KiB
C++
300 lines
9.3 KiB
C++
#ifndef SERVER_H
|
|
#define SERVER_H
|
|
|
|
#include "server_player_reference.h"
|
|
|
|
#include <QList>
|
|
#include <QMap>
|
|
#include <QMultiMap>
|
|
#include <QMutex>
|
|
#include <QMutexLocker>
|
|
#include <QObject>
|
|
#include <QReadWriteLock>
|
|
#include <QString>
|
|
#include <QtGlobal>
|
|
#include <qtmetamacros.h>
|
|
|
|
class Server_DatabaseInterface;
|
|
class Server_Room;
|
|
class Server_ProtocolHandler;
|
|
class Server_AbstractUserInterface;
|
|
class IslMessage;
|
|
class SessionEvent;
|
|
class RoomEvent;
|
|
class ServerInfo_Game;
|
|
class ServerInfo_Room;
|
|
class Response;
|
|
class GameEventContainer;
|
|
class CommandContainer;
|
|
class Command_JoinGame;
|
|
class QThread;
|
|
class ServerInfo_User;
|
|
|
|
enum AuthenticationResult
|
|
{
|
|
NotLoggedIn,
|
|
PasswordRight,
|
|
UnknownUser,
|
|
WouldOverwriteOldSession,
|
|
UserIsBanned,
|
|
UsernameInvalid,
|
|
RegistrationRequired,
|
|
UserIsInactive,
|
|
ClientIdRequired,
|
|
PasswordChangeRequired
|
|
};
|
|
|
|
class Server : public QObject
|
|
{
|
|
Q_OBJECT
|
|
signals:
|
|
void pingClockTimeout();
|
|
void sigSendIslMessage(const IslMessage &message, int serverId);
|
|
void endSession(qint64 sessionId);
|
|
private slots:
|
|
void broadcastRoomUpdate(const ServerInfo_Room &roomInfo, bool sendToIsl = false);
|
|
|
|
public:
|
|
mutable QReadWriteLock clientsLock, roomsLock; // locking order: roomsLock before clientsLock
|
|
explicit Server(QObject *parent = nullptr);
|
|
~Server() override = default;
|
|
AuthenticationResult loginUser(Server_ProtocolHandler *session,
|
|
QString &name,
|
|
const QString &password,
|
|
bool passwordNeedsHash,
|
|
QString &reason,
|
|
int &secondsLeft,
|
|
QString &clientid,
|
|
QString &clientVersion,
|
|
QString &connectionType);
|
|
void broadcastUserInfoUpdate(Server_ProtocolHandler *source);
|
|
|
|
const QMap<int, Server_Room *> &getRooms()
|
|
{
|
|
return rooms;
|
|
}
|
|
|
|
Server_AbstractUserInterface *findUser(const QString &userName) const;
|
|
const QMap<QString, Server_ProtocolHandler *> &getUsers() const
|
|
{
|
|
return users;
|
|
}
|
|
const QMap<qint64, Server_ProtocolHandler *> &getUsersBySessionId() const
|
|
{
|
|
return usersBySessionId;
|
|
}
|
|
virtual QMap<QString, bool> getServerRequiredFeatureList() const
|
|
{
|
|
return QMap<QString, bool>();
|
|
}
|
|
/** @brief True when only challenge-response logins are accepted (strict mode). */
|
|
virtual bool requiresChallengeResponseAuth() const
|
|
{
|
|
return false;
|
|
}
|
|
void addClient(Server_ProtocolHandler *player);
|
|
void removeClient(Server_ProtocolHandler *player);
|
|
QList<QString> getOnlineModeratorList() const;
|
|
virtual QString getLoginMessage() const
|
|
{
|
|
return QString();
|
|
}
|
|
virtual SessionEvent *getLoginSessionEvent() const
|
|
{
|
|
return nullptr;
|
|
}
|
|
virtual QString getRequiredFeatures() const
|
|
{
|
|
return QString();
|
|
}
|
|
virtual bool permitUnregisteredUsers() const
|
|
{
|
|
return true;
|
|
}
|
|
virtual bool getGameShouldPing() const
|
|
{
|
|
return false;
|
|
}
|
|
virtual bool getClientIDRequiredEnabled() const
|
|
{
|
|
return false;
|
|
}
|
|
virtual bool getRegOnlyServerEnabled() const
|
|
{
|
|
return false;
|
|
}
|
|
virtual bool getMaxUserLimitEnabled() const
|
|
{
|
|
return false;
|
|
}
|
|
virtual bool getEnableLogQuery() const
|
|
{
|
|
return false;
|
|
}
|
|
virtual bool getStoreReplaysEnabled() const
|
|
{
|
|
return true;
|
|
}
|
|
virtual int getIdleClientTimeout() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getClientKeepAlive() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxGameInactivityTime() const
|
|
{
|
|
return 9999999;
|
|
}
|
|
virtual int getMaxPlayerInactivityTime() const
|
|
{
|
|
return 9999999;
|
|
}
|
|
virtual int getMessageCountingInterval() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxMessageCountPerInterval() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxMessageSizePerInterval() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxGamesPerUser() const
|
|
{
|
|
return -1;
|
|
}
|
|
virtual int getCommandCountingInterval() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxCommandCountPerInterval() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual int getMaxUserTotal() const
|
|
{
|
|
return 9999999;
|
|
}
|
|
virtual int getServerID() const
|
|
{
|
|
return 0;
|
|
}
|
|
virtual bool permitCreateGameAsJudge() const
|
|
{
|
|
return false;
|
|
}
|
|
/// Called once per actual game start with how long bringing every player's
|
|
/// zones online took, so servers can spot deck sizes that wedge threads.
|
|
virtual void observeGameStartDurationMs(qint64 /* elapsedMs */)
|
|
{
|
|
}
|
|
/**
|
|
* @brief Record a failed login attempt for the (address, username) pair; returns true if now locked out.
|
|
*
|
|
* Keyed by pair so a successful login as one user cannot wipe out another
|
|
* user's failure history from the same address (e.g. a guest login or the
|
|
* attacker's own account clearing the way for further guessing).
|
|
*/
|
|
virtual bool recordFailedLogin(const QString & /*ipAddress*/, const QString & /*userName*/)
|
|
{
|
|
return false;
|
|
}
|
|
/**
|
|
* @brief True if the (address, username) pair is already locked out of logging in.
|
|
*
|
|
* Consulted before any authentication work (database round trip, password
|
|
* verification) so a blocked pair cannot burn server CPU per attempt.
|
|
*/
|
|
virtual bool isLoginRateLimited(const QString & /*ipAddress*/, const QString & /*userName*/)
|
|
{
|
|
return false;
|
|
}
|
|
/**
|
|
* @brief Seconds remaining before the login rate limit for the (address, username) pair lifts.
|
|
* Returns 0 if not limited.
|
|
*/
|
|
virtual int loginRateLimitRemainingSeconds(const QString & /*ipAddress*/, const QString & /*userName*/)
|
|
{
|
|
return 0;
|
|
}
|
|
/** @brief Clear any failed-login lockout for the (address, username) pair, e.g. after a successful login. */
|
|
virtual void clearFailedLogins(const QString & /*ipAddress*/, const QString & /*userName*/)
|
|
{
|
|
}
|
|
|
|
Server_DatabaseInterface *getDatabaseInterface() const;
|
|
int getNextLocalGameId()
|
|
{
|
|
QMutexLocker locker(&nextLocalGameIdMutex);
|
|
return ++nextLocalGameId;
|
|
}
|
|
|
|
void sendIsl_Response(const Response &item, int serverId = -1, qint64 sessionId = -1);
|
|
void sendIsl_SessionEvent(const SessionEvent &item, int serverId = -1, qint64 sessionId = -1);
|
|
void sendIsl_GameEventContainer(const GameEventContainer &item, int serverId = -1, qint64 sessionId = -1);
|
|
void sendIsl_RoomEvent(const RoomEvent &item, int serverId = -1, qint64 sessionId = -1);
|
|
void sendIsl_GameCommand(const CommandContainer &item, int serverId, qint64 sessionId, int roomId, int playerId);
|
|
void sendIsl_RoomCommand(const CommandContainer &item, int serverId, qint64 sessionId, int roomId);
|
|
|
|
const QMap<QString, Server_AbstractUserInterface *> &getExternalUsers() const
|
|
{
|
|
return externalUsers;
|
|
}
|
|
|
|
void addPersistentPlayer(const QString &userName, int roomId, int gameId, int playerId);
|
|
void removePersistentPlayer(const QString &userName, int roomId, int gameId, int playerId);
|
|
QList<PlayerReference> getPersistentPlayerReferences(const QString &userName) const;
|
|
int getUsersCount() const;
|
|
int getGamesCount() const;
|
|
int getTCPUserCount() const
|
|
{
|
|
return tcpUserCount;
|
|
}
|
|
int getWebSocketUserCount() const
|
|
{
|
|
return webSocketUserCount;
|
|
}
|
|
|
|
private:
|
|
QMultiMap<QString, PlayerReference> persistentPlayers;
|
|
mutable QReadWriteLock persistentPlayersLock;
|
|
int nextLocalGameId, tcpUserCount, webSocketUserCount;
|
|
QMutex nextLocalGameIdMutex;
|
|
|
|
protected slots:
|
|
void externalUserJoined(const ServerInfo_User &userInfo);
|
|
void externalUserLeft(const QString &userName);
|
|
void externalRoomUserJoined(int roomId, const ServerInfo_User &userInfo);
|
|
void externalRoomUserLeft(int roomId, const QString &userName);
|
|
void externalRoomSay(int roomId, const QString &userName, const QString &message, const QString &channelId);
|
|
void externalRoomRemoveMessages(int roomId, const QString &userName, int amount);
|
|
void externalRoomGameListChanged(int roomId, const ServerInfo_Game &gameInfo);
|
|
void
|
|
externalJoinGameCommandReceived(const Command_JoinGame &cmd, int cmdId, int roomId, int serverId, qint64 sessionId);
|
|
void
|
|
externalGameCommandContainerReceived(const CommandContainer &cont, int playerId, int serverId, qint64 sessionId);
|
|
void externalGameEventContainerReceived(const GameEventContainer &cont, qint64 sessionId);
|
|
void externalResponseReceived(const Response &resp, qint64 sessionId);
|
|
|
|
virtual void doSendIslMessage(const IslMessage & /* msg */, int /* serverId */)
|
|
{
|
|
}
|
|
|
|
protected:
|
|
void prepareDestroy();
|
|
void setDatabaseInterface(Server_DatabaseInterface *_databaseInterface);
|
|
QList<Server_ProtocolHandler *> clients;
|
|
QMap<qint64, Server_ProtocolHandler *> usersBySessionId;
|
|
QMap<QString, Server_ProtocolHandler *> users;
|
|
QMap<qint64, Server_AbstractUserInterface *> externalUsersBySessionId;
|
|
QMap<QString, Server_AbstractUserInterface *> externalUsers;
|
|
QMap<int, Server_Room *> rooms;
|
|
QMap<QThread *, Server_DatabaseInterface *> databaseInterfaces;
|
|
void addRoom(Server_Room *newRoom);
|
|
};
|
|
|
|
#endif
|