Cockatrice/cockatrice
BruebachL bbe438b09a
[Completer] Highlight popup rows without rewriting the line edit (#7502)
* [Completer] Highlight popup rows without rewriting the line edit

Selecting a popup row with ClearAndSelect emits selectionChanged, which
QCompleter turns into highlighted() and QLineEdit turns into setText().
Since be2c16eca5 (#7466) that rewrites the typed text on every completion
reset / arrow-key press (e.g. typing "A" becomes "Axe" and cannot be
edited), regressing the 514014dc00 (#7447) fix that used NoUpdate.

Add selectWithoutRewrite(), which blocks the selection-model signals while
applying ClearAndSelect so the highlight stays visible without touching
the line edit, then syncs the preview manually. Route both the
above-popup auto-select and Up/Down navigation through it, and handle
Up/Down for below-popups too instead of falling through to Qt's
rewriting default. Enter/click acceptance via activated() is unchanged.

* [Completer] Repaint popup highlight after silent selection change

Blocking the selection model's signals also suppresses the view's own
selectionChanged/currentChanged repaints, so force a viewport update
after restoring signals. Use EnsureVisible to match Qt's normal scroll
behaviour.

---------

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-10-16 19:01:38 +02:00
..
resources [Themes] Encode home backgrounds as JPEG to slim the repo (#7346) 2026-09-24 18:40:04 +02:00
sounds Add cmake format (#4618) 2022-05-08 21:22:43 +02:00
src [Completer] Highlight popup rows without rewriting the line edit (#7502) 2026-10-16 19:01:38 +02:00
themes [Themes] Encode home backgrounds as JPEG to slim the repo (#7346) 2026-09-24 18:40:04 +02:00
translations Update translation files (#7044) 2026-07-16 09:07:33 +02:00
.qdevelop icon_draw and icon_untap added, icon_general and icon_messages modified 2009-07-31 13:37:16 +02:00
CMakeLists.txt [Client] Warn when data paths point inside the program directory (#7473) 2026-10-11 15:34:49 +02:00
cockatrice-cod.xml Define Cockatrice as an editor/handler for .cod files and cockatrice:// protocol on all platforms (#6775) 2026-08-08 19:02:19 +02:00
cockatrice.desktop fix the desktop file, removing the invalid key (#7406) 2026-10-10 17:15:10 +02:00
cockatrice.qrc [Themes] Encode home backgrounds as JPEG to slim the repo (#7346) 2026-09-24 18:40:04 +02:00
cockatrice.rc Included uninstaller for Windows version 2010-09-17 15:26:07 +02:00
cockatrice_en@source.ts Update translation source strings (#7397) 2026-10-04 21:08:47 +02:00