mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-21 00:55:09 -07:00
b855b279a7
processCommandContainer recorded every family in a container even though the base if/else-if dispatch processes at most one. An unauthenticated client could batch a session command (login) with fabricated developer, moderator, and admin entries and forge genuine-looking samples that were never executed or authorized. Mirror the base's selection, skip when the handler was already deleted, and skip entries whose extension number is -1 (which would otherwise wrap into the previous kind's id range). [Server] Drop dead process-lifetime byte/uptime counters txBytesTotal/rxBytesTotal added an atomic RMW to every socket write and read for counters nothing consumes (cmdGetServerStats fills tx_bytes, rx_bytes, and uptime_secs from the DB snapshot). Remove the two atomics and the getTxBytesTotal/getRxBytesTotal/getUptimeSeconds getters; the incTxBytes/incRxBytes slots and mutexes remain for the ISL legacy counters. [Protocol] Document kind 5 as developer in CommandStats NumKinds is 6 and the server emits kind_index = 5 for developer commands; the comment stopped at 4.
41 lines
1.5 KiB
Protocol Buffer
41 lines
1.5 KiB
Protocol Buffer
syntax = "proto2";
|
|
import "response.proto";
|
|
|
|
message CommandStats {
|
|
optional uint32 kind_index = 1; // 0=session, 1=room, 2=game, 3=moderator, 4=admin, 5=developer
|
|
optional uint32 extension_number = 2; // protobuf extension number within the kind
|
|
optional string command_name = 3; // e.g. "session/Command_Ping"
|
|
optional uint64 count = 4; // number of times observed
|
|
optional uint64 total_ms = 5; // cumulative processing milliseconds
|
|
}
|
|
|
|
message Response_GetServerStats {
|
|
extend Response {
|
|
optional Response_GetServerStats ext = 1220;
|
|
}
|
|
|
|
optional uint64 users_count = 1;
|
|
optional uint64 mods_count = 2;
|
|
optional uint64 games_count = 3;
|
|
|
|
// Traffic recorded during the last status update tick
|
|
optional uint64 tx_bytes = 4;
|
|
optional uint64 rx_bytes = 5;
|
|
|
|
optional uint64 uptime_secs = 6;
|
|
optional uint64 timest = 7; // unix timestamp of the snapshot
|
|
|
|
// Live metrics from MetricsRegistry (reset on server restart)
|
|
optional uint64 cards_in_games = 8;
|
|
optional uint64 eventloop_stalls_total = 9;
|
|
optional uint64 eventloop_last_stall_ms = 10;
|
|
optional uint64 eventloop_max_stall_ms = 11;
|
|
optional uint64 total_commands = 12;
|
|
optional uint64 total_command_time_ms = 13;
|
|
optional int32 active_command_types = 14;
|
|
optional uint64 game_start_count = 15;
|
|
optional uint64 game_start_total_ms = 16;
|
|
|
|
// Per-command breakdown (only types with count > 0)
|
|
repeated CommandStats command_stats = 20;
|
|
}
|