mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-22 01:25:10 -07:00
Some checks are pending
Build Desktop / Configure (push) Waiting to run
Build Desktop / Debian 13 (push) Blocked by required conditions
Build Desktop / Debian 12 (push) Blocked by required conditions
Build Desktop / Fedora 44 (push) Blocked by required conditions
Build Desktop / Fedora 43 (push) Blocked by required conditions
Build Desktop / Servatrice_Debian 12 (push) Blocked by required conditions
Build Desktop / Ubuntu 26.04 (push) Blocked by required conditions
Build Desktop / Ubuntu 24.04 (push) Blocked by required conditions
Build Desktop / Arch (push) Blocked by required conditions
Build Desktop / macOS 15 (push) Blocked by required conditions
Build Desktop / macOS 13 Intel (push) Blocked by required conditions
Build Desktop / macOS 14 (push) Blocked by required conditions
Build Desktop / macOS 15 Debug (push) Blocked by required conditions
Build Desktop / Windows 10 (push) Blocked by required conditions
Build Docker Image / amd64 & arm64 (push) Waiting to run
* [Server/Client/Protocol] Reporting users + moderation queue functionality Took 6 minutes Took 3 minutes Took 8 seconds Took 11 minutes Took 12 minutes Took 7 minutes Took 15 seconds Took 2 minutes Took 1 minute Took 30 seconds Took 16 seconds * CI Fix Took 6 minutes * CI Fix Took 6 minutes * [Protocol] Add moderation investigation commands Adds the protocol layer for the moderation investigation suite: - Command_GetUserSessions/GetUserAlts/GetModeratorLastLogins/ResetUserPassword/RemoveUserAvatar (1013-1017) - Response extensions 1215-1219 with ServerInfo messages for sessions, alts, and staff logins - last_login on Response_ReportUserInfo and warning_il on Response_WarnList Took 2 minutes * [Utility] Add warning categories parser with infraction levels Parses the server's 'officialwarnings' setting (comma-separated, optional '|IL' suffix) into WarningCategory structs so the client can display the infraction level of each warning category. Includes GTest coverage. * [Server] Add moderation investigation tools Implements the server side of the moderation suite: - getUserSessions/getUserAlts/getModeratorLastLogins/removeUserAvatar DB methods - Handlers for all five new commands with audit records (PASSWORD_RESET, REMOVE_USER_AVATAR); password resets return a generated temporary password - cmdGetWarnList now reports per-category infraction levels from the officialwarnings setting; cmdReportUserInfo reports last_login - Update servatrice.ini.example with the warning taxonomy - Password/avatar mutations report RespNameNotFound when the user does not exist * [Client] Add moderation tab with investigate, password reset, and avatar removal - New Moderation tab: search a user to show account info, alternate accounts, login sessions, and staff last logins; actions to reset the user's password (shows the generated temporary password) and remove the user's avatar - 'Investigate user' entry in the user context menu opens the tab pre-loaded for that user - Warning dialog shows the infraction level of each warning category - Tab wired into TabSupervisor with a moderator-gated menu action, shortcut, and tabs.ini persistence (default closed) * [Server/Client/Protocol] Address PR #7091 review: security, bug, and perf fixes Security: - Promote RESET_USER_PASSWORD to admin-only dispatch (was moderator-accessible) - Reject password reset on users with equal/higher privilege than caller - Notify affected user via Event_NotifyUser::CUSTOM when password is reset - Add server-side category whitelist for reports - Drop reporter name fallback in comment/details authorization (ID-only) - Force password change: new DB column + login enforcement + client disconnect Bugs: - XSS via QTextEdit::append() → insertPlainText() in report tab and utils - allNotified initialized to true even with empty recipients list - Warning combo box: use currentData() instead of baked-in display text - Report resolution now records who resolved (resolved_by column + audit) Performance: - IP-correlation subquery: add 6-month window + LIMIT 200 - getUserSessions: clamp limit to 500 Non-blocking: - Palette-aware colors in report_utils.cpp (dark/light mode) - Report list pagination: offset/limit fields + total_count in response - SessionCommand enum gap comment for reserved values 1201-1203 Schema: 36→37 (force_password_change), 37→38 (resolved_by) Took 12 minutes Took 16 seconds * Fix macOs pedantry Took 5 minutes --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
160 lines
8 KiB
C++
160 lines
8 KiB
C++
#ifndef SERVATRICE_DATABASE_INTERFACE_H
|
|
#define SERVATRICE_DATABASE_INTERFACE_H
|
|
|
|
#include <QChar>
|
|
#include <QHash>
|
|
#include <QObject>
|
|
#include <QSqlDatabase>
|
|
#include <libcockatrice/protocol/pb/serverinfo_chat_message.pb.h>
|
|
#include <libcockatrice/protocol/pb/serverinfo_moderator_login.pb.h>
|
|
#include <libcockatrice/protocol/pb/serverinfo_user_alt.pb.h>
|
|
#include <libcockatrice/protocol/pb/serverinfo_user_session.pb.h>
|
|
#include <libcockatrice/protocol/pb/serverinfo_warning.pb.h>
|
|
#include <server.h>
|
|
#include <server_database_interface.h>
|
|
|
|
#define DATABASE_SCHEMA_VERSION 36
|
|
|
|
class Servatrice;
|
|
|
|
class Servatrice_DatabaseInterface : public Server_DatabaseInterface
|
|
{
|
|
Q_OBJECT
|
|
private:
|
|
int instanceId;
|
|
QSqlDatabase sqlDatabase;
|
|
QHash<QString, QSqlQuery *> preparedStatements;
|
|
Servatrice *server;
|
|
ServerInfo_User evalUserQueryResult(const QSqlQuery *query, bool complete, bool withId = false);
|
|
/** Must be called after checkSql and server is known to be in auth mode. */
|
|
bool checkUserIsIdBanned(const QString &clientId, QString &banReason, int &banSecondsRemaining);
|
|
/** Must be called after checkSql and server is known to be in auth mode. */
|
|
bool checkUserIsIpBanned(const QString &ipAddress, QString &banReason, int &banSecondsRemaining);
|
|
/** Must be called after checkSql and server is known to be in auth mode. */
|
|
bool checkUserIsNameBanned(QString const &userName, QString &banReason, int &banSecondsRemaining);
|
|
|
|
protected:
|
|
AuthenticationResult checkUserPassword(Server_ProtocolHandler *handler,
|
|
const QString &user,
|
|
const QString &password,
|
|
const QString &clientId,
|
|
QString &reasonStr,
|
|
int &banSecondsLeft,
|
|
bool passwordNeedsHash) override;
|
|
|
|
public slots:
|
|
void initDatabase(const QSqlDatabase &_sqlDatabase);
|
|
|
|
public:
|
|
explicit Servatrice_DatabaseInterface(int _instanceId, Servatrice *_server);
|
|
~Servatrice_DatabaseInterface() override;
|
|
bool initDatabase(const QString &type,
|
|
const QString &hostName,
|
|
const QString &databaseName,
|
|
const QString &userName,
|
|
const QString &password);
|
|
bool openDatabase();
|
|
bool checkSql();
|
|
QSqlQuery *prepareQuery(const QString &queryText);
|
|
bool execSqlQuery(QSqlQuery *query);
|
|
const QSqlDatabase &getDatabase()
|
|
{
|
|
return sqlDatabase;
|
|
}
|
|
|
|
bool activeUserExists(const QString &user) override;
|
|
bool userExists(const QString &user) override;
|
|
QString getUserSalt(const QString &user) override;
|
|
int getUserIdInDB(const QString &name);
|
|
QMap<QString, ServerInfo_User> getBuddyList(const QString &name) override;
|
|
QMap<QString, ServerInfo_User> getIgnoreList(const QString &name) override;
|
|
bool isInBuddyList(const QString &whoseList, const QString &who) override;
|
|
bool isInIgnoreList(const QString &whoseList, const QString &who) override;
|
|
ServerInfo_User getUserData(const QString &name, bool withId = false) override;
|
|
void storeGameInformation(const QString &roomName,
|
|
const QStringList &roomGameTypes,
|
|
const ServerInfo_Game &gameInfo,
|
|
const QSet<QString> &allPlayersEver,
|
|
const QSet<QString> &allSpectatorsEver,
|
|
const QList<GameReplay *> &replayList) override;
|
|
DeckList *getDeckFromDatabase(int deckId, int userId) override;
|
|
|
|
int getNextGameId() override;
|
|
int getNextReplayId() override;
|
|
int getActiveUserCount(QString connectionType = QString()) override;
|
|
|
|
qint64 startSession(const QString &userName,
|
|
const QString &address,
|
|
const QString &clientId,
|
|
const QString &connectionType) override;
|
|
void endSession(qint64 sessionId) override;
|
|
void clearSessionTables() override;
|
|
void lockSessionTables() override;
|
|
void unlockSessionTables() override;
|
|
bool userSessionExists(const QString &userName) override;
|
|
bool usernameIsValid(const QString &user, QString &error) override;
|
|
bool checkUserIsBanned(const QString &ipAddress,
|
|
const QString &userName,
|
|
const QString &clientId,
|
|
QString &banReason,
|
|
int &banSecondsRemaining) override;
|
|
int checkNumberOfUserAccounts(const QString &email) override;
|
|
bool registerUser(const QString &userName,
|
|
const QString &realName,
|
|
const QString &password,
|
|
bool passwordNeedsHash,
|
|
const QString &emailAddress,
|
|
const QString &country,
|
|
bool active = false) override;
|
|
bool activateUser(const QString &userName, const QString &token) override;
|
|
void updateUsersClientID(const QString &userName, const QString &userClientID) override;
|
|
void updateUsersLastLoginData(const QString &userName, const QString &clientVersion) override;
|
|
void logMessage(const int senderId,
|
|
const QString &senderName,
|
|
const QString &senderIp,
|
|
const QString &logMessage,
|
|
LogMessage_TargetType targetType,
|
|
const int targetId,
|
|
const QString &targetName) override;
|
|
bool changeUserPassword(const QString &user, const QString &password, bool passwordNeedsHash) override;
|
|
bool changeUserPassword(const QString &user,
|
|
const QString &oldPassword,
|
|
bool oldPasswordNeedsHash,
|
|
const QString &newPassword,
|
|
bool newPasswordNeedsHash) override;
|
|
void setForcePasswordChange(const QString &user, bool force) override;
|
|
QList<ServerInfo_Ban> getUserBanHistory(const QString userName);
|
|
bool
|
|
addWarning(const QString userName, const QString adminName, const QString warningReason, const QString clientID);
|
|
QList<ServerInfo_Warning> getUserWarnHistory(const QString userName);
|
|
QList<ServerInfo_ChatMessage> getMessageLogHistory(const QString &user,
|
|
const QString &ipaddress,
|
|
const QString &gamename,
|
|
const QString &gameid,
|
|
const QString &message,
|
|
bool &chat,
|
|
bool &game,
|
|
bool &room,
|
|
int &range,
|
|
int &maxresults);
|
|
QList<ServerInfo_UserSession> getUserSessions(const QString &userName, int limit);
|
|
QList<ServerInfo_UserAlt> getUserAlts(const QString &userName);
|
|
QList<ServerInfo_ModeratorLogin> getModeratorLastLogins();
|
|
bool removeUserAvatar(const QString &userName);
|
|
bool addForgotPassword(const QString &user);
|
|
bool removeForgotPassword(const QString &user) override;
|
|
bool doesForgotPasswordExist(const QString &user);
|
|
bool updateUserToken(const QString &token, const QString &user);
|
|
bool validateTableColumnStringData(const QString &table,
|
|
const QString &column,
|
|
const QString &_user,
|
|
const QString &_datatocheck);
|
|
void addAuditRecord(const QString &user,
|
|
const QString &ipaddress,
|
|
const QString &clientid,
|
|
const QString &action,
|
|
const QString &details,
|
|
const bool &results);
|
|
};
|
|
|
|
#endif
|