mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-21 09:05:10 -07:00
* [Server/Client/Protocol] Add developer staff role Introduce a Developer staff level (proto flag 32, DB admin bit 8) that sits between admin and moderator: no kick/ban/warn/report/admin powers, but gets server log access via a new developer command container family (GET_SERVER_STATS, VIEWLOG_HISTORY) and an idle-timeout exemption. - Protocol: IsDeveloper flag, developer_commands.proto envelope, Command_GetServerStats/Command_GetLogHistory, Response_GetServerStats, Command_AdjustMod.should_be_developer - Servatrice: fail-closed developer dispatcher, uptime snapshot handler, shared log history handler reuse, bit-8 DB mapping - Client: burgundy pawn/badge/labels/sort order, prepareDeveloperCommand, minimal Developer stats tab, log tab access, promote/demote actions Took 24 minutes Took 18 seconds * [Server/Client/Protocol] Address developer role review feedback Address ZeizaZach's review of the developer staff role: - Nudge the developer log query to exclude private chat and sender IPs (the ModeratorCommand path still sees everything). - Deduplicate Command_GetLogHistory into Command_ViewLogHistory, which now extends both ModeratorCommand (ext) and DeveloperCommand (dev_ext); the client picks the DeveloperCommand-scoped extension by extendee, and the server reads it via the extension number. - Pull the uptime snapshot SQL into Servatrice_DatabaseInterface as getLatestUptimeSnapshot() and widen the reported counters to 64-bit. - Document the admin bitfield (1 admin, 2 moderator, 4 judge, 8 developer) and add a server-side test for the developer command path. * Add missing trailing newline to user_context_menu.cpp * Remove stale includes of deleted command_get_log_history proto The Command_GetLogHistory message was folded into Command_ViewLogHistory, which deleted command_get_log_history.proto, but serversocketinterface still #included its generated header. Fresh CI builds fail on the missing file; local builds masked it by reusing a previously generated header. * [Server] Exclude chat rows when private-chat filter is bypassable A developer who omits log_location entirely — or sends only "chat" — leaves chatType, gameType, roomType all false, so getMessageLogHistory skips the target_type clause and returns every row, private messages included. When !allowPrivateChat the server now forces game+room when no surviving location was requested, guaranteeing the query always carries a target_type restriction. [Client] Demote mod+dev to moderator path in log-tab dispatch The developer command family is strictly weaker than the moderator one (no private chat, no sender_ip, ip filter ignored), so granting the developer bit to an existing moderator must not silently strip their capabilities. useDeveloperCommands is now true only when the user holds the developer bit and not the moderator bit. [Client] Hide the IP-address filter for developer log tab users The developer path ignores the ip_address query field server-side. Showing the field lets a developer type an IP and get results that are silently unfiltered by it rather than an empty result set — reads as a broken filter. Hide labelFindIPAddress/findIPAddress alongside the privateChat checkbox. * Developer pawn is silver. * [Client] Fix indentation of merged Card Art Rules / Developer tabs --------- Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
48 lines
1.1 KiB
Protocol Buffer
48 lines
1.1 KiB
Protocol Buffer
syntax = "proto2";
|
|
message AdminCommand {
|
|
enum AdminCommandType {
|
|
UPDATE_SERVER_MESSAGE = 1000;
|
|
SHUTDOWN_SERVER = 1001;
|
|
RELOAD_CONFIG = 1002;
|
|
ADJUST_MOD = 1003;
|
|
RESET_USER_PASSWORD = 1016;
|
|
}
|
|
extensions 100 to max;
|
|
}
|
|
|
|
message Command_UpdateServerMessage {
|
|
extend AdminCommand {
|
|
optional Command_UpdateServerMessage ext = 1000;
|
|
}
|
|
}
|
|
|
|
message Command_ShutdownServer {
|
|
extend AdminCommand {
|
|
optional Command_ShutdownServer ext = 1001;
|
|
}
|
|
optional string reason = 1;
|
|
optional uint32 minutes = 2;
|
|
}
|
|
|
|
message Command_ReloadConfig {
|
|
extend AdminCommand {
|
|
optional Command_ReloadConfig ext = 1002;
|
|
}
|
|
}
|
|
|
|
message Command_AdjustMod {
|
|
extend AdminCommand {
|
|
optional Command_AdjustMod ext = 1003;
|
|
}
|
|
required string user_name = 1;
|
|
optional bool should_be_mod = 2;
|
|
optional bool should_be_judge = 3;
|
|
optional bool should_be_developer = 4;
|
|
}
|
|
|
|
message Command_ResetUserPassword {
|
|
extend AdminCommand {
|
|
optional Command_ResetUserPassword ext = 1016;
|
|
}
|
|
optional string user_name = 1;
|
|
}
|