Cockatrice/cockatrice/src/game_graphics/board
BruebachL 030e4f5871
[Game] Stop duplicate attach log entries (#7273)
Fix duplicate attach messages in the game log caused by a redundant
child arrow in CardItem::drawAttachArrow.

Unlike the sibling drawArrow, drawAttachArrow omitted the ``card ==
this`` guard when iterating selectedItems(). Because right-clicking a
card to open the attach menu selects that card, it was always present
in selectedItems(), producing a second arrow for the same source card.

On release both arrows sent an identical Command_AttachCard, so the
server broadcast two Event_AttachCard messages and the log rendered
"attaches to" twice. Mirror the drawArrow skip condition so the active
card is excluded and only one attach command is sent.

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2026-09-07 13:37:13 +02:00
..
abstract_card_drag_item.cpp [Settings] Split cache_settings monolith into multiple SettingsManager sub-classes (#7050) 2026-07-27 11:25:39 +02:00
abstract_card_drag_item.h [Game] Move graphics out of game and into game_graphics (#6928) 2026-06-09 09:51:13 +02:00
abstract_card_item.cpp [Game] Generic Animation Interface (#7098) 2026-08-12 20:36:33 +02:00
abstract_card_item.h [Game] Generic Animation Interface (#7098) 2026-08-12 20:36:33 +02:00
abstract_counter.cpp [Replay] Skip damage animations when skipping backward in replays (#7249) 2026-09-07 02:26:52 +02:00
abstract_counter.h [Replay] Skip damage animations when skipping backward in replays (#7249) 2026-09-07 02:26:52 +02:00
abstract_graphics_item.cpp style: Add braces to all control flow statements (#6887) 2026-05-16 19:19:53 +02:00
abstract_graphics_item.h Standardize Doxygen documentation (#6885) 2026-05-21 22:58:07 +02:00
arrow_item.cpp [Arrows] More fixes and assurances for drag arrows (#7117) 2026-08-14 19:22:30 +02:00
arrow_item.h [Game] Give a graphics_item_type.h to arrow_item.h (#7150) 2026-08-21 19:22:44 +02:00
arrow_target.cpp [Game] Move graphics out of game and into game_graphics (#6928) 2026-06-09 09:51:13 +02:00
arrow_target.h [Game] Move graphics out of game and into game_graphics (#6928) 2026-06-09 09:51:13 +02:00
card_drag_item.cpp [Game] Move graphics out of game and into game_graphics (#6928) 2026-06-09 09:51:13 +02:00
card_drag_item.h [Game] Move graphics out of game and into game_graphics (#6928) 2026-06-09 09:51:13 +02:00
card_item.cpp [Game] Stop duplicate attach log entries (#7273) 2026-09-07 13:37:13 +02:00
card_item.h [Game] Generic Animation Interface (#7098) 2026-08-12 20:36:33 +02:00
counter_general.cpp [Game] Move graphics out of game and into game_graphics (#6928) 2026-06-09 09:51:13 +02:00
counter_general.h [Game] Move graphics out of game and into game_graphics (#6928) 2026-06-09 09:51:13 +02:00
graphics_item_type.h [Game] Give a graphics_item_type.h to arrow_item.h (#7150) 2026-08-21 19:22:44 +02:00
translate_counter_name.cpp [Game] Move graphics out of game and into game_graphics (#6928) 2026-06-09 09:51:13 +02:00
translate_counter_name.h [Game] Move graphics out of game and into game_graphics (#6928) 2026-06-09 09:51:13 +02:00