mirror of
https://github.com/Cockatrice/Cockatrice.git
synced 2026-09-21 09:05:10 -07:00
1c93309952
* [Client] Show localized card names, texts and pictures
Localization wiring now runs end to end: the oracle importer collects
foreignData for the configured language and the client renders it.
- [Oracle] Import localized names and rules texts for the selected cardLang
- single-face cards store their foreignData name and full text
- multi-face (split/adventure/aftermath/prepare) cards collect the joined
name once and join each face's translated text with the same separator
as the English merge; an incomplete translation falls back to English;
the joined text follows the same highest-priority-set policy as the
single-face path and is only collected when localization is enabled
- the wizard switching languages re-imports the card database
- [Client] Display localized card info throughout the client
- card info text/picture widgets and the game board re-render on language
change
- pictures resolve cardLang art through Scryfall's named endpoint using the
localized name, falling back to id-based art when no match exists
- deck editor keeps canonical English names as card identity (EditRole)
while showing localized names (DisplayRole), so decks and wire names
stay stable
- [Card] Add CardLocalization-backed name/text lookup and cards.xml v4
localization elements with a bounded-size translation cache
- [Tests] Cover oracle foreignData import (incl. multi-face joins, priority
and fallback paths), XML v4 localization parsing, deck model localized
display and the language-aware settings default
Existing installations need to re-run Oracle to see translations: localized
data only lands in cards.xml when the Oracle app is started with the
preferred language selected — launch the separate "Oracle" program that
ships with Cockatrice, pick the language in the wizard and let it re-import
the card database.
The client's database cache (cards.xml.cache) is invalidated by the cache
format bump and the source-hash checks, but a cache written before the
re-import can still hold English-only entries (the hash uses file size and
mtime, so a same-size/same-timestamp rewrite may be served as-is); delete
cards.xml.cache and relaunch if no localized names/texts show up after
re-importing.
* [Card] Pass localized card names and texts into CardInfo construction
Address review: instead of constructing the card and then calling
setLocalizedName/setLocalizedText (which emit a cardInfoChanged signal per
language), both constructors, both newInstance overloads and their callers
(cards.xml v4 parser and the binary cache reader) now pass the localized maps
as constructor arguments.
* [Client] Rename LocalizedCard:: helpers namespace to CardLocalization
The namespace now matches its header file name, as the review pointed out;
LocalizedCard reads more like a class or struct. Callers (card info text
widget, board card name rendering) are updated to match.
* [Client] Drop unused info member from the card info text widget
The CardInfoPtr member was only ever initialized to nullptr and never read;
remove it together with its initializer.
* [PictureLoader] Add the localized picture URL explicitly, not implicitly
Address review: silently prepending the Scryfall named-picture URL to the
download list whenever a non-English card language was active was surprising,
consumed quota per card when it failed, and could grab the wrong (canon) art on
name collisions, with no way to turn it off.
The insert is now opt-in and user-controlled: changing the card language adds
the template to the top of the download URLs once (persisted, documented in the
re-import prompt, and editable/removable in the deck editor settings), while the
picture loader no longer injects it at request time.
* [Card] Show card languages in the same native (English) format as the UI
Address review: the card text & images language dropdown listed bare native
names, some in inconsistent lowercase (e.g. "čeština", "español de España"),
which makes the languages easy to mix up for users that do not read the script
(e.g. 日本語 vs 한국어). It now mirrors the UI language dropdown and always pairs
the native name with its English name (e.g. "Deutsch (German)",
"日本語 (Japanese)"), using the same fixed casing.
---------
Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
43 lines
No EOL
1.4 KiB
C++
43 lines
No EOL
1.4 KiB
C++
#ifndef CARD_LOCALIZATION_H
|
|
#define CARD_LOCALIZATION_H
|
|
|
|
#include <QString>
|
|
#include <QStringList>
|
|
|
|
/**
|
|
* @namespace CardLocalization
|
|
* @ingroup Cards
|
|
*
|
|
* @brief Shared language metadata for localized card text and images.
|
|
*
|
|
* Lists the language codes Cockatrice can display localized card data for and
|
|
* provides human-readable names. The list is shared between Oracle (which
|
|
* imports the selected language's card data) and the client settings UI (which
|
|
* offers the language choice).
|
|
*/
|
|
namespace CardLocalization
|
|
{
|
|
/**
|
|
* @brief Language codes for which localized card data can be imported/displayed.
|
|
*
|
|
* Matches the languages Scryfall can serve localized card images for. "en" is
|
|
* always available as the default/fallback and is not listed here.
|
|
*
|
|
* @return The list of supported language codes.
|
|
*/
|
|
[[nodiscard]] const QStringList &supportedLanguages();
|
|
|
|
/**
|
|
* @brief Human-readable name for a language code.
|
|
*
|
|
* Follows the same "native name (English name)" format the UI language list
|
|
* uses (e.g. "日本語 (Japanese)"), so the English fallback is always visible.
|
|
*
|
|
* @param lang Language code (e.g. "de", "ja", "zhs").
|
|
* @return The language's native name with its English name in parentheses, or
|
|
* the code itself if it cannot be resolved.
|
|
*/
|
|
[[nodiscard]] QString languageDisplayName(const QString &lang);
|
|
} // namespace CardLocalization
|
|
|
|
#endif // CARD_LOCALIZATION_H
|